glusterfs.git/xlators/cluster, branch release-3.11

ec/cluster: Update failure of fop on a brick properly

2017-08-12T13:39:48+00:00

Problem:
In case of truncate, if writev or open fails on a brick,
in some cases it does not mark the failure onlock->good_mask.
This causes the update of size and version on all the bricks
even if it has failed on one of the brick. That ultimately
causes a data corruption.

Solution:
In callback of such writev and open calls, mark fop->good
for parent too.

Thanks Pranith Kumar K  for finding the
root cause.

>Change-Id: I8a1da2888bff53b91a0d362b8c44fcdf658e7466
>BUG: 1476205
>Signed-off-by: Ashish Pandey 
>Reviewed-on: https://review.gluster.org/17906
>Reviewed-by: Pranith Kumar Karampuri 
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Signed-off-by: Ashish Pandey 

Change-Id: I8a1da2888bff53b91a0d362b8c44fcdf658e7466
BUG: 1476870
Signed-off-by: Ashish Pandey 
Reviewed-on: https://review.gluster.org/17933
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System

cluster/ec: Non-disruptive upgrade on EC volume fails

2017-07-19T11:26:21+00:00

Problem:
Enabling optimistic changelog on EC volume was not
handling node down scenarios appropriately resulting
in volume data inaccessibility.

Solution:
Update dirty xattr appropriately on good bricks whenever
nodes are down. This would fix the metadata information
as part of heal and thus ensures data accessibility.

>BUG: 1468261
>Change-Id: I08b0d28df386d9b2b49c3de84b4aac1c729ac057
>Signed-off-by: Sunil Kumar Acharya 
>Reviewed-on: https://review.gluster.org/17703
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Pranith Kumar Karampuri 

BUG: 1470938
Change-Id: I08b0d28df386d9b2b49c3de84b4aac1c729ac057
Signed-off-by: Sunil Kumar Acharya 
Reviewed-on: https://review.gluster.org/17773
Smoke: Gluster Build System 
Reviewed-by: Ashish Pandey 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

cluster/dht: Clear clean_dst flag on target change

2017-07-19T11:25:43+00:00

If the target of a file migration was changed because
of min-free-disk limits, the dst_fd was closed but the
clean_dst flag was not set to false. If the file could
not be created on the new target for some reason, the
ftruncate call to clean up the dst was sent on the now
invalid fd causing the process to deadlock.

> BUG: 1469029
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17735
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Amar Tumballi 
> Reviewed-by: Raghavendra G 

(cherry picked from commit bd71ca4fdf2554dd22c0db70af132a11b966ef38)
Change-Id: I5bfa80f519b04567413d84229cf62d143c6e2f04
BUG: 1469459
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17745
Smoke: Gluster Build System 
Reviewed-by: Susant Palai 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

cluster/dht: Fix fd check race

2017-07-19T11:25:10+00:00

There is a another race between the cached subvol
being updated in the inode_ctx and the fd being opened on
the target.

1. fop1 -> fd1 -> subvol0
2. file migrated from subvol0 to subvol1 and cached_subvol
   changed to subvol1 in inode_ctx
3. fop2 -> fd1 -> subvol1 [takes new cached subvol]
4. fop2 -> checks fd ctx (fd not open on subvol1) -> opens fd1 on subvol1
5. fop1 -> checks fd ctx (fd not open on subvol0)
   -> tries to open fd1 on subvol0 -> fails with "No such file on directory".

Fix:
If dht_fd_open_on_dst fails with ENOENT or ESTALE, wind to old subvol
and let the phase1/phase2 checks handle it.

> BUG: 1465075
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17731
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Reviewed-by: Amar Tumballi 
(cherry picked from commit f7a450c17fee7e43c544473366220887f0534ed7)
Change-Id: I34f8011574a8b72e3bcfe03b0cc4f024b352f225
BUG: 1465123
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17751
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System

afr: mark non sources as sinks in metadata heal

2017-07-19T11:24:31+00:00

Problem:
In a 3 way replica, when the source brick does not have pending xattrs
for the sinks, but the 2 sinks blame each other, metadata heal was not
happpening because we were not setting all non-sources as sinks.

Fix: Mark all non-sources as sinks, like it is done in data and entry
heal.

> Reviewed-on: https://review.gluster.org/17717
> Smoke: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 
> CentOS-regression: Gluster Build System 
(cherry picked from commit 77c1ed5fd299914e91ff034d78ef6e3600b9151c)

Change-Id: I534978940f5087302e307fcc810a48ffe898ce08
BUG: 1471611
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/17781
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
CentOS-regression: Gluster Build System

cluster/ec : Don't try to heal when no sink is UP

2017-07-10T13:58:33+00:00

Problem:
4 + 2 EC volume configuration.
If untar of linux is going on and we kill a brick,
indices will be created for the files/dir which need
to be healed. ec_shd_index_sweep spawns threads to
scan these entries and start heal. If in the middle
of this we kill one more brick, we end up in a
situation where we can not heal an entry as there
are only "ec->fragment" number of bricks are UP.
However, the scan will be continued and it will
trigger the heal for those entries.

Solution:
When a heal is triggered for an entry, check if it
*CAN* be healed or not. If not come out with ENOTCONN.

>Change-Id: I305be7701c289f36bd7bde22491b71074771424f
>BUG: 1464359
>Signed-off-by: Ashish Pandey 
>Reviewed-on: https://review.gluster.org/17692
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Pranith Kumar Karampuri 
>Reviewed-by: Sunil Kumar Acharya 
>Reviewed-by: Xavier Hernandez 
>Signed-off-by: Ashish Pandey 

Change-Id: I305be7701c289f36bd7bde22491b71074771424f
BUG: 1468457
Signed-off-by: Ashish Pandey 
Reviewed-on: https://review.gluster.org/17724
Smoke: Gluster Build System 
Reviewed-by: Xavier Hernandez 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

cluster/ec: correctly handle end of file for seek

2017-07-06T14:03:32+00:00

When a SEEK_HOLE was issued near to the end of file, sometimes an
offset beyond the end of file was returned. Another problem was that
using some offsets greater than the end of file returned successfully
instead of failing with ENXIO.

 >Change-Id: I238d2884ba02fd19a78116b0f8f8e8d6338fb3f5
 >BUG: 1449348
 >Signed-off-by: Xavier Hernandez 
 >Reviewed-on: https://review.gluster.org/17228
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 
 >Reviewed-by: Amar Tumballi 
 >Reviewed-by: Pranith Kumar Karampuri 
 >(cherry picked from commit eb96dd45f8e583c6bad84bf32ca17e2bb01dd38f)

Change-Id: I238d2884ba02fd19a78116b0f8f8e8d6338fb3f5
BUG: 1468118
Signed-off-by: Xavier Hernandez 
Reviewed-on: https://review.gluster.org/17710
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

dht: passing the errno as an argument to gf_msg

2017-07-05T14:22:09+00:00

There are many calls in gf_msg where errno
is needed to pass as an argument instead of
strerrno(error)

Backport of https://review.gluster.org/#/c/17464/

Change-Id: I15048a5e0b41f9752a2023afe8470eca6f2cd383
Bug: 1464316
Signed-off-by: AnkitRaj 
Reviewed-on: https://review.gluster.org/17464
Smoke: Gluster Build System 
Reviewed-by: MOHIT AGRAWAL 
Reviewed-by: N Balachandran 
Tested-by: N Balachandran 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Karthik U S 
Reviewed-by: Jeff Darcy 
Signed-off-by: ankitraj 
Reviewed-on: https://review.gluster.org/17616
Reviewed-by: Shyamsundar Ranganathan

cluster:dht Fix crash in dht_rename_lock_cbk

2017-07-05T14:10:20+00:00

Use a local variable to store the call count
in the STACK_WIND for loop. Using frame->local
is dangerous as it could be freed while the loop
is still being processed

> BUG: 1466110
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17645
> Smoke: Gluster Build System 
> Tested-by: Nigel Babu 
> Reviewed-by: Amar Tumballi 
> Reviewed-by: Jeff Darcy 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Shyamsundar Ranganathan 

(cherry picked from commit 56da27cf5dc6ef54c7fa5282dedd6700d35a0ab0)
Change-Id: Ie65cdcfb7868509b4a83bc2a5b5d6304eabfbc8e
BUG: 1466859
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17664
Smoke: Gluster Build System 
Reviewed-by: Jeff Darcy 
CentOS-regression: Gluster Build System

cluster/dht: Check if fd is opened on dst subvol

2017-07-03T13:00:52+00:00

If an fd is opened on a file, the file is migrated
and the cached subvol is updated in the inode_ctx
before an fd based fop is sent, the fop is sent to
the dst subvol on which the fd is not opened.
This causes the FOP to fail with EBADF.

Now, every fd based fop will check to see that the fd
has been opened on the dst subvol before winding it down.

> BUG: 1465075
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17630
> Smoke: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Reviewed-by: Susant Palai 
> CentOS-regression: Gluster Build System 
(cherry picked from commit 91db0d47ca267aecfc6124a3f337a4e2f2c9f1e2)
Change-Id: Id92ef5eb7a5b5226688e2d2868b15e383f5f240e
BUG: 1465123
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17643
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System