glusterfs.git/xlators/cluster/stripe, branch v3.4.0qa8

cluster/stripe: handle GF_XATTR_LOCKINFO_KEY in f(get)(set)xattr

2012-11-28T06:44:40+00:00

Change-Id: I4463006a7f54c05e757d877c56e1330fd91aec45
BUG: 808400
Signed-off-by: Raghavendra 
Reviewed-on: http://review.gluster.org/4125
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

build: split CPPFLAGS from CFLAGS

2012-10-03T19:26:45+00:00

Automake provides a separate variable for preprocessor flags
(*_CPPFLAGS). They are already uses in a few places, so make it
consistent and use it everywhere. Note that cflags obtained from
pkg-config often are cppflags, which is why LIBXML2_CFLAGS moves with
into AM_CPPFLAGS, for example.

Change-Id: I15feed1d18b2ca497371271c4b5876d5ec6289dd
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4029
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

build: remove useless explicit -fPIC -shared from

2012-10-03T19:24:59+00:00

 CFLAGS

libtool will automatically add "-fPIC" to the compiler command line as
needed, so there is no need to specify it separately.

"-shared" is normally a linker flag and has an odd effect when used with
libtool --mode=compile, namely that it inhibits production of static
objects. For that however, using AC_DISABLE_STATIC is a lot simpler.

Change-Id: Ic4cba0fad18ffd985cf07f8d6951a976ae59a48f
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4027
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

build: remove -nostartfiles flag

2012-10-02T20:11:43+00:00

The "-nostartfiles" is a discouraged option and is documented to
potentially result in undesired behavior. Since I see no reason why it
should be in glusterfs, remove it.

Change-Id: I56f2b08874516ebad91447b2583ca2fb776bb7ab
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4018
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

build: consolidate common compilation flags into one variable

2012-10-01T23:44:50+00:00

Some -D flags are present in all files, so collect them.
This adds -D${GF_HOST_OS} to some compiler command lines,
but this should not be a problem.

Change-Id: I1aeb346143d4984c9cc4f2750c465ce09af1e6ca
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4013
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

libglusterfs/dict: make 'dict_t' a opaque object

2012-09-06T07:34:15+00:00

* ie, don't dereference dict_t pointer, instead use APIs everywhere
* other than dict_t only 'data_t' should be the valid export from dict.h

* added 'dict_foreach_fnmatch()' API
* changed dict_lookup() to use data_t, instead of data_pair_t

Change-Id: I400bb0dd55519a7c5d2a107e67c8e7a7207228dc
Signed-off-by: Amar Tumballi 
BUG: 850917
Reviewed-on: http://review.gluster.org/3829
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/stripe: handle short writes and errors in writev callback

2012-07-30T18:39:03+00:00

cluster/stripe write callback handling is broken in the event of
server side errors and short writes due to crudely summing up the
return values from each node. This can produce incorrect results
or cause an application to rewrite the wrong portions of a buffer
in an attempt to handle this condition.

Modify cluster/stripe writev handling to record the requested size
of each write and use this data to return the number of consecutive
bytes written from the original request. This allows an application
to retry a write at the point of error (and potentially consume
said error).

BUG: 809975
Change-Id: Ic35cb1e092c29545205aa32e352485c507534ce0
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.com/3700
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

cluster: fix crash on link of named pipe in stripe/replicate vol

2012-07-25T22:03:57+00:00

A crash occurs when attempting to link a named pipe on a striped,
replicated volume. The cause for this crash is attempting to deref
a NULL inode pointer in stripe_link_cbk(). The RCA for this bug
uncovered a couple of problems:

- AFR ignores the inode pointer it receives on failure (returning
  NULL).
- stripe assumes the inode pointer is valid on failure.

Either one of these changes addresses the crash, but this patch
includes both changes. AFR is modified to pass along the inode
pointer it receives (which could still be NULL). stripe is
modified to not assume the inode pointer is valid on fop failure.

BUG: 842825
Change-Id: I9cb2cc918552620929c3ecbd69bc66d4635eafdc
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.com/3727
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Anand Avati

cluster/stripe: don't fail if no fctx on a non-regular file

2012-07-25T21:55:06+00:00

cluster/stripe broke directory rename. Only check for fctx on regular
files.

BUG: 842652
Change-Id: I8a1e7ff30d57c994082cb10471f610023713ee53
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.com/3720
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Anand Avati

stripe: filter coalesce key in getxattr()/listxattr()

2012-07-18T06:05:31+00:00

as 'stripe-coalesce' is an internal key, no need to show it on top
of the mount-point.

Change-Id: Iab836e73d59c42774db8a2eee13fe3b0cd994bc9
Signed-off-by: Amar Tumballi 
BUG: 801887
Reviewed-on: http://review.gluster.com/3680
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda