glusterfs.git/xlators/cluster/ec/src, branch v9dev

Improve logging in EC, client and lock translator

2020-02-03T06:08:37+00:00

Change-Id: I98af8672a25ff9fd9dba91a2e1384719f9155255
Fixes: bz#1779760

cluster/ec: Change handling of heal failure to avoid crash

2019-11-04T11:00:40+00:00

Problem:
ec_getxattr_heal_cbk was called with NULL as second argument
in case heal was failing.
This function was dereferencing "cookie" argument which caused crash.

Solution:
Cookie is changed to carry the value that was supposed to be
stored in fop->data, so even in the case when fop is NULL in error
case, there won't be any NULL dereference.

Thanks to Xavi for the suggestion about the fix.

Change-Id: I0798000d5cadb17c3c2fbfa1baf77033ffc2bb8c
fixes: bz#1729085

Multiple files: make root gfid a static variable

2019-10-14T08:21:52+00:00

In many places we use it, compare to it, etc. It could be a static variable,
as it really doesn't change. I think it's better than initializing to 0
and then doing gfid[15] = 1 or other tricks.

I think there are additional oppportunuties to make more variables static.
This is an attempt at an easy one.

Change-Id: I7f23a30a94056d8f043645371ab841cbd0f90d19
updates: bz#1193929
Signed-off-by: Yaniv Kaul

cluster/ec: Implement read-mask feature

2019-09-27T03:32:27+00:00

fixes: #725
Change-Id: Iaaefe6f49c8193c476b987b92df6bab3e2f62601
Signed-off-by: Pranith Kumar K

cluster/ec: prevent filling shd log with "table not found" messages

2019-09-26T13:59:51+00:00

When self-heal daemon receives an inodelk contention notification, it tries
to locate the related inode using inode_find() and the inode table owned by
top-most xlator, which in this case doesn't have any inode table. This causes
many messages to be logged by inode_find() function because the inode table
passed is NULL.

This patch prevents this by making sure the inode table is not NULL before
calling inode_find().

Change-Id: I8d001bd180aaaf1521ba40a536b097fcf70c991f
Fixes: bz#1755344
Signed-off-by: Xavi Hernandez

ctime/rebalance: Heal ctime xattr on directory during rebalance

2019-09-16T06:42:29+00:00

After add-brick and rebalance, the ctime xattr is not present
on rebalanced directories on new brick. This patch fixes the
same.

Note that ctime still doesn't support consistent time across
distribute sub-volume.

This patch also fixes the in-memory inconsistency of time attributes
when metadata is self healed.

Change-Id: Ia20506f1839021bf61d4753191e7dc34b31bb2df
fixes: bz#1734026
Signed-off-by: Kotresh HR

cluster/ec: Mark release only when it is acquired

2019-09-12T06:36:47+00:00

Problem:
Mount-1                                Mount-2
1)Tries to acquire lock on 'dir1'   1)Tries to acquire lock on 'dir1'
2)Lock is granted on brick-0        2)Lock gets EAGAIN on brick-0 and
				      leads to blocking lock on brick-0
3)Gets a lock-contention            3) Doesn't matter what happens on mount-2
  notification, marks lock->release    from here on.
  to true.
4)New fop comes on 'dir1' which will
  be put in frozen list as lock->release
  is set to true.
5) Lock acquisition from step-2 fails because
3 bricks went down in 4+2 setup.

Fop on mount-1 which is put in frozen list will hang because no codepath will
move it from frozen list to any other list and the lock will not be retried.

Fix:
Don't set lock->release to true if lock is not acquired at the time of
lock-contention-notification

fixes: bz#1743573
Change-Id: Ie6630db8735ccf372cc54b873a3a3aed7a6082b7
Signed-off-by: Pranith Kumar K

cluster/ec: quorum-count implementation

2019-09-08T03:39:52+00:00

fixes: #721
Change-Id: I5333540e3c635ccf441cf1f4696e4c8986e38ea8
Signed-off-by: Pranith Kumar K

cluster/ec: Fix coverity issues

2019-09-07T14:50:09+00:00

Fixed the following coverity issue in both flush/fsync
>>>     CID 1404964:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "fd" suggests that it may be null, but it has already
been dereferenced on all paths leading to the check.
>>>         if (fd != NULL) {
>>>           fop->fd = fd_ref(fd);
>>>             if (fop->fd == NULL) {
>>>                 gf_msg(this->name, GF_LOG_ERROR, 0,
>>>                        "Failed to reference a "
>>>                        "file descriptor.");

fixes bz#1748836
Change-Id: I19c05d585e23f8fbfbc195d1f3775ec528eed671
Signed-off-by: Pranith Kumar K

cluster/ec: Fail fsync/flush for files on update size/version failure

2019-09-06T07:27:21+00:00

Problem:
If update size/version is not successful on the file, updates on the
same stripe could lead to data corruptions if the earlier un-aligned
write is not successful on all the bricks. Application won't have
any knowledge of this because update size/version happens in the
background.

Fix:
Fail fsync/flush on fds that are opened before update-size-version
went bad.

fixes: bz#1748836
Change-Id: I9d323eddcda703bd27d55f340c4079d76e06e492
Signed-off-by: Pranith Kumar K