glusterfs.git/xlators/cluster/ec/src, branch v3.7.4

ec : trusted.ec.version xattr of all root directories of all bricks should be same.

2015-08-30T05:54:44+00:00

Problem:
After replacing the brick using "replace-brick" command and running "heal
full", the version of the root directory of the newly added brick is not
getting healed. heal starts running on the dentries of the root but does not
run on root directory.

Solution:
Run heal on root directory.

> Change-Id: Ifd42a3fb341b049c895817e892e5b484a5aa6f80
> BUG: 1243382
> Signed-off-by: Ashish Pandey 
> Reviewed-on: http://review.gluster.org/11676
> Reviewed-by: Pranith Kumar Karampuri 
> Tested-by: NetBSD Build System 

Change-Id: Ifd42a3fb341b049c895817e892e5b484a5aa6f80
BUG: 1243384
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/11755
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/ec: Fix write size in self-heal

2015-08-14T09:11:13+00:00

Self-heal was always using a fixed block size to heal a file. This
was incorrect for dispersed volumes with a number of data bricks not
being a power of 2.

This patch adjusts the block size to a multiple of the stripe size
of the volume. It also propagates errors detected during the data
heal to stop healing the file and not mark it as healed.

This is a backport if http//review.gluster.org/11862

Change-Id: I5104ae4bfed8585ca40cb45831ca20582566370c
BUG: 1236050
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/11869
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/ec: Fix tracking of good bricks

2015-08-14T09:02:21+00:00

The bitmask of good and bad bricks was kept in the context of the
corresponding inode or fd. This was problematic when an external
process (another client or the self-heal process) did heal the
bricks but no one changed the bitmaks of other clients.

This patch removes the bitmask stored in the context and calculates
which bricks are healthy after locking them and doing the initial
xattrop. After that, it's updated using the result of each fop.

> Change-Id: I225e31cd219a12af4ca58871d8a4bb6f742b223c
> BUG: 1236065
> Signed-off-by: Xavier Hernandez 
> Reviewed-on: http://review.gluster.org/11844
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 

Change-Id: Idbe68b28b865c4b28366703ad1e96ae16ba44b66
BUG: 1235964
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/11867
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/ec: Minimize usage of EIO error

2015-08-08T15:36:57+00:00

>Change-Id: I82e245615419c2006a2d1b5e94ff0908d2f5e891
>BUG: 1245276
>Signed-off-by: Xavier Hernandez 
>Reviewed-on: http://review.gluster.org/11741
>Tested-by: Gluster Build System 
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: NetBSD Build System 

Change-Id: Ifd3d63f88a686a2963c5ba2e62110249f84f338d
BUG: 1250864
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/11852
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

cluster/ec: Handle race between unlock-timer, new lock

2015-07-23T16:36:46+00:00

Problem:
New lock could come at the time timer is on the way to unlock. This was leading
to crash in timer thread because thread executing new lock can free up the
timer_link->fop and then timer thread will try to access structures already
freed.

Fix:
If the timer event is fired, set lock->release to true and wait for unlock to
complete.

Thanks to Xavi and Bhaskar for helping in confirming that this race is the RC.
Thanks to Kritika for pointing out and explaining how Avati's patch can be used
to fix this bug.

> Change-Id: I45fa5470bbc1f03b5f3d133e26d1e0ab24303378
> BUG: 1243187
> Signed-off-by: Pranith Kumar K 
> Reviewed-on: http://review.gluster.org/11670
> Tested-by: Gluster Build System 
> Reviewed-by: Xavier Hernandez 
> Tested-by: NetBSD Build System 

Change-Id: I9af012e717493684b7cd7d1c63baf2fa401fb542
BUG: 1246121
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11752
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez

cluster/ec: Propogate correct errno in case of failures

2015-07-22T06:28:19+00:00

- Also remove internal-fop setting in create/mknod etc xattrs.

Rebalance was failing because ec was giving EIO when lock acquiring fails as
the file/dir doesn't exist. Posix_create/mknod are not setting config xattr
because internal-fop key is present in dict and setxattr for this fails leading
to failure in setting rest of xattrs.

 >Change-Id: Ifb429c8db9df7cd51e4f8ce53fdf1e1b975c9993
 >BUG: 1242254
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11639
 >Reviewed-by: Raghavendra G 
 >Tested-by: Gluster Build System 
 >Reviewed-by: Xavier Hernandez 
 >Tested-by: NetBSD Build System 

BUG: 1243654
Change-Id: Iedb90d6a7d980fb88d6dfa6a6c978a165a4be3fd
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11688
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System

cluster/ec: Prevent data corruptions

2015-07-22T06:27:42+00:00

- On lock reuse preserve 'healing' bits
- Don't set ctx->size outside locks in healing code
- Allow xattrop internal fops also on the fop->mask.

 >Change-Id: I6b76da5d7ebe367d8f3552cbf9fd18e556f2a171
 >BUG: 1232678
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11640
 >Tested-by: NetBSD Build System 
 >Tested-by: Gluster Build System 
 >Reviewed-by: Xavier Hernandez 

BUG: 1243647
Change-Id: I1b3828e4d4a863b84b2c4e732e7965d1302cea47
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11686
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System

cluster/ec: wind readlink on good subvol(s)

2015-07-22T06:27:12+00:00

 >BUG: 1232172
 >Change-Id: I3a56e487840d86147dd85bf5fbe79b165eae289f
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11589
 >Tested-by: NetBSD Build System 
 >Reviewed-by: Xavier Hernandez 
 >Tested-by: Gluster Build System 

BUG: 1234679
Change-Id: I08560eee095a3921e9c24f16dc2a242a76018a42
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11687
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez

cluster/ec: Don't read from bricks that are healing

2015-07-22T06:26:47+00:00

 >BUG: 1232678
 >Change-Id: I35503039e4723cf7f33d6797f0ba90dd0aca130b
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11580
 >Tested-by: NetBSD Build System 
 >Tested-by: Gluster Build System 
 >Reviewed-by: Xavier Hernandez 

BUG: 1243647
Change-Id: I4eb45197a5a8d9652eded37ba1e67d9ea745a583
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11685
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System

cluster/ec: Remove locks in opendir

2015-07-21T21:43:40+00:00

With readdir[p] taking locks to figure out which bricks are
good/bad, no need to take any locks on opendir.

 >BUG: 1232172
 >Change-Id: I4d924aeeaecab23af08c4598548a20d2a44cd849
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/11506
 >Reviewed-by: Xavier Hernandez 
 >Tested-by: NetBSD Build System 
 >Tested-by: Gluster Build System 

BUG: 1234679
Change-Id: Ibada9c196fb44a38400ef027f0a3a142d32797a6
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11684
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez