glusterfs.git/xlators/cluster/ec/src, branch bug-deprecated

cluster/ec: Handle internal xattr get/set

2015-01-09T05:55:37+00:00

Problem:
Internal xattrs of EC like trusted.ec.size/config/version
can be modified by users and that can lead to misbehavior
in EC.

Fix:
Don't let the user modify the xattrs. Hide these xattrs
in getfattr outputs.

Change-Id: I39cec96ae12826b506b496fda7da74201015fd75
BUG: 1178688
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9385
Tested-by: Gluster Build System 
Reviewed-by: Emmanuel Dreyfus 
Tested-by: Emmanuel Dreyfus 
Reviewed-by: Xavier Hernandez

cluster/ec: Do not modify quota, selinux xattrs in healing

2015-01-09T05:55:10+00:00

Problem:
EC heal tries to heal quota-size, selinux xattrs as well.  quota-size is
private to the brick but since quotad accesses them using the standard
interface as well, they can not be filtered in the fops.

Fix:
Ignore QUOTA_SIZE_KEY and SELINUX xattrs during heal.

Change-Id: I1572f9e2fcba7f120b4265e034953a15ff297f04
BUG: 1179640
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9401
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System

ec: Fix more mutex related coverity scan issues

2014-12-17T17:14:51+00:00

This patch solves CID 1257622.

Change-Id: I95680c7de49cd84011d2ad38f02e5fad82e15c90
BUG: 1170254
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9263
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

ec: Fix return errors when not enough bricks

2014-12-05T11:39:07+00:00

Changes introduced by this patch:

* Fix an incorrect error propagation when the state of the life
  cycle of a fop returns an error.

* Fix incorrect unlocking of failed locks.

* Return ENOTCONN if there aren't enough bricks online.

* In readdir(p) check that the fd has been successfully open by
  a previous opendir.

Change-Id: Ib44f25a1297849ebcbab839332f3b6359f275ebe
BUG: 1162805
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9098
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

ec: Fix mutex related coverity scan issues

2014-12-04T19:36:32+00:00

This patch solves 3 issues detected by coverity scan:

    CID1241484 Data race condition
    CID1241486 Data race condition
    CID1256173 Thread deadlock

With this patch, inode lock is never acquired inside a region locked
with fop->lock.

Change-Id: I35c4633efd1b68b9f72b42661fa7c728b1f52c6a
BUG: 1170254
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9230
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

ec: Fix incorrect value of EC_MAX_NODES

2014-12-04T19:35:19+00:00

EC_MAX_NODES was incorrectly calculated. Now the value if computed
as the minimum between the theoretical maximum and the limit imposed
by the Galois Field.

Change-Id: I75a8345147f344f051923d66be2c10d405370c7b
BUG: 1167419
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9193
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

ec: Fix self-healing issues.

2014-12-04T19:34:38+00:00

Three problems have been detected:

1. Self healing is executed in background, allowing the fop that
   detected the problem to continue without blocks nor delays.

   While this is quite interesting to avoid unnecessary delays,
   it can cause spurious failures of self-heal because it may
   try to recover a file inside a directory that a previous
   self-heal has not recovered yet, causing the file self-heal
   to fail.

2. When a partial self-heal is being executed on a directory,
   if a full self-heal is attempted, it won't be executed
   because another self-heal is already in process, so the
   directory won't be fully repaired.

3. Information contained in loc's of some fop's is not enough
   to do a complete self-heal.

To solve these problems, I've made some changes:

* Improved ec_loc_from_loc() to add all available information
  to a loc.

* Before healing an entry, it's parent is checked and partially
  healed if necessary to avoid failures.

* All heal requests received for the same inode while another
  self-heal is being processed are queued. When the first heal
  completes, all pending requests are answered using the results
  of the first heal (without full execution), unless the first
  heal was a partial heal. In this case all partial heals are
  answered, and the first full heal is processed normally.

* An special virtual xattr (not physically stored on bricks)
  named 'trusted.ec.heal' has been created to allow synchronous
  self-heal of files.

  Now, the recommended way to heal an entire volume is this:

    find  -d -exec getfattr -h -n trusted.ec.heal {} \;

Some minor changes:

* ec_loc_prepare() has been renamed to ec_loc_update().

* All loc management functions return 0 on success and -1 on
  error.

* Do not delay fop unlocks if heal is needed.

* Added basic ec xattrs initially on create, mkdir and mknod
  fops.

* Some coding style changes

Change-Id: I2a5fd9c57349a153710880d6ac4b1fa0c1475985
BUG: 1161588
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9072
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

ec: Change license

2014-12-03T18:45:26+00:00

Change-Id: Iae90ade2421898417b53dec0417a610cf306c44b
BUG: 1168167
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9201
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

ec: Avoid self-heal on directories on (f)stat calls

2014-11-15T18:00:47+00:00

To avoid inconsistent directory listings, a full self-heal
cannot happen on a directory until all its contents have
been healed. This is controlled by a manual command using
getfattr recursively and in post-order.

While navigating the directories, sometimes an (f)stat fop
can be sent. This fop caused a full self-heal of the directory.

This patch makes that (f)stat only initiates a partial self-heal.

Change-Id: I0a92bda8f4f9e43c1acbceab2d7926944a8a4d9a
BUG: 1163760
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9117
Reviewed-by: Dan Lambright 
Tested-by: Gluster Build System

ec: Correctly handle quota xattrs

2014-11-12T09:46:38+00:00

Change-Id: I35e11d83c318210d44b918e847cf13db35b01510
BUG: 1158008
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/8990
Reviewed-by: Dan Lambright 
Tested-by: Gluster Build System