glusterfs.git/xlators/cluster/dht, branch v4.1.0 cluster/dht: Fix rebalance log msg 2018-05-31T13:13:39+00:00 N Balachandran nbalacha@redhat.com 2018-05-21T05:34:45+00:00 67086dbd9e8fbe8ff21ba3cccdf21530ba3f80ff Corrected the name of the xattr and fixed the code to log an error only if op_errno is not ENODATA or ENOATTR. Change-Id: I42c5b1d838eec586ac7bed2471eb1d27ff09a9ea fixes: bz#1583769 Signed-off-by: N Balachandran <nbalacha@redhat.com> 
Corrected the name of the xattr and fixed
the code to log an error only if op_errno
is not ENODATA or ENOATTR.

Change-Id: I42c5b1d838eec586ac7bed2471eb1d27ff09a9ea
fixes: bz#1583769
Signed-off-by: N Balachandran <nbalacha@redhat.com>
cluster/dht: Remove EIO from dht_inode_missing 2018-05-22T10:27:57+00:00 N Balachandran nbalacha@redhat.com 2018-05-16T12:45:02+00:00 06fa5aff8de34a13db0e054800578cf8a45df152 Removed EIO from the list of errnos that triggered a migrate check task. (cherry picked from commit c925962b91c67c8cd2391df7dd0251e0cbf66648) Change-Id: I7f89c7a16056421588f1af2377cebe6affddcb47 fixes: bz#1579674 Signed-off-by: N Balachandran <nbalacha@redhat.com> 
Removed EIO from the list of errnos that triggered
a migrate check task.

(cherry picked from commit c925962b91c67c8cd2391df7dd0251e0cbf66648)

Change-Id: I7f89c7a16056421588f1af2377cebe6affddcb47
fixes: bz#1579674
Signed-off-by: N Balachandran <nbalacha@redhat.com>
cluster/dht: Debug logs in dht_readdir(p)_cbk 2018-05-22T10:27:08+00:00 N Balachandran nbalacha@redhat.com 2018-05-08T08:04:35+00:00 c4029bb820bf695ff63b67a49a127633c34acb27 Additional log messages to help debug issues with file listings. (cherry picked from commit d3e3b11d38b927cf849d2d7a20460650963fd438) Change-Id: Iccd07498ba01d597c0c40f026f4177dd06d7e901 fixes: bz#1579736 Signed-off-by: N Balachandran <nbalacha@redhat.com> 
Additional log messages to help debug issues
with file listings.

(cherry picked from commit d3e3b11d38b927cf849d2d7a20460650963fd438)
Change-Id: Iccd07498ba01d597c0c40f026f4177dd06d7e901
fixes: bz#1579736
Signed-off-by: N Balachandran <nbalacha@redhat.com>
dht: Excessive 'dict is null' logs in dht_discover_complete 2018-05-22T10:25:07+00:00 Mohit Agrawal moagrawa@redhat.com 2018-05-21T03:46:21+00:00 fda6837faeb6b19aa658e818a3cae0f41e4f18bc Problem: In Geo-Rep setup excessive "dict is null" logs in dht_discover_complete while xattr is NULL Solution: To avoid the logs update a condition in dht_discover_complete BUG: 1580215 Change-Id: Ic7aad712d9b6d69b85b76e4fdf2881adb0512237 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com> 
Problem: In Geo-Rep setup excessive "dict is null" logs in
         dht_discover_complete while xattr is NULL

Solution: To avoid the logs update a condition in dht_discover_complete



BUG: 1580215
Change-Id: Ic7aad712d9b6d69b85b76e4fdf2881adb0512237
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
dht: Avoid dict log flooding for internal MDS xattr 2018-05-22T04:52:41+00:00 Mohit Agrawal moagrawa@redhat.com 2018-05-21T03:30:32+00:00 bff50319915ff0dfcb9bb8ebc23b40b4341f840f Problem: Before populate MDS internal xattr first dht checks if MDS is present in xattr or not.If xattr dictionary is NULL dict_get log the message either dict or key is NULL Solution: Before call dict_get check xattr, if it is NULL then no need to call dict_get. BUG: 1579757 Change-Id: I81604ec5945b85eba14b42f4583d06ec713028f4 Signed-off-by: Mohit Agrawal <moagrawa@redhat.com> 
Problem: Before populate MDS internal xattr first dht checks if MDS is
         present in xattr or not.If xattr dictionary is NULL dict_get
         log the message either dict or key is NULL

Solution: Before call dict_get check xattr, if it is NULL then no
          need to call dict_get.


BUG: 1579757
Change-Id: I81604ec5945b85eba14b42f4583d06ec713028f4
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
Revert "gfapi: return pre/post attributes from glfs_pread/pwrite" 2018-05-08T15:27:48+00:00 ShyamsundarR srangana@redhat.com 2018-05-08T15:06:15+00:00 16873e16f3fdfe7f83ca919ad188075eebb5dd7c This reverts commit d01f7244e9d9f7e3ef84e0ba7b48ef1b1b09d809. This is being reverted as the API signatures should adapt to a statx like structure, and also all APIs that need to return pre/post attrs are not complete. As a result, instead of fixing up part of the APIs and then refixing the same in a later release, removing these set of fixes from the branch Additionally fixed up posix-entry-ops.c which was using the new syncop signature Updates: bz#1575386 Change-Id: I35222dadc4a2e97010bc1e6b97b6f83583c311f6 
This reverts commit d01f7244e9d9f7e3ef84e0ba7b48ef1b1b09d809.

This is being reverted as the API signatures should adapt to a
statx like structure, and also all APIs that need to return
pre/post attrs are not complete.

As a result, instead of fixing up part of the APIs and then
refixing the same in a later release, removing these set of
fixes from the branch

Additionally fixed up posix-entry-ops.c which was using the
new syncop signature

Updates: bz#1575386
Change-Id: I35222dadc4a2e97010bc1e6b97b6f83583c311f6
Revert "gfapi: return pre/post attributes from glfs_fsync/fdatasync" 2018-05-08T15:27:48+00:00 ShyamsundarR srangana@redhat.com 2018-05-08T15:03:55+00:00 427951b7f74c643d5b7c7c946bc348209b974274 This reverts commit 09943beb499617212f2985ca8ea9ecd1ed1b470e. This is being reverted as the API signatures should adapt to a statx like structure, and also all APIs that need to return pre/post attrs are not complete. As a result, instead of fixing up part of the APIs and then refixing the same in a later release, removing these set of fixes from the branch. Updates: bz#1575386 Change-Id: I3e0803c114dc6b9126d8a90f43812bca501e6338 
This reverts commit 09943beb499617212f2985ca8ea9ecd1ed1b470e.

This is being reverted as the API signatures should adapt to a
statx like structure, and also all APIs that need to return
pre/post attrs are not complete.

As a result, instead of fixing up part of the APIs and then
refixing the same in a later release, removing these set of
fixes from the branch.

Updates: bz#1575386
Change-Id: I3e0803c114dc6b9126d8a90f43812bca501e6338
Revert "gfapi: return pre/post attributes from glfs_ftruncate" 2018-05-08T15:27:48+00:00 ShyamsundarR srangana@redhat.com 2018-05-08T15:02:25+00:00 acaea514b6c31099e657224adb116a96070d51a2 This reverts commit 248152767b0599986bbb6bb35fc27197f6be6964. This is being reverted as the API signatures should adapt to a statx like structure, and also all APIs that need to return pre/post attrs are not complete. As a result, instead of fixing up part of the APIs and then refixing the same in a later release, removing these set of fixes from the branch. Additionally fixed up cloudsync.c code that was using the new syncop signature. Updates: bz#1575386 Change-Id: Idb59d20666c0d7b0c83e7fdc31dd68b8c7db9550 
This reverts commit 248152767b0599986bbb6bb35fc27197f6be6964.

This is being reverted as the API signatures should adapt to a
statx like structure, and also all APIs that need to return
pre/post attrs are not complete.

As a result, instead of fixing up part of the APIs and then
refixing the same in a later release, removing these set of
fixes from the branch.

Additionally fixed up cloudsync.c code that was using the new
syncop signature.

Updates: bz#1575386
Change-Id: Idb59d20666c0d7b0c83e7fdc31dd68b8c7db9550
cluster/dht: unwind if dht_selfheal_dir_mkdir returns an error 2018-05-03T11:00:12+00:00 Raghavendra G rgowdapp@redhat.com 2018-05-03T04:04:39+00:00 86a0a7e562f4f1c2f5e68c10a917aeaf1d984365 If dht_selfheal_dir_mkdir returns an error, cbk passed to dht_selfheal_directory is not invoked. So, Current codepath leaves an unwound frame resulting in a hung fop forever. Change-Id: I422308b8a34a074301ca46b029ffe676f5e0f66c fixes: bz#1574305 Signed-off-by: Raghavendra G <rgowdapp@redhat.com> 
If dht_selfheal_dir_mkdir returns an error, cbk passed to
dht_selfheal_directory is not invoked. So, Current codepath leaves an
unwound frame resulting in a hung fop forever.

Change-Id: I422308b8a34a074301ca46b029ffe676f5e0f66c
fixes: bz#1574305
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
dht: gf_defrag_settle_hash should ignore ENOENT and ESTALE error 2018-04-30T19:36:03+00:00 Susant Palai spalai@redhat.com 2018-04-27T11:10:02+00:00 e2fda098112803bf651c4795952376cb8c1ad204 Problem: A directory deletion can happen just before gf_defrag_settle_hash which internally does a setxattr operation on a directory. Solution: Ignore ENOENT and ESTALE errors Fixes: bz#1572581 Change-Id: I2f91809f3b5e02976c4c3a5a596406a8b2f8f6f2 Signed-off-by: Susant Palai <spalai@redhat.com> 
Problem: A directory deletion can happen just before gf_defrag_settle_hash
which internally does a setxattr operation on a directory.

Solution: Ignore ENOENT and ESTALE errors

Fixes: bz#1572581
Change-Id: I2f91809f3b5e02976c4c3a5a596406a8b2f8f6f2
Signed-off-by: Susant Palai <spalai@redhat.com>