glusterfs.git/xlators/cluster/dht/src, branch v3.4.2qa3

cluster/dht: Fix anomaly check

2013-12-14T14:25:21+00:00

We were wrongly detecting holes/overlaps for already accounted
errors. Additionally, sort should also handle zero'ed out layout

Change-Id: Ic3d13e1d735b914f9acc01fe919bc90656baea48
BUG: 1003851
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5762
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6469
Reviewed-by: Vijay Bellur

cluster/dht: Del GF_READDIR_SKIP_DIRS key from dict for first_up

2013-12-14T13:28:32+00:00

Currently, we sent GF_READDIR_SKIP_DIRS for all subvolumes if
first_subvol != first_up_subvolume.

Also first_up_subvolume can change with-in the life of a call and
cbk. Saving the first_up_subvol in dht_local for checks.

Back porting fix http://review.gluster.org/5577

BUG: 996474
Change-Id: I67b5bbe781e12812557b569b7d0a0beba4224159
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/6468
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Do migration inprog/complete check only if ENOENT

2013-12-14T07:37:13+00:00

Additionally, update op_errno to the lasted failure. If failures
found in complete_check, error returned would be EUCLEAN instead
of the right failure (in this case ENOENT)

Change-Id: Ib813867f4b817af651627b9ea07b0b09fa2b26ce
BUG: 966852
Original-author: shishir gowda 
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6495
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: set layout in inode ctx even if linkfile fails

2013-12-10T17:44:58+00:00

Creating linkfile could have failed, but we dont care about linkfile
for setting layout in the inode ctx (could be EEXIST etc.)

So ignore @inode in cbk and pick it up from local->loc.inode

Backporting  http://review.gluster.org/6319
BUG: 1032859

Change-Id: Ic95e303a4c060900d041820d4faa68d1c4685b6a
Original-author: Anand Avati 
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/6470
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

distribute: Rebalance should provide even disk space distribution

2013-12-10T12:14:57+00:00

Earlier disk space check had an issue which didn't
provide the needed functionality to avoid migration
when the destination had lesser available space,
scenario we need to avoid is stated below :

During rebalance `migrate-data` - Destination subvol experiences
a `reduction` in 'blocks' of free space, at the same time source
subvol gains certain 'blocks' of free space. A valid check is
necessary here to avoid errorneous move to destination where
the space could be scantily available.

This patch provides a proper fix in place by subtracting
necessary file blocks from destination and adding those blocks
to source.

backporting fix http://review.gluster.org/5961

BUG: 982919
Original-author: Harshavardhana 
Signed-off-by: shishir gowda 

Change-Id: If5808eaa89e66d7bcaeee7268fe3fe5b1b56f51d
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/6461
Reviewed-by: Harshavardhana 
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

cluster/dht: handle NULL check before strlen/strcmp in fgetxattr

2013-12-03T10:23:18+00:00

@key can legally be NULL. Handle that case without crashing.

Change-Id: Iaae293caa7eeb24afc9cd2580799173e2ce00911
BUG: 1036879
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6402
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: set layout in inode ctx even if linkfile fails

2013-11-26T20:52:25+00:00

Creating linkfile could have failed, but we dont care about linkfile
for setting layout in the inode ctx (could be EEXIST etc.)

So ignore @inode in cbk and pick it up from local->loc.inode

Change-Id: I2952799d7ae0d3441b84b2ca2981afd75d7576e2
BUG: 1032859
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6358
Tested-by: Gluster Build System

core: fix errno for non-existent GFID

2013-11-26T19:49:05+00:00

When clients refer to a GFID which does not exist, the errno to
be returned in ESTALE (and not ENOENT). Even though ENOENT might
look "proper" most of the time, as the application eventually expects
ENOENT even if a parent directory does not exist, not returning
ESTALE results in resolvers (FUSE and GFAPI) to not retry resolution
in uncached mode. This can result in spurious ENOENTs during
concurrent path modification operations.

Change-Id: I7a06ea6d6a191739f2e9c6e333a1969615e05936
BUG: 1032894
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6322
Tested-by: Gluster Build System

cluster/dht: Treat migration failures due to space constraints as skipped

2013-09-20T06:39:40+00:00

Currently rebalance/remove-brick op's display migration failed count even
for files which failed due to space issues (not enough space for file, or
migration leading to cluster imbalance)

These will now be counted as skipped, and rebalance/remove-brick status
will display the additional counter

BUG: 989846
Change-Id: I4efa7ce69dd43680ff47181afed0c561954c5080
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5977
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Ignore subvols with error in min-free-disk/inodes

2013-09-10T16:05:18+00:00

Currently when selecting a alternative subvolume when hashed
subvol has exceeded min-free-disk/inodes, we do not check if
layouts have errors (including decommissioning). This leads
to data being written to those subvolumes, and in case of
decommissioning, will lead to data loss.

BUG: 982919

> Original-Author: shishir gowda 
> Reviewed-on: http://review.gluster.org/5299

Change-Id: If301a86cf3ca5fad6529bd2e61382f9901663ba0
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/5888
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur