glusterfs.git/xlators/cluster/dht/src, branch v3.11.2

cluster/dht: Clear clean_dst flag on target change

2017-07-19T11:25:43+00:00

If the target of a file migration was changed because
of min-free-disk limits, the dst_fd was closed but the
clean_dst flag was not set to false. If the file could
not be created on the new target for some reason, the
ftruncate call to clean up the dst was sent on the now
invalid fd causing the process to deadlock.

> BUG: 1469029
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17735
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Amar Tumballi 
> Reviewed-by: Raghavendra G 

(cherry picked from commit bd71ca4fdf2554dd22c0db70af132a11b966ef38)
Change-Id: I5bfa80f519b04567413d84229cf62d143c6e2f04
BUG: 1469459
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17745
Smoke: Gluster Build System 
Reviewed-by: Susant Palai 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

cluster/dht: Fix fd check race

2017-07-19T11:25:10+00:00

There is a another race between the cached subvol
being updated in the inode_ctx and the fd being opened on
the target.

1. fop1 -> fd1 -> subvol0
2. file migrated from subvol0 to subvol1 and cached_subvol
   changed to subvol1 in inode_ctx
3. fop2 -> fd1 -> subvol1 [takes new cached subvol]
4. fop2 -> checks fd ctx (fd not open on subvol1) -> opens fd1 on subvol1
5. fop1 -> checks fd ctx (fd not open on subvol0)
   -> tries to open fd1 on subvol0 -> fails with "No such file on directory".

Fix:
If dht_fd_open_on_dst fails with ENOENT or ESTALE, wind to old subvol
and let the phase1/phase2 checks handle it.

> BUG: 1465075
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17731
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Reviewed-by: Amar Tumballi 
(cherry picked from commit f7a450c17fee7e43c544473366220887f0534ed7)
Change-Id: I34f8011574a8b72e3bcfe03b0cc4f024b352f225
BUG: 1465123
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17751
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System

dht: passing the errno as an argument to gf_msg

2017-07-05T14:22:09+00:00

There are many calls in gf_msg where errno
is needed to pass as an argument instead of
strerrno(error)

Backport of https://review.gluster.org/#/c/17464/

Change-Id: I15048a5e0b41f9752a2023afe8470eca6f2cd383
Bug: 1464316
Signed-off-by: AnkitRaj 
Reviewed-on: https://review.gluster.org/17464
Smoke: Gluster Build System 
Reviewed-by: MOHIT AGRAWAL 
Reviewed-by: N Balachandran 
Tested-by: N Balachandran 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Karthik U S 
Reviewed-by: Jeff Darcy 
Signed-off-by: ankitraj 
Reviewed-on: https://review.gluster.org/17616
Reviewed-by: Shyamsundar Ranganathan

cluster:dht Fix crash in dht_rename_lock_cbk

2017-07-05T14:10:20+00:00

Use a local variable to store the call count
in the STACK_WIND for loop. Using frame->local
is dangerous as it could be freed while the loop
is still being processed

> BUG: 1466110
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17645
> Smoke: Gluster Build System 
> Tested-by: Nigel Babu 
> Reviewed-by: Amar Tumballi 
> Reviewed-by: Jeff Darcy 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Shyamsundar Ranganathan 

(cherry picked from commit 56da27cf5dc6ef54c7fa5282dedd6700d35a0ab0)
Change-Id: Ie65cdcfb7868509b4a83bc2a5b5d6304eabfbc8e
BUG: 1466859
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17664
Smoke: Gluster Build System 
Reviewed-by: Jeff Darcy 
CentOS-regression: Gluster Build System

cluster/dht: Check if fd is opened on dst subvol

2017-07-03T13:00:52+00:00

If an fd is opened on a file, the file is migrated
and the cached subvol is updated in the inode_ctx
before an fd based fop is sent, the fop is sent to
the dst subvol on which the fd is not opened.
This causes the FOP to fail with EBADF.

Now, every fd based fop will check to see that the fd
has been opened on the dst subvol before winding it down.

> BUG: 1465075
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17630
> Smoke: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Reviewed-by: Susant Palai 
> CentOS-regression: Gluster Build System 
(cherry picked from commit 91db0d47ca267aecfc6124a3f337a4e2f2c9f1e2)
Change-Id: Id92ef5eb7a5b5226688e2d2868b15e383f5f240e
BUG: 1465123
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17643
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System

core: assorted typos and spelling mistakes from Debian lintian

2017-07-03T12:47:48+00:00

Plus minor readability improvements.

Reported-by: pmatthaei@debian.org
master BUG: 1466785
master https://review.gluster.org/17660
Change-Id: I5393819a2fc9f240a19811143bb57b127df717cf
BUG: 1466801
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17661
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

cluster/rebalance: Use GF_XATTR_LIST_NODE_UUIDS_KEY to figure out local subvols.

2017-06-26T16:27:07+00:00

Afr has introduced a new key GF_XATTR_LIST_NODE_UUIDS_KEY,
through which rebalance will figure out its local subvolumes.(Reference
bugid=1463250)

key: GF_XATTR_NODE_UUID_KEY will continue to serve it's old
purpose of returning the first afr chiild.

test: prove tests/basic/distribute/rebal-all-nodes-migrate.t

> BUG: 1463648
> Signed-off-by: Susant Palai 

Change-Id: I4d602feda2a05b29d2210c712a07a4ac6b8bc112
BUG: 1463250
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17627
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

cluster/dht: Additional checks for rebalance estimates

2017-06-22T20:54:08+00:00

The rebalance estimates calculation was not handling
calculations correctly when no files had been processed,
i.e., when rate_lookedup was 0.

Now, the estimated time is set to 0 in such scenarios as
there is no way for rebalance to figure out how long the
process will take to complete without knowing the rate at
which the files are being processed.

> BUG: 1457985
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17564
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Amar Tumballi 
> Reviewed-by: Raghavendra G 

Change-Id: I7b6378e297e1ba139852bcb2239adf2477336b5b
BUG: 1460894
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17598
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System

cluster/dht: Include dirs in rebalance estimates

2017-06-13T14:18:57+00:00

Empty directories were not being considered while
calculating rebalance estimates leading to negative
time-left values being displayed as part of the
rebalance status.

> BUG: 1457985
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17448
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Amar Tumballi 
> Reviewed-by: Raghavendra G 

Change-Id: I48d41d702e72db30af10e6b87b628baa605afa98
BUG: 1460894
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17527
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

cluster/dht: Make optimal usage of buffer provided with readdir(p)

2017-06-06T13:10:15+00:00

dht_readdirp must unwind with list of entries only after
the entire buffer requested by kernel is filled to avoid
extra syscalls occuring when returning partially filled
buffer. Also wind readdir call to next subvol on reaching
EOD for directory on that subvol to avoid extra network call.

>Change-Id: If2e1a2722f813d95457c7542bff25fef56c7a041
>BUG: 1356453
>Signed-off-by: Sakshi 
>Signed-off-by: Raghavendra G 
>Reviewed-on: https://review.gluster.org/12271
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Amar Tumballi 
>Reviewed-by: Susant Palai 

(cherry picked from commit b9406e210717621bc672a63c1cbd1b0183834056)
Change-Id: If2e1a2722f813d95457c7542bff25fef56c7a041
BUG: 1457339
Signed-off-by: Sakshi 
Signed-off-by: Raghavendra G 
Reviewed-on: https://review.gluster.org/17429
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan