glusterfs.git/xlators/cluster/dht/src/dht-common.h, branch v3.4.2qa2

core: fix errno for non-existent GFID

2013-11-26T19:49:05+00:00

When clients refer to a GFID which does not exist, the errno to
be returned in ESTALE (and not ENOENT). Even though ENOENT might
look "proper" most of the time, as the application eventually expects
ENOENT even if a parent directory does not exist, not returning
ESTALE results in resolvers (FUSE and GFAPI) to not retry resolution
in uncached mode. This can result in spurious ENOENTs during
concurrent path modification operations.

Change-Id: I7a06ea6d6a191739f2e9c6e333a1969615e05936
BUG: 1032894
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6322
Tested-by: Gluster Build System

cluster/dht: Treat migration failures due to space constraints as skipped

2013-09-20T06:39:40+00:00

Currently rebalance/remove-brick op's display migration failed count even
for files which failed due to space issues (not enough space for file, or
migration leading to cluster imbalance)

These will now be counted as skipped, and rebalance/remove-brick status
will display the additional counter

BUG: 989846
Change-Id: I4efa7ce69dd43680ff47181afed0c561954c5080
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5977
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Ignore subvols with error in min-free-disk/inodes

2013-09-10T16:05:18+00:00

Currently when selecting a alternative subvolume when hashed
subvol has exceeded min-free-disk/inodes, we do not check if
layouts have errors (including decommissioning). This leads
to data being written to those subvolumes, and in case of
decommissioning, will lead to data loss.

BUG: 982919

> Original-Author: shishir gowda 
> Reviewed-on: http://review.gluster.org/5299

Change-Id: If301a86cf3ca5fad6529bd2e61382f9901663ba0
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/5888
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Create linkfile with file uid/gid

2013-03-04T10:40:01+00:00

Currently, linkfile creation happens as root.

use uid/gid returned from _cbk (link/rename) to set the correct ownership of
the link files.

Also added test/dht.rc to implement common dht functions

BUG: 884597
Change-Id: I6bc0e04f62d4716fc033681e5678e852a1be7a2f
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/4607
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

cluster/dht: pathinfo xattr changes for directories

2013-02-09T03:09:46+00:00

Since directories have presence on all subvolumes there is
no definite meaning of ->hashed_subvol or ->cached_subvol.
getxattr() code path chooses ->cached_subvol for pathinfo
extended attribute. While this makes sense of files, it makes
less sense for directories. Further if a hashed or a cached
subvolume is down, and there's a getxattr request for a
directory, we return with an errno.

This patch changes pathinfo extended attribute contents by
aggregating information from all subvolumes that are up.

Change-Id: I58adb741d63ccfd1d0239af75eb65f26f0fb384d
Signed-off-by: Venky Shankar 
BUG: 856455
Reviewed-on: http://review.gluster.org/4047
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Correct min_free_disk behaviour

2013-02-04T16:43:50+00:00

Problem:
Files were being created in subvol which had less than
min_free_disk available even in the cases where other
subvols with more space were available.

Solution:
Changed the logic to look for subvol which has more
space available.
In cases where all the subvols have lesser than
Min_free_disk available , the one with max space and
atleast one inode is available.

Known Issue: Cannot ensure that first file that is
created right after min-free-value is crossed on a
brick will get created in other brick because disk
usage stat takes some time to update in glusterprocess.
Will fix that as part of another bug.

Change-Id: If3ae0bf5a44f8739ce35b3ee3f191009ddd44455
BUG: 858488
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/4420
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: fixes for gcc's '-pedantic' flag build

2013-01-22T06:17:36+00:00

* warnings on 'void *' arguments
* warnings on empty initializations
* warnings on empty array (array[0])

Change-Id: Iae440f54cbd59580eb69f3ecaed5a9926c0edf95
BUG: 875913
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4219
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/distribute: re-set layouts to prevent overlaps

2012-12-12T00:05:50+00:00

When subvols-per-directory option is used, with bricks addition/removal
the layouts might get distributed to other subvols, which were not part
of the layout before. We need to clean up layouts on old subvolumes, to
prevent overlaps.

Also, we need to make sure if layout-cnt is never less
than subvolume-cnt.

Change-Id: I00994a092ca0c99aedcc41bd9412d43460f88a04
BUG: 884455
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/4281
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: fail fix-layout if any of the subvol is down

2012-11-30T06:11:06+00:00

If any subvolume is down, and a layout is re-written and hash
values change, entry names in the downed subvol can be reused
in the other subvol which got the same hash range. when the
downed subvol is brought back up, duplicate entried might appear

Also separated handling of ENOSPC and ENOTCONN error.

Change-Id: I5ed93990425a4cee70df2dab7c7c119fdc87ad56
BUG: 860663
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/4000
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Heal dir uid/gid

2012-11-29T21:56:11+00:00

Identify mismatching uid/gid in lookup, and trigger a syncop
heal. uid/gid of subvol with latest ctime is trusted (local->prebuf).

Change-Id: Ib5c4bc438e7f4b1f33080e73593f40f400e997f0
BUG: 862967
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/3964
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati