glusterfs.git/xlators/cluster/afr, branch v3.6.0beta2

cluster/afr: Fix spurious metadata self-heals

2014-09-24T17:38:57+00:00

        Backport of http://review.gluster.org/8709

- Added logging for metadata and data self-heals which helped
  in debugging this issue.
- Added checks to skip self-heals when no sinks are available to heal

BUG: 1145987
Change-Id: Ide03af4f531a1280ec8ad95b627285df4d7bc42d
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8832
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Fixed mem leaks in self-heal code path.

2014-09-24T10:48:20+00:00

	backport of: http://review.gluster.org/8821

AFR_STACK_RESET previously didn't cleanup afr_local_t,
leading to memory leaks. With this patch, cleanup is
done.

All credit goes to Pranith Kumar Karampuri.

Change-Id: I26506dfd9273b917eff5127c3e0cf9421e60f228
BUG: 1145914
Reviewed-on: http://review.gluster.org/8831
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

cluster/afr: Do not reset pending xattrs on gfid or type mismatch in entry-sh

2014-09-23T16:50:22+00:00

        Backport of: http://review.gluster.org/8816

Change-Id: I8463a579f542a2336b02edba8f5fbfea0edbbffe
BUG: 1136829
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8823
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Don't start heal when lookup succeeds on < 2 children

2014-09-23T16:49:10+00:00

        Backport of http://review.gluster.org/8698

Problem:
When self-heal code doesn't see at least 2 successes on looking up children,
then self-heal can't be done. What is happening now is if all the lookups fail
then the pending changelog is all zeros in xattrs so all the children are
becoming sources and leading to crashes when the code paths further assume that
some data structures are populated properly

Fix:
Don't proceed with self-heals when < 2 children succeed lookups.

BUG: 1145726
Change-Id: I65465843f0e554c8ccdd8fa930ab42ac123ec023
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8824
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Set all the xattrs needed by index xlator

2014-09-21T17:29:09+00:00

	Backport of: http://review.gluster.org/8652

Index xlator removes the index file from indices
xattrop directory in case the value for keys sent
are zero.

If all the required keys are not set by afr
then index file might be removed in an invalid
way.

With this change all the keys required by index
xlator are set by afr such that invalid removal of
files does not occur.

Change-Id: I1b77904920c8566057415c52242179aec6a015e2
BUG: 1144744
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/8788
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: perform list-xattr during lookup

2014-09-19T18:02:24+00:00

Detect and heal mismatching user extended attributes during lookup.
Backport of: http://review.gluster.org/8558

Change-Id: Id03c9746f083ffd3014711d0b3a2e5a71a45eed4
BUG: 1144274
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/8773
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur

cluster/afr : Mark pending changelog xattrs for new creations

2014-09-18T18:05:47+00:00

        Backport of: http://review.gluster.org/8555

Based on type of file, set appropriate pending changelogs
for new entries.

Change-Id: Icf9af866fe9a9e511210e8ad097e968e2307d8ee
BUG: 1141787
Reviewed-on: http://review.gluster.org/8555
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/8748
Reviewed-by: Vijay Bellur

cluster/afr: Propagate EIO on inode's type mismatch

2014-09-16T11:26:40+00:00

        Backport of: http://review.gluster.org/8574, and
                     http://review.gluster.org/8586

Original author of the test script:
            Pranith Kumar K 

Change-Id: I0c32bdd8e666f8175c0a8fbf940934e6ce469931
BUG: 1136830
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8706
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur

cluster/afr: Fix dict_t leaks

2014-09-16T11:14:36+00:00

        Backport of: http://review.gluster.org/#/c/8557/

dict_t objects that are ref'd in alloca'd "replies" in
afr_replies_copy() are not unref'd before "replies" go out of scope.

Change-Id: I9bb45bc673ec13292ac96dda060aceb48739ebe8
BUG: 1136831
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/8704
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur

cluster/afr: Handle EAGAIN properly in inodelk

2014-09-16T06:02:27+00:00

Problem:
When one of the brick is taken down and brough back up in a replica pair, locks
on that brick will be allowed. Afr returns inodelk success even when one of the
bricks already has the lock taken.

Fix:
If any brick returns EAGAIN return failure to parent xlator.

BUG: 1142020
Change-Id: Iee3f5990be75e10f8accec9bc3856e3f76d1593c
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8744
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur