glusterfs.git/xlators/cluster/afr/src, branch v3.7.7

cluster/afr: change data self-heal size check for arbiter

2016-01-31T02:26:55+00:00

Size mismatch should consider that arbiter brick will have zero size file to
prevent data self-heal to spuriously trigger/assuming need of self-heals.

 >Change-Id: I179775d604236b9c8abfa360657abbb36abae829
 >BUG: 1285634
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/12755
 >Reviewed-by: Ravishankar N 
 >Tested-by: Gluster Build System 
 >Tested-by: NetBSD Build System 
 >(cherry picked from commit 8d2594d77127ba7ea07a0d68afca0939e1817e39)

Change-Id: I90243c01d6d83f46475c975a9bd34d9de84b87da
BUG: 1283956
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12768
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

afr: handle bad objects during lookup/inode_refresh

2016-01-22T05:28:34+00:00

Backport of  http://review.gluster.org/12955,
http://review.gluster.org/#/c/13077/ and http://review.gluster.org/#/c/13185/

If an object (file) is marked bad by bitrot, do not consider the brick
on which the object is present  as a potential read subvolume for AFR
irrespective of the pending xattr values.

Also do not consider the brick containing the bad object while
performing afr_accuse_smallfiles(). Otherwise if the bad object's size
is bigger,we may end up considering that as the source.

Change-Id: I4abc68e51e5c43c5adfa56e1c00b46db22c88cf7
BUG: 1293300
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/13041
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System

afr: skip healing data blocks for arbiter

2016-01-19T00:23:15+00:00

Backport of  http://review.gluster.org/12777

1 ....but still do other parts of data-self-heal like restoring the time
and undo pending xattrs.

2. Perform undo_pending inside inodelks.

3. If arbiter is the only sink, do these other parts of data-self-heal
inside a single lock-unlock sequence.

Change-Id: I64c9d5b594375f852bfb73dee02c66a9a67a7176
BUG: 1286169
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/12778
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

afr: warn if pending xattrs missing during init()

2015-12-29T07:26:57+00:00

Backport of http://review.gluster.org/#/c/13038/

Since commit 6e635284a4411b816d4d860a28262c9e6dc4bd6a
(glusterfs-3.7.7), the afr pending xattrs are stored in the volfile and used
by afr when it initializes. If a cluster is upgraded, prevent afr from loading
until the op-version has been bumped up to 3.7.7 and the volfiles have been
regenerated using a volume set command.

Without this fix, AFR will crash when initialzing.

Change-Id: I14249dedb3f2f77cd754d78d8a9a70fdc5fc8c10
BUG: 1293536
Signed-off-by: Ravishankar N 
(cherry picked from commit 4bfbabfdd698e93a1dc1aad5590ed18f10936c55)
Reviewed-on: http://review.gluster.org/13058
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

afr: refresh inode using fstat

2015-12-29T07:25:23+00:00

Backport of http://review.gluster.org/12894

For fd based operations (fgetxattr, readv etc.) if an inode refresh is
required, do so using fstat instead of lookup. This is because the file
might have been deleted by another client before refresh but posix
mandates that FOPS using already open fds must still succeed.

Change-Id: Id5f71c3af4892b648eb747f363dffe6208e7ac09
BUG: 1290363
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/13040
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/afr : Remove stale indices

2015-12-22T10:12:39+00:00

Change-Id: Iba23338a452b49dc9fe6ae7b4ca108ebc377fe42
BUG: 1283036
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/12336
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-on: http://review.gluster.org/12604
Tested-by: NetBSD Build System

heal : Changed heal info to process all indices directories

2015-12-21T09:19:05+00:00

        Backport of http://review.gluster.org/#/c/12658/

Change-Id: Ida863844e14309b6526c1b8434273fbf05c410d2
BUG: 1287531
Signed-off-by: Anuradha Talur 
Reviewed-on: http://review.gluster.org/12854
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/afr : Readdirp performance enhancement

2015-12-21T09:18:46+00:00

        Backport of: http://review.gluster.org/#/c/12507/

Things done :
1) during lookup and inode_refresh as part of read_txn,
request is sent to detect if heal is required or not.

2) If heal is required, be conservative in setting the
readdirp entry inodes to NULL, otherwise don't be.

3) Self-heal-daemon now crawls both indices/xattrop
and indices/dirty directory while healing.

Change-Id: Ic4a4da63fb7e0726eab5f341a200859b29cf7eb7
BUG: 1287531
Signed-off-by: Anuradha Talur 
Reviewed-on: http://review.gluster.org/12507
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri 
Signed-off-by: Anuradha Talur 
Reviewed-on: http://review.gluster.org/12853

cluster/afr: During name heal, propagate EIO only on gfid or type mismatch

2015-12-18T08:53:55+00:00

        Backport of: http://review.gluster.org/#/c/12973/

When the disk associated with a brick returns EIO during lookup, chances are
that name heal would return an EIO because one of the syncop_XXX() operations
as part of it returned an EIO. This is inherently treated by afr_lookup_selfheal_wrap()
as a split-brain and the lookup is aborted prematurely with EIO even if it
succeeded on the other replica(s).

Change-Id: I754fa59c585712b8037f98a8c3c1737a2167fa1b
BUG: 1292046
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/12979
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri