glusterfs.git/xlators/cluster/afr/src, branch v3.4.0qa5

cluster/afr: Remember type of split-brain in inode-ctx

2012-12-12T00:23:53+00:00

Along with this change, fixed the race of setting the
split-brain status in inode-ctx after unwinding the fop from
self-heal in case of back-ground self-heal.

Change-Id: Ifc829300df485f50f139443802e8b6dc7038b4ad
BUG: 873962
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4198
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/afr: Empty string should not be default option val

2012-12-05T23:35:47+00:00

Glusterd does not allow empty string as default value. Changed
afr option values to disallow empty string as value.

Change-Id: I92a2d658907dbc6101e1139dd91f548acb5506f5
BUG: 859927
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4271
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/afr: mark new entry changelog for create/mknod failures

2012-12-04T22:50:52+00:00

Problem:
When create/mknod fails on some of the nodes, appropriate pending
data/metadata changelogs are not assigned. This was not considered
to be an issue because entry self-heal would do the assigning of
appropriate changelog after creating new entries. But using
the combination of rebalance and remove brick we can construct a
case where a file with same name and gfid can be created in a dir
with different data and link-to xattr without any changelog.

Fix:
When a create/mknod failure is observed mark the appropriate
changelog on the new file created.

Change-Id: I4c32cbf5594a13fb14deaf97ff30b2fff11cbfd6
BUG: 858212
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4207
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

afr: use data trylock mode in read/write self-heal trigger paths

2012-12-04T22:45:23+00:00

Self-heal data lock contention between clients and glustershd
instances can lead to long wait and user response times if the
client ends up pending its lock on glustershd self-heal of a large
file. We have reports of guest vm instances going completely
unresponsive during self-heal of virtual disk images.

Optimize the read/write self-heal trigger codepath
(i.e., afr_open_fd_fix()) to trylock for self-heal and skip the
self-heal otherwise to minimize the likelihood of a running/active
guest of competing with glustershd on arrival of a brick. Note that
lock contention is still possible from the client (e.g., via
lookup).

BUG: 874045
Change-Id: I406443c061ff6acd2a851179626b78352caa5c03
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4258
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

afr: support self-heal data trylock mechanism

2012-12-04T22:45:06+00:00

Introduce a block flag to support an optional blocking or
non-blocking mode in the self-heal data locking mechanism. All
callers are modified to use blocking mode, which is the current
default behavior (no change in behavior is introduced by this
commit).

BUG: 874045
Change-Id: Ib7ff9984578fa11de4e3b6981508100cdddd37cd
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4257
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

afr: make flush non-transactional

2012-12-04T22:42:58+00:00

Flush is historically a transaction to ensure all previous writes
were complete. This is no longer required as write-behind has
learned to make flush a barrier operation (re: conversation w/
Avati).

Flush taking a full file lock causes VMs running on afr volumes
to stall when a migration occurs and self-heal is in progress.
Make afr_flush() a non-transactional operation.

BUG: 874045
Change-Id: If2db83823e280c86b1b29b41361eed7081601632
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4261
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/afr: Provide option to disable readdir failover

2012-12-03T08:11:02+00:00

In a replica pair unlike files, directories may not have their
content in same order, so readdir for same (offset, size) may
not give same entries on both the sobvolumes of replica pair.
Switching over from one subvolume to another may not be a good
idea sometimes. It may lead to duplicate entries or fewer entries
or both. This patch provides a way to disable readdir-failover
so that applications like rebalance can retry if they want to.

Change-Id: I2b23eb224a2e84016a561362932613ac824c11a0
BUG: 859387
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4159
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Added descriptions to afr options

2012-11-30T06:57:41+00:00

Change-Id: I4aef1c79743ee08b62e04d7b709f3e8c6b9dc56a
BUG: 881517
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4244
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

afr: send unique dict_t instances to replicas in self-heal fxattrop

2012-11-29T17:34:14+00:00

afr_sh_data_fxattrop() currently allocates and sends a single xattr
dict_t instance to each replica. The callback codepath references
the returned object in the self-heal in-memory state for the
particular replica. If storage/posix is in the same address-space
(i.e., running a single glusterfs client with a fuse->afr->posix
graph), the same object is modified and returned for each child,
causing corrupted in-memory state and afr xattrs.

Allocate and send independent xattr dict_t's for each replica. This
allows self-heal to work correctly in a single address-space
graph.

BUG: 868478
Change-Id: I42832e85b5d1abb6098c28944c717e129300109e
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4149
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

afr: handle short writes in afr_writev_wind and self-heal to avoid corruption

2012-11-29T17:00:28+00:00

The current failure to handle short writes on writev fops leaves
us open to file corruption. A short write on a user request is
ignored and leaves replicas in an inconsistent state. A short write
during a self-heal is ignored and incorrectly marks the files as
consistent if the heal completes.

Modify user writev handling to return the best case return value
from each of the replicas. Short writes that occur relative to this
value are marked as failed and will require a heal. Modify
self-heal to set an error on a short write and abort the heal.

BUG: 853690
Change-Id: I18b30f58702326249230eeebb361b29e40b535f5
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.org/4150
Reviewed-by: Jeff Darcy 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System