glusterfs.git/xlators/cluster/afr/src, branch v3.3.1qa1

afr: Avoid excessive logging in self-heal.

2012-08-17T09:22:02+00:00

- (Excessive) Logging has been very useful as 'bread-crumbs' in
  many a root-cause analyses. This patch aims at avoiding logging when
  the information could be reconstructed using the xattrs, statedump,
  and/or "volume heal" CLI commands.

Change-Id: I8f646cbee44e98495ea6963f9dfcae95375c8900
BUG: 844804
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3827
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Handle child_up & fd not opened case in xaction

2012-08-17T08:14:38+00:00

RCA:
When an fd is opened while a brick is down, after the brick
comes back up afr issues open on the other brick. It can
fail for a number of reasons (enoent etc). While the system
is in that state, inode/entrylks pre-op happen only on the
brick that is up and fd is opened for fd-fops. post-op should
consider only the bricks where both pre-op and fop succeeded
as success, rest of them as failures. Code now marks only the
children that are down as failures as opposed to child_down &
fd-not-opened. This makes change-log appear as success on the
subvolume where we did not do any fop leading to no change-log
but differences in data/metadata for reg-files.

Fix:
Mark non-participants of fop as failure. This is tracked in
transaction.pre_op[].

Tests:
Simulated the scenario using err-gen on top of one of the client
xlator which fails all fops always. Performed fops and the changelog
represented pending fops on the brick with err-gen loaded. Tested
the case of brick down and perform entry/metadata/data operations
to confirm they still work as expected.

Change-Id: I41905936126b19abba56ca581c0301a894507e1a
BUG: 844987
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3776
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Avoid setting split-brain outside inode locks

2012-08-13T04:51:39+00:00

RCA:
The bug is observed because the decision to mark
a file in split-brain is taken outside appropriate locks.
Lookup gathers xattrs outside any lock. The xattrs being
in split-brain in lookup should only be taken as a hint.
Appropriate inodelks should be taken before confirming
a split-brain. Self-heal confirms this at the moment.

Fix:
Self-heals are launched to inspect xattrs when the
data/metadata self-heal options are turned on.
Decision to set/reset split-brain flag is taken inside
appropriate locks.

Known Issue After fix:
If data/metadata self-heal is turned off, inspecting of
xattrs could not be performed so split-brain behavior
does not work correctly if the self-heal options are turned off.
This bug is handled only in upstream.

Change-Id: I59a43d5ce7bf9ca35bff54a51bf4cfa55d717a9e
BUG: 833727
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3691
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster: fix crash on link of named pipe in stripe/replicate vol

2012-08-09T15:10:20+00:00

A crash occurs when attempting to link a named pipe on a striped,
replicated volume. The cause for this crash is attempting to deref
a NULL inode pointer in stripe_link_cbk(). The RCA for this bug
uncovered a couple of problems:

- AFR ignores the inode pointer it receives on failure (returning
  NULL).
- stripe assumes the inode pointer is valid on failure.

Either one of these changes addresses the crash, but this patch
includes both changes. AFR is modified to pass along the inode
pointer it receives (which could still be NULL). stripe is
modified to not assume the inode pointer is valid on fop failure.

BUG: 842825
Change-Id: I368849b7cfbb137a08ae5f89d26406814ff5bb09
Signed-off-by: Brian Foster 
Reviewed-on: http://review.gluster.com/3790
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: split-brain should be reset on data-self-heal

2012-06-19T17:36:52+00:00

If the govinda flag is set in the beginning then missing_entries_done
will fail the self-heal before it can come to data_self_heal.

Change-Id: I4d5b6a7c3bb26bae78979ee59c7c0997fd3fd84b
BUG: 832305
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3583
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Treat EEXIST as success in hardlink

2012-06-14T11:55:12+00:00

Change-Id: I6711fe9230553306eab6012edea8de157a336a78
BUG: 831151
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3549
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Don't reset split-brain when data-self-heal is off

2012-05-29T05:29:59+00:00

Change-Id: Ie3b2c19e0bee85f64d4c2522beaf7d08e46b8a9e
BUG: 804606
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3466
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Release inodelk on erase changelog failures

2012-05-28T06:12:04+00:00

Change-Id: I58271e1ac5a116b5bc717d7cad9f03eb7dc8a1a4
BUG: 811551
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3416
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Unlock higher entry locks in rename entrylk failure.

2012-05-22T11:31:17+00:00

Change-Id: I4646809ec86baf4b741a874353dbf27fbffb4791
BUG: 823255
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3381
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Perform conservative merge on dir with xattr split-brain

2012-05-22T11:29:15+00:00

BUG: 765587
Change-Id: Ifa7a4eae37b0c887a913c8c59d83a679c96c345b
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3396
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur