glusterfs.git/xlators/cluster/afr/src/afr-self-heald.c, branch v3.4.1qa2

self-heald: Remove stale index even in heal info

2013-01-23T03:43:50+00:00

Change-Id: Ic1c9559aec59c1fb9dfede4aba8895f3b86f32f1
BUG: 861015
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4098
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

cluster/afr: Link inode only on lookup

2013-01-22T05:48:29+00:00

Problem:
When "gluster volume heal  info is executed, crawl's
process_entry is not going to populate iatt structure so the
iatt's gfid will be empty. So inode_links are failing.

Fix:
inode_link should be done only after lookup i.e. when heal is
performed. So moved the inode_link related code to just after
the lookup which is triggered when self-heal is done.

Tests:
The testcase that gives this issue does not give the inode-link
failures anymore. glustershd heal, info commands are working as
expected.
Wrote basic automation tests for proactive-self-heal-daemon
https://github.com/pranithk/gluster-tests/blob/master/afr/proactive-self-heal.sh

Change-Id: Ic112bf104a4d553a64d3d8559f681a25ae1a5362
BUG: 861015
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4090
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Cluster/afr: Fix output for gluster volume heal vn info healed

2012-11-26T09:04:52+00:00

Problem:
Whenever gluster volume heal vol full command is executed, the entries
stored in the circual buffer for sh->healed are added in the dictionary
in the _crawl_post_sh_action function irrespective of whether actual self heal
(due to non-zero values in chage log) takes place or not.

Fix:
Value of key (actual-sh-done) will be set to 1 whenever self heal takes place
due to non-zero change log values and if for some FOP self heal daemon finds
that no self heal required after examining the pending matrix, the value will
be 0.

Change-Id: I11fd0b9ee76759af17c5bca6bfafbaf66bcaacbc
BUG: 863068
Signed-off-by: Venkatesh Somyajula 
Reviewed-on: http://review.gluster.org/4181
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

replicate: don't use synctask_new from within a synctask

2012-10-12T01:08:49+00:00

Change-Id: Iebf821ff720c63ab6da4b219d82c7f1d00769992
BUG: 862838
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4032
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Anand Avati

cluster/afr Changed the message's log level from Error to Debug

2012-10-11T02:14:57+00:00

Change-Id: Ic2506561367bfec9022dc53e9b17b03dc343df95
BUG: 859411
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: http://review.gluster.org/4055
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/afr: Trigger heal on local subvols on any child_up

2012-09-26T02:41:25+00:00

Problem:
The index in the child that comes online is generally empty
because the changes would have happened on the other child which
has been up.  So the sync begins when the other child's poll
time-out happens (i.e. 10 minutes). The expectation is that the
sync must be triggered as soon as the connection with any brick
is established.

Fix:
Whenever any child_up happens trigger the index self-heal on all
local children in the replicate subvolume.

Tests:
1) Checked that the self-heal is triggered on all local children
whenever any child comes online.
2) Checked that the volume heal commands are working fine.

Change-Id: I4f64737866470a2f989349a889ea52782930e11d
BUG: 852741
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/3972
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Anand Avati

afr: Avoid excessive logging in self-heal.

2012-08-24T04:42:19+00:00

- (Excessive) Logging has been very useful as 'bread-crumbs' in
  many a root-cause analyses. This patch aims at avoiding logging when
  the information could be reconstructed using the xattrs, statedump,
  and/or "volume heal" CLI commands.

Change-Id: Iebc6b10ae18f0dd9704bdc6dd03bcfe0f2a09abd
BUG: 844804
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3805
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Self-heald: Prevent logging of errno ENOENT

2012-08-20T14:50:46+00:00

Change-Id: Ie56228dfbdc7e519a344681487164a835488a470
BUG: 835423
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: http://review.gluster.org/3826
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/afr: update loc inode after inode_link

2012-07-31T18:25:39+00:00

RCA:
inode passed to inode_link is not assigned any gfid if the
inode with that gfid is already linked, so loc for opendir
does not have a valid inode

Fix:
Use the linked_inode returned by inode_link in the loc to
perform further operations on the entry.

Tests:
Checked that opendir comes with an loc with valid inode.
Checked that re-opendir happens successfully. Tested index,
full self-heal work fine with the fix.

Change-Id: Idf4ced4cc2320133744962059d363e373af0e5ec
BUG: 826580
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3748
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

remove useless if-before-free (and free-like) functions

2012-07-13T21:03:42+00:00

See comments in http://bugzilla.redhat.com/839925 for
the code to perform this change.

Signed-off-by: Jim Meyering 
BUG: 839925
Change-Id: I10e4ecff16c3749fe17c2831c516737e08a3205a
Reviewed-on: http://review.gluster.com/3661
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati