glusterfs.git/xlators/cluster/afr/src/afr-self-heal.h, branch v3.7.2

afr: add arbitration support

2015-05-05T09:30:41+00:00

Backport of http://review.gluster.org/#/c/10258/

Add logic in afr to work in conjunction with the arbiter xlator when a
replica 3 arbiter volume is created. More specifically, this patch:

* Enables full locks for afr data transaction for such volumes.
* Removes the upfront marking of pending xattrs at the time of pre-op
  and defer it to post-op. (This is an arbiter independent change and is made for all afr transactions.)
* After pre-op stage, check if we can proceed with the fop stage without
  ending up in split-brain by examining the changelog xattrs.
* Unwinds the fop with failure if only one source was available at the
   time of pre-op and the fop happened to fail on particular source brick.
* Skips data self-heal if arbiter brick is the only source available.
* Adds the arbiter-count option to the shd graph.

This patch is a part of the arbiter logic implementation for 3 way AFR
details of which can be found at http://review.gluster.org/#/c/9656/

Change-Id: I9603db9d04de5626eb2f4d8d959ef5b46113561d
BUG: 1217689
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/10514
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

cluster/afr: Do not increment healed_count if no healing was performed

2015-03-05T00:37:56+00:00

PROBLEM:
When file modifications are happening while index heal is launched,
index healer could pick up entries which appeared in indices/xattrop
transiently during the course of the operations on the mount point, and
do not really need any heal. This will cause index healer to keep doing
index-heal in a loop as long as it finds this entry, by believing that
it did successfully heal some gfids even when it didn't.

FIX:
afr_selfheal() now returns a 1 to indicate that it did not (need to)
heal a given gfid. afr_shd_selfheal() will not increment healed_count
whenever afr_selfheal() returns a 1.

Change-Id: I0d97e11392a032a852e8c6508f691300ef0e5b98
BUG: 1194305
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9713
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Reviewed-by: Ravishankar N 
Tested-by: Gluster Build System

cluster/afr: split-brain resolution CLI

2015-01-15T09:28:37+00:00

Extend the AFR heal command to include automated split-brain resolution.

This patch [3/3] is the final patch for afr automated split-brain resolution
implementation.

"gluster volume heal  [full | statistics [heal-count [replica
]] |info [healed | heal-failed | split-brain]| split-brain
{bigger-file  |source-brick  []}]"

The new additions being:
1.gluster volume heal  split-brain bigger-file 
Locates the replica containing the FILE, selects bigger-file as source and
completes heal.

2.gluster volume heal  split-brain source-brick 

Selects  present in  as source and completes heal.

3.gluster volume heal  split-brain 
Selects all split-brained files in  as source and completes
heal.

Note:  can be either the full file name as seen from the root of the
volume (or) the gfid-string representation of the file, which sometimes gets
displayed in the heal info command's output.

Entry/gfid split-brain resolution is not supported.

Example can be found in the test case.

Change-Id: I4649733922d406f14f28ee9033a5cb627b9538b3
BUG: 1136769
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/9377
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System

cluster/afr : Change in volume heal info command

2014-12-23T15:09:23+00:00

	gluster volume heal  info command
will now also display if the files listed (in the output
of the command) are in split-brain or possibly being
healed.

This patch also fixes build warning that occurs.
Change-Id: I1fc92e62137f23b2b9ddf6e05819cee6230741d1
BUG: 1163804
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/9119
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri

heal: glfs-heal implementation

2014-10-15T08:22:02+00:00

Thanks a lot to Niels for helping me to get build stuff right.

Change-Id: I634f24d90cd856ceab3cc0c6e9a91003f443403e
BUG: 1147462
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6529
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System

cluster/afr: Add afr-v1 xattr compatibility

2014-10-01T10:29:12+00:00

All the special cases v1 handles and also
self-accusing pending changelog from v1 pre-op also is handled
in this patch.

Change-Id: Ie10f71633fb20276f01ecafbd728f20483e7029c
BUG: 1128721
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8536
Reviewed-by: Ravishankar N 
Tested-by: Gluster Build System

cluster/afr: Fix spurious metadata self-heals

2014-09-24T08:51:35+00:00

- Added logging for metadata and data self-heals which helped
  in debugging this issue.
- Added checks to skip self-heals when no sinks are available to heal

Change-Id: I0d50dceb84cd9ad4fe00e0b749ddf7d4ff42348a
BUG: 1128721
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8709
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System

cluster/afr: Don't start heal when lookup succeeds on < 2 children

2014-09-23T14:21:44+00:00

Problem:
When self-heal code doesn't see at least 2 successes on looking up children,
then self-heal can't be done. What is happening now is if all the lookups fail
then the pending changelog is all zeros in xattrs so all the children are
becoming sources and leading to crashes when the code paths further assume that
some data structures are populated properly

Fix:
Don't proceed with self-heals when < 2 children succeed lookups.

BUG: 1128721
Change-Id: Iffdf0feebb6f98812d9d01cdd0cf97f3e19ba76f
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8698
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System

cluster/afr: perform list-xattr during lookup

2014-09-06T05:19:33+00:00

Detect and heal mismatching user extended attributes during lookup.
'Forward' port of http://review.gluster.org/#/c/7444/

Change-Id: Id03c9746f083ffd3014711d0b3a2e5a71a45eed4
BUG: 1134691
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/8558
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri

cluster/afr : Mark pending changelog xattrs for new creations

2014-09-03T17:30:26+00:00

Based on type of file, set appropriate pending changelogs
for new entries.

Change-Id: Ifd124bf9bc54b996ce83ab9f39d03b3ccca7eb3c
BUG: 1130892
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/8555
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri