glusterfs.git/xlators/cluster/afr/src/afr-read-txn.c, branch v3.9dev

cluster/afr : Examine data/metadata readable for read-subvol

2015-08-25T17:32:49+00:00

During lookup and discover, currently read_subvol is based
only on data_readable. read_subvol should be decided based
on both data_readable and metadata_readable.

Credits to Ravishankar N for the logic of afr_first_up_child
from http://review.gluster.org/10905/ .

Change-Id: I98580b23c278172ee2902be08eeaafb6722e830c
BUG: 1240244
Signed-off-by: Anuradha Talur 
Reviewed-on: http://review.gluster.org/11551
Reviewed-by: Ravishankar N 
Tested-by: Gluster Build System 
Reviewed-by: Krutika Dhananjay 
Reviewed-by: Pranith Kumar Karampuri

cluster/afr: Fix incorrect logging in read transactions

2015-07-27T06:05:50+00:00

afr_read_txn_refresh_done() at its entry point can fail for
reasons like ENOENT/ESTALE but seldom due to EIO, which is something
_AFR_ would internally generate and not receive in response from
a child translator. AFR is reporting "split-brain" for _any_
kind of failure in read txn, of the following kind:

[2015-07-07 18:04:34.787612] E [MSGID: 108008]
[afr-read-txn.c:76:afr_read_txn_refresh_done] 0-vol3-replicate-3:
Failing STAT on gfid 18a973c4-73d3-48b8-942c-33a6f1a8e6b4:
split-brain observed. [Input/output error]

This patch fixes such misleading errors.

To-Do:
Avoid logging EIO if/when split-brain choice is set.
Will do that as part of a separate commit.

Change-Id: Ib513c75168f7026118ad5b3f0b35e9dd498cfe1e
BUG: 1246052
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/11756
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Anuradha Talur 
Reviewed-by: Ravishankar N 
Tested-by: Gluster Build System

afr: Porting messages to new logging framework

2015-06-27T12:25:05+00:00

     updated

Change-Id: I94ac7b2cb0d43a82cf0eeee21407cff9b575c458
BUG: 1194640
Signed-off-by: arao 
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/9897
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

afr: Block fops when file is in split-brain

2015-06-27T02:30:33+00:00

For directories, block metadata FOPS.
For non-directories, block data and metadata FOPS.
Do not block entry FOPS.

Change-Id: Id7f656f4a513b9d33c457dd7f2d58028dbef8e61
BUG: 1235007
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/11371
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System

cluster/afr: Pick gfid from poststat during fresh lookup for read child calculation

2015-06-25T00:11:00+00:00

Change-Id: I12c1e4f67f4ec4affbe13d7daf871044a8a2a12e
BUG: 1235216
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/11373
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: NetBSD Build System

afr: allow readdir to proceed for directories in split-brain

2015-05-28T09:20:35+00:00

Problem:
afr_read_txn() bails out if read_subvol==-1. This meant that for
directories that were in entry split-brain, FOPS like readdir, access,
stat etc were not allowed.

Fix:
Except for getxattr, all other FOPS are wound on the first up child
of afr.

Change-Id: Iacec8fbb1e75c4d2094baa304f62331c81a6f670
BUG: 1221481
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/10776
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Anuradha Talur 
Tested-by: NetBSD Build System

cluster/afr : enable inspection & resolution of files in split-brain

2015-03-19T13:33:12+00:00

Part 2/2 patch to enable users analyze and resolve
split-brain.

This patch enables :
1) Users to inspect the files in data and metadata split-brain.
2) Resolve the split-brain.
Both using a series of setfattr commands.

Consider a volume "test" with 2 bricks.

1) To inspect a file f1:
setfattr -n replica.split-brain-choice -v test-client-0 f1
        After the execution of this command, if no read_subvol
is found, reads will be served from test-client-0 (corresponding
to brick-0).

2) To resolve split-brain :
setfattr -n replica.split-brain-heal-finalize -v test-client-0 f1
        Execution of this command will lead to the resolution
of data and metadata split-brain with subvol mentioned in the
command (test-client-0 here) as the source and the rest as sink.

Change-Id: Ia20f3ee5abd3119e3d54fcc599f1e55ac65fd179
BUG: 1191396
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/9743
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System

cluster/afr: Implementation of quorum-reads

2015-03-06T05:56:20+00:00

Provide a way of disabling reads when quorum is not met.

Change-Id: Ic4f57c2b87a0b8514600759de3a7a47e217fe3b5
BUG: 1187885
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9543
Reviewed-by: Ravishankar N 
Tested-by: Gluster Build System

cluster/afr: Fix spurious metadata self-heals

2014-09-24T08:51:35+00:00

- Added logging for metadata and data self-heals which helped
  in debugging this issue.
- Added checks to skip self-heals when no sinks are available to heal

Change-Id: I0d50dceb84cd9ad4fe00e0b749ddf7d4ff42348a
BUG: 1128721
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8709
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System

cluster/afr: move messages to new logging framework

2014-05-17T08:46:17+00:00

Change important (from a diagnostics point of view) log messages to use
the gf_msg() framework.

Change-Id: I0a58184bbb78989db149e67f07c140a21c781bc2
BUG: 1075611
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/7784
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri