glusterfs.git/tests, branch v3.6.3beta1

ec: Don't use inodelk on getxattr when clearing locks

2015-02-11T09:40:11+00:00

When command 'clear-locks' from cli is executed, a getxattr request
is received by ec. This request was handled as usual, first locking
the inode. Once this request was processed by the bricks, all locks
were removed, including the lock used by ec.

When ec tried to unlock the previously acquired lock (which was
already released), caused a crash in glusterfsd.

This fix executes the getxattr request without any lock acquired
for the clear-locks command.

This is a backport of http://review.gluster.org/9440/

Change-Id: I77e550d13c4673d2468a1e13fe6e2fed20e233c6
BUG: 1181977
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9444
Reviewed-by: Dan Lambright 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

ec: Fix posix compliance failures

2015-02-11T09:37:55+00:00

This patch solves some problems that caused dispersed volumes to not
pass posix smoke tests:

* Problems in open/create with O_WRONLY
    Opening files with -w- permissions using O_WRONLY returned an EACCES
    error because internally O_WRONLY was replaced with O_RDWR.

* Problems with entrylk on renames.
    When source and destination were the same, ec tried to acquire
    the same entrylk twice, causing a deadlock.

* Overwrite of a variable when reordering locks.
    On a rename, if the second lock needed to be placed at the beggining
    of the list, the 'lock' variable was overwritten and later its timer
    was cancelled, cancelling the incorrect one.

* Handle O_TRUNC in open.
    When O_TRUNC was received in an open call, it was blindly propagated
    to child subvolumes. This caused a discrepancy between real file
    size and the size stored into trusted.ec.size xattr. This has been
    solved by removing O_TRUNC from open and later calling ftruncate.

This is a backport of http://review.gluster.org/9420

Change-Id: I20c3d6e1c11be314be86879be54b728e01013798
BUG: 1159471
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9501
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat

cluster/afr: When parent and entry read subvols are different, set entry->inode to NULL

2015-02-11T09:30:02+00:00

        Backport of: http://review.gluster.org/#/c/9477

That way a lookup would be forced on the entry, and its attributes will
always be selected from its read subvol.

Change-Id: Iaba25e2cd5f83e983fc8b1a1f48da3850808e6b8
BUG: 1186119
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9562
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

ec: Fix failures with missing files

2015-02-11T09:20:24+00:00

When a file does not exist on a brick but it does on others, there
could be problems trying to access it because there was some loc_t
structures with null 'pargfid' but 'name' was set. This forced
inode resolution based on /name instead of  which
would be the correct one. To solve this problem, 'name' is always
set to NULL when 'pargfid' is not present.

Another problem was caused by an incorrect management of errors
while doing incremental locking. The only allowed error during an
incremental locking was ENOTCONN, but missing files on a brick can
be returned as ESTALE. This caused an EIO on the operation.

This patch doesn't care of errors during an incremental locking. At
the end of the operation it will check if there are enough successfully
locked bricks to continue or not.

This is a backport of http://review.gluster.org/9407/

Change-Id: I9360ebf8d819d219cea2d173c09bd37679a6f15a
BUG: 1183716
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/9560
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Raghavendra Bhat

cluster/ec: Handle internal xattr get/set

2015-02-04T11:53:33+00:00

        Backport of http://review.gluster.org/9385

Problem:
Internal xattrs of EC like trusted.ec.size/config/version
can be modified by users and that can lead to misbehavior
in EC.

Fix:
Don't let the user modify the xattrs. Hide these xattrs
in getfattr outputs.

BUG: 1182490
Change-Id: Ie32ebb95ee67cabbb9488951097a517172b45bcf
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/9455
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

afr: Don't write to sparse regions of sink.

2015-02-03T13:24:56+00:00

Backport of http://review.gluster.org/9480

Problem:
When data-self-heal-algorithm is set to 'full', shd just reads from
source and writes to sink. If source file happened to be sparse (VM
workloads), we end up actually writing 0s to the corresponding regions
of the sink causing it to lose its sparseness.

Fix:
If the source file is sparse, and the data read from source and sink are
both zeros for that range, skip writing that range to the sink.

Change-Id: Id23d953fe2c8c64cde5ce3530b52ef91a7583891
BUG: 1187547
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/9515
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat

features/uss: Perform NULL check on @name in svc_getxattr

2015-01-09T05:00:40+00:00

        Backport of: http://review.gluster.org/9378

LISTXATTR fop is internally converted into a GETXATTR with
the "name" parameter set to NULL. In svc_getxattr(), a listxattr
was causing a crash because of a NULL pointer dereference on @name.

FIX:
Add the necessary NULL check.

Change-Id: Ifb4ca2a45ecc78c384e92822403eaf2f1b573798
BUG: 1180070
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9417
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

features/snapview-client: handle readdir requests differently for samba.

2015-01-08T09:41:20+00:00

* For samba export, the entry point is also added to the readdir response.

Change-Id: I825c017e0f16db1f1890bb56e086f36e6558a1c2
BUG: 1175742
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/9218
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9344

uss/gluster: Send success on parent lookup of entry-point.

2015-01-08T09:17:13+00:00

When a lookup sent to snapview-server for entry-point directory
protocol server first tries to resolve gfid of a parent directory.

looking up the parent gfid from a latest snapshot can fail if the
volume is a restored volume. As this gfid is already looked-up by
snapview-client, we can return success for the parent gfid.

Change-Id: Ic9b20561ef79b93032f07c3a81eae54a94e1747b
BUG: 1175744
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/9229
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Vijay Bellur 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9342

USS : fill proper uid and gid during a access call from nfs.

2015-01-08T09:15:35+00:00

Problem : when an user tries to access a file/folder for which
he does not have a proper permission required then fuse gives out
a proper error "Permission denied", but nfs does not give out that
error, rather he can access the file/folder. The reason being uid and
gid of call frame stack takes a default value of uid and gid which
point to root permission.

Solution : Set a proper uid and gid during a access call from nfs

Change-Id: Ib060706fde66ec7e60f242fab1f3e59122ed2245
BUG: 1175739
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9194
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9340
Reviewed-by: Raghavendra Bhat