glusterfs.git/tests, branch v3.4.6beta2

cluster/dht: Fix dht_access treating directory like files

2014-10-20T14:54:59+00:00

When the cluster topology changes due to add-brick, all sub
volumes of DHT will not contain the directories till a rebalance
is completed. Till the rebalance is run, if a caller bypasses
lookup and calls access due to saved/cached inode information
(like NFS server does) then, dht_access misreads the error
(ESTALE/ENOENT) from the new subvolumes and incorrectly tries
to handle the inode as a file. This results in the directories
in memory state in DHT to be corrupted and not heal even post
a rebalance.

This commit fixes the problem in dht_access thereby preventing
DHT from misrepresenting a directory as a file in the case
presented above.

Change-Id: Idcdaa3837db71c8fe0a40ec0084a6c3dbe27e772
BUG: 1139997
Signed-off-by: Shyam 
Reviewed-on: http://review.gluster.org/8462
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/8678
Reviewed-by: Kaleb KEITHLEY

dht: fix rename race

2014-10-20T14:52:48+00:00

If two clients try to rename the same file at the same time, we
sometimes end up with *no file at all* in either the old or new
location.  That's kind of bad.  The culprit seems to be some overly
aggressive cleanup code.  AFAICT, based on today's study of the code,
the intent of the changed section is to remove any linkfile we might
have created before the actual rename.  However, what we're removing
might not be our extra link.  If we're racing with another client that's
also doing a rename, it might be the only remaining link to the user's
data.  The solution, which is good enough to pass this test but almost
certainly still not complete, is to be more selective about when we do
this unlink.  Now, we only do it if we know that, at some point, we did
in fact create the link without error (notably ENOENT on the source or
EEXIST on the destination) ourselves.

Change-Id: I8d8cce150b6f8b372c9fb813c90be58d69f8eb7b
BUG: 1139988
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/8269
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/8672
Reviewed-by: Raghavendra G 
Reviewed-by: Kaleb KEITHLEY

nfs: prevent assertion error with MOUNT over UDP

2014-07-08T18:35:19+00:00

see http://review.gluster.org/#/c/8258/, http://review.gluster.org/8241;
and BZs 1116997, 1116503, respectively.

The MOUNT service over UDP runs in a separate thread. This thread does
not have the correct *THIS xlator set. *THIS points to the global (base)
xlator structure, but GF_CALLOC() requires it to be the NFS-xlator so
that assertions can get validated correctly.

This is solved by passing the NFS-xlator to the pthread function, and
setting the *THIS pointer explicitly in the new thread.

It seems that on occasion (needs further investigation) MOUNT over UDP
does not unregister itself. There can also be issues when the kernel NLM
implementation has been registered at portmap/rpcbind, so adding some
unregister procedures in the cleanup of the test-cases.

Change-Id: Iea3bafd65bf480f2b12da91875c73571594d52d3
BUG: 1117256
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8262
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Santosh Pradhan

storage/posix: do not dereference gfid symlinks before posix_handle_mkdir_hashes()

2014-05-22T11:09:16+00:00

Whenever a new directory is created, its corresponding gfid file must
also be created. This was done first calling MAKE_HANDLE_PATH() to get
the path of the gfid file, then calling posix_handle_mkdir_hashes() to
create the parent directories of the gfid, and finally creating the
soft-link.

In normal circumstances, the gfid we want to create won't exist and
MAKE_HANDLE_PATH() will return a simple path to the new gfid. However if
the volume is damaged and a self-heal is running, it is possible that we
try to create an already existing gfid. In this case, MAKE_HANDLE_PATH()
will return a path to the directory instead of the path to the gfid.

To solve this problem, every time a path to a gfid is needed, a call to
MAKE_HANDLE_ABSPATH() is made instead of the call to MAKE_HANDLE_PATH().

BUG: 1099955
Change-Id: I5bcd2b3c38d172c75946f33519e057e76d960a24
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/6737
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

cluster/dht: Make sure loc has gfid

2014-01-13T12:58:45+00:00

Problem:
In some code paths neither loc->gfid nor loc->inode->gfid
is populated which leads to EINVAL for linkfile setattr
in dht_linkfile_attr_heal.

Fix:
Populate loc->gfid before dht_linkfile_attr_heal.

BUG: 971805
Change-Id: I8e4b7510ee5c38aa9ccf5283c7165c7df25ec62b
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6691
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

tests: Don't use stripe-replicate volume in bug-905864.t

2013-12-24T09:53:36+00:00

Today, stripe doesn't follow a deterministic order in sending posix
locks to its subvolume. This may lead to dead locks. To avoid
intermittent test failures, we modify bug-905864.t to run on replicate
volume.

Change-Id: I38b72f30bc31576d3ca642f0029cc8749314b1dd
BUG: 905864
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/5072
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6588

tests: Change 'volume create' to 'volume create force'

2013-11-27T05:39:30+00:00

Using 'force' when creating volumes prevents errors when creating
bricks in the root partition.
This fixes test bug-823081.t for bug-962226

Change-Id: I210ffda6bdc2cced4bd54755a2b44fdfd05b813b
Original-author: John Smith 
BUG: 962226
Signed-off-by: John Smith 
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/6356
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: changes in 'volume create' behaviour

2013-11-27T05:39:16+00:00

        Backport of http://review.gluster.org/4740

Note: This patch is needed by oVirt's Gluster Integration Project

BUG: 948729
Change-Id: I7a9d7c36b7e15269f95637cd9061abac6f8a97de
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/6355
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Backport of http://review.gluster.org/6262

2013-11-20T06:11:13+00:00

Change-Id: Id93b6755b9a71044a7ed90ac9c779121160a75e0
BUG: 1030208
Signed-off-by: Vijaykumar M 
Reviewed-on: http://review.gluster.org/6271
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Treat migration failures due to space constraints as skipped

2013-09-20T06:39:40+00:00

Currently rebalance/remove-brick op's display migration failed count even
for files which failed due to space issues (not enough space for file, or
migration leading to cluster imbalance)

These will now be counted as skipped, and rebalance/remove-brick status
will display the additional counter

BUG: 989846
Change-Id: I4efa7ce69dd43680ff47181afed0c561954c5080
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.org/5977
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati