glusterfs.git/tests/bugs, branch v3.8.2

posix: Do not move and recreate .glusterfs/unlink directory

2016-08-10T09:31:50+00:00

Problem:
At the time of start of a volume, it is checked if
.glusterfs/unlink exist or not. If it does, move it
to landfill and recreate unlink directory. If a volume
is mounted and we write data on it till we face ENOSPC,
restart of that volume fails as it will not be able to
create unlink dir. mkdir will fail with ENOSPC.
This will not allow volume to restart.

Solution:
If .glusterfs/unlink directory exist, don't move it to
landfill. Delete all the entries inside it.

master -
http://review.gluster.org/#/c/15030/

Change-Id: Icde3fb36012f2f01aeb119a2da042f761203c11f
BUG: 1364365
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/15093
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

glusterd : skip non directories inside /var/lib/glusterd/vols

2016-08-09T15:03:14+00:00

Right now glusterd won't come up if vols directory contains an invalid entry.
Instead of doing that with this change a message will be logged and then skip
that entry

Backport details: 
>Change-Id: I665b5c35291b059cf054622da0eec4db44ec5f68
>BUG: 1318591
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/13764
>Reviewed-by: Prashanth Pai 
>Reviewed-by: Atin Mukherjee 
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
(cherry picked from commit 720b63c24b07ee64e1338db28de602b9abbef0a1)

Change-Id: I665b5c35291b059cf054622da0eec4db44ec5f68
BUG: 1365265
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/15113
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Prashanth Pai 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

tests: fix spurious failure in tests/bugs/glusterd/bug-1089668.t

2016-08-07T11:55:48+00:00

Backport of http://review.gluster.org/15085

Instead of rebalance stop, its always better to wait for rebalance to complete
as the former doesn't have any purpose.

>Reviewed-on: http://review.gluster.org/15085
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Jeff Darcy 

Change-Id: Ia1bc2a34d937a0a96543bebd257dcda619f12474
BUG: 1364326
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15089
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Niels de Vos

libglusterfs: fix glusterd statedump crash

2016-08-07T11:53:48+00:00

Backport of http://review.gluster.org/14987

commit 3c04a91 removed setting typeStr to NULL if num_allocs is set to 0, this
has caused this regression. Code has been put back like earlier and to avoid
statedump printing all the NULL values check is modified to see skip the records
if num_allocs is 0 instead of total_allocs

>Reviewed-on: http://review.gluster.org/14987
>NetBSD-regression: NetBSD Build System 
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: N Balachandran 
>Reviewed-by: Prashanth Pai 
>Reviewed-by: Jeff Darcy 

Change-Id: Ib8bcc2fba908e88cf52b641c3f6bcba74f5e667c
BUG: 1364329
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15091
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Niels de Vos

xlator/trash : append '/' at the end in trash_notify_lookup_cbk

2016-08-05T07:51:28+00:00

In the notify function in trash xlator, a lookup is performed
to obtain path of old trash directory. The result usually contains
path without '/' at the end. The trash xlator maintains expects
'/' at the end for the values such as 'old trash dir' and
'new trash dir'. Otherwise certian checks in the code will fail.

>Change-Id: I89e02e4b249314fb6536297f959865feee182c83
>BUG: 1357397
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/14938
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Anoop C S 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Jeff Darcy 
>(cherry picked from commit d90307c1b0245e0e6a39044a28819cde520a100c)

Change-Id: I89e02e4b249314fb6536297f959865feee182c83
BUG: 1358262
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/14965
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Niels de Vos

snapshot/snapd: Don't display pid when snapd is offline

2016-08-02T06:19:02+00:00

    Backport of http://review.gluster.org/#/c/14981/

We were previously reading the pidfile, and displaying
the pid even if snapd daemon is not running. Now to fix
it, we re-assign pid value to -1, if snapd is offline.

> Reviewed-on: http://review.gluster.org/14981
> Tested-by: Vijay Bellur 
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 

(cherry picked from commit ec6925a379c7bee071df1638bc2751b266cee346)

Change-Id: I4baff8d489fe9380061c52aea006db90fa421cd7
BUG: 1360985
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15033
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

tests: Fix get_pending_heal_count check in ec

2016-07-30T11:40:12+00:00

Backport of http://review.gluster.org/#/c/15006/

Change-Id: I3d274bdc2036392af942a17a0e0bf28f431c947b
BUG: 1360574
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/15047
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Xavier Hernandez

tests: Fix pending-heal-count checks

2016-07-28T14:02:55+00:00

EXPECT_WITHIN takes regular expression to match the count,
so even when there are say 10 entries to heal, it would
think that the heal is complete. Fixed checking
pending heal count with correct regex.

Thanks to Xavi for finding this problem.

 >Change-Id: Ic593d22468b2b586bfca864962ffa0eda96b1d1f
 >BUG: 1332054
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/14985
 >Smoke: Gluster Build System 
 >Reviewed-by: Xavier Hernandez 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 

BUG: 1360574
Change-Id: I310f8d492bb576224797d9090658ca1e6367861c
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15023
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Ravishankar N

afr: some coverity fixes

2016-07-28T13:54:49+00:00

Note: This is a backport of http://review.gluster.org/14895.
It contains:
i) fixes that prevent deadlocks (afr-common.c).
ii) fixes over-writing op-errno=ENOMEM with possible other values
(afr-inode-read.c).
iii) prevents doing further operations with a NULL dictionary if
allocation fails (afr-self-heal-data.c).
iv) prevents falsely marking a sink as healed if metadata heal fails
midway(afr-self-heal-metadata.c).
v) other minor fixes.

Considering the above are not trivial fixes, the patch is a good
candidate for merging in 3.8 branch.

Thanks to Krutika for a cleaner way to track inode refs in
afr_set_split_brain_choice().

Change-Id: I2d968d05b815ad764b7e3f8aa9ad95a792b3c1df
BUG: 1360556
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/15018
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Krutika Dhananjay 
Reviewed-by: Pranith Kumar Karampuri

tests: Fix spurious failure of tests/bugs/glusterd/bug-1111041.t

2016-07-21T11:05:43+00:00

On a faster machine the ps check was returning two pids,
including the glusterfsd process's pid, right after that,
process forked. Hence removing that ps, as for the scope
of this test, verifying the snapd pid from the status
command itself is enough.

> Reviewed-on: http://review.gluster.org/14963
> Smoke: Gluster Build System 
> Reviewed-by: Rajesh Joseph 
> Reviewed-by: Atin Mukherjee 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

(cherry picked from commit be69510e670cb5ee893399ca1d7e7d2a60a9483c)

Change-Id: I8bd8fc4ea406d96e3a47f952cfe44560b615dbe6
BUG: 1358591
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/14969
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee