glusterfs.git/tests/bugs, branch v3.6.1

glusterd: Authenticate management handshake requests

2014-09-24T07:00:13+00:00

Backport of
  371bb42 glusterd: Authenticate management handshake requests
from master.

Management handshake requests, which are used to validate op-version
supported by the peers, are now only allowed if,
- the glusterd doesn't have any other peer, or
- the request was sent by another peer.

This prevents the op-version of a peer being changed because of a
connection attempt by an invalid peer.

BUG: 1144978
Change-Id: I5a909dad37e9873efe8b75dad41b7af71ce91c3d
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/8819
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

test : Fix for spurious failure

2014-09-23T16:03:54+00:00

Problem : Once the features.uss is enabled it does not wait for
the process to be created. And if we try to check for
the pid of the snapd then it will not be present which
causes a failure.

Solution : Adding a EXPECT_WITHIN which waits to get the pid
until certain time period.

Change-Id: I5fdda9beecf867b7544f2e4b830f698ddf6e3bec
BUG: 1145189
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8809
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

feature/snapshot : Interface to delete all snapshots belonging to a system as-well-as to a particular volume

2014-09-23T09:01:04+00:00

Problem :
With the current design we can only delete a single snapshot.
And the deletion of volume which contains snapshot is not allowed.
Because of that user might be forced to delete all the snapshots
manually before he is allowed to delete a volume.

Solution:
Following is the interface with which user can delete
all the snapshots of a system or belonging to a particular volume.

        Syntax : gluster snapshot delete all

        *To delete all the snapshots present in a system

        Syntax : gluster snapshot delete volume 

        *To deletes all the snapshot present in a volume specified.

========================================================================
Sample Output:

Case 1 : Deleting a single snapshot.
[root@snapshot-24 glusterfs]# gluster snapshot delete snap1
Deleting snap will erase all the information about the snap. Do you still want to continue? (y/n) y
snapshot delete: snap1: snap removed successfully

-----------------------------------------------------------------
Case 2 : Deleting all the snapshots in a Volume.
[root@snapshot-24 glusterfs]# gluster snapshot delete volume vol1
Volume (vol1) contains 9 snapshot(s).
Do you still want to continue and delete them?  (y/n) y
snapshot delete: snap2: snap removed successfully
snapshot delete: snap3: snap removed successfully
snapshot delete: snap4: snap removed successfully
snapshot delete: snap5: snap removed successfully
.
.
.

-----------------------------------------------------------------
Case 3 : Deleting all the snapshots in a system.
[root@snapshot-24 glusterfs]# gluster snapshot delete all
System contains 4 snapshot(s).
Do you still want to continue and delete them?  (y/n) y
snapshot delete: snap7: snap removed successfully
snapshot delete: snap8: snap removed successfully
snapshot delete: snap9: snap removed successfully
snapshot delete: snap10: snap removed successfully
========================================================================

Change-Id: Ifec8e128ab2011cbbba208376b9c92cfbe7d8d71
BUG: 1145083
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8162
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Kaushal M 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8798
Reviewed-by: Vijaikumar Mallikarjuna

cli/snapshot : gluster volume info should not show the options which are not set explicitly.

2014-09-23T09:00:22+00:00

Problem : Even though snap-max-hard-limit, snap-max-soft-limit and
auto-delete values were not set explicitly, It was getting showed
in the output of gluster volume info.

Solution : Check if the value is already present in dictionary
(That means, it is set), If value is not present then consider
the default value,

NOTE : This patch doesn't solve the problem where the values
which is set globally are being displayed in gluster volume info

Change-Id: I61445b3d2a12eb68c38a19bea53b9051ad028050
BUG: 1145020
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8191
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Avra Sengupta 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Kaushal M 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8793
Reviewed-by: Vijaikumar Mallikarjuna

cluster/afr: Set all the xattrs needed by index xlator

2014-09-21T17:29:09+00:00

	Backport of: http://review.gluster.org/8652

Index xlator removes the index file from indices
xattrop directory in case the value for keys sent
are zero.

If all the required keys are not set by afr
then index file might be removed in an invalid
way.

With this change all the keys required by index
xlator are set by afr such that invalid removal of
files does not occur.

Change-Id: I1b77904920c8566057415c52242179aec6a015e2
BUG: 1144744
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/8788
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: perform list-xattr during lookup

2014-09-19T18:02:24+00:00

Detect and heal mismatching user extended attributes during lookup.
Backport of: http://review.gluster.org/8558

Change-Id: Id03c9746f083ffd3014711d0b3a2e5a71a45eed4
BUG: 1144274
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/8773
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur

cluster/afr : Mark pending changelog xattrs for new creations

2014-09-18T18:05:47+00:00

        Backport of: http://review.gluster.org/8555

Based on type of file, set appropriate pending changelogs
for new entries.

Change-Id: Icf9af866fe9a9e511210e8ad097e968e2307d8ee
BUG: 1141787
Reviewed-on: http://review.gluster.org/8555
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/8748
Reviewed-by: Vijay Bellur

cluster/afr: Handle EAGAIN properly in inodelk

2014-09-16T06:02:27+00:00

Problem:
When one of the brick is taken down and brough back up in a replica pair, locks
on that brick will be allowed. Afr returns inodelk success even when one of the
bricks already has the lock taken.

Fix:
If any brick returns EAGAIN return failure to parent xlator.

BUG: 1142020
Change-Id: Iee3f5990be75e10f8accec9bc3856e3f76d1593c
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8744
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

storage/posix: Prefer gfid links for inode-handle

2014-09-12T09:55:51+00:00

        Backport of http://review.gluster.org/8575

Problem:
File path could change by other entry operations in-flight so if renames are in
progress at the time of other operations like open, it may lead to failures.
We observed that this issue can also happen while renames and readdirps/lookups
are in progress because dentry-table is going stale sometimes.

Fix:
Prefer gfid-handles over paths for files. For directory handles prefering
gfid-handles hits performance issues because it needs to resolve paths
traversing up the symlinks.
Tests which test if files are opened should check on gfid path after this change.
So changed couple of tests to reflect the same.

Note:
This patch doesn't fix the issue for directories. I think a complete fix is to
come up with an entry operation serialization xlator. Until then lets live with
this.

BUG: 1136821
Change-Id: If93e46d542a4e96a81a0639b5210330f7dbe8be0
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8594
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

mount/fuse: Handle fd resolution failures

2014-09-12T09:17:42+00:00

        Backport of http://review.gluster.org/8402

Problem:
Even when the fd resolution failed, the fop is continuing on the
new graph which may not have valid inode. This lead to NULL layout
subvols in dht which lead to crash in fsync after graph migration.

Fix:
- Remove resolution error handling in FUSE_FOP as it was only added
  to handle fd migration failures.
- check in fuse_resolve_done for fd resolution failures and fail the
  fop right away.
- loc resolution failures are already handled in the corresponding
  fops.
- Return errno from state->resolve.op_errno in resume functions.
- Send error to fuse on frame allocation failures.
- Removed unused variable state->resolved
- Removed unused macro FUSE_FOP_COOKIE

BUG: 1136827
Change-Id: I4010b7fccd7d8caf0ce4e7629e81b605102d8fb4
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8592
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Vijay Bellur