glusterfs.git/tests/basic, branch v3.7.9

tests/quota : improving tests for quota

2016-03-15T09:48:10+00:00

tests/basic/quota.t includes all the basic test that
needs to be tested for quota. In most of the other
tests specific to bugs(tests/bugs/quota/*), tests
such as creating and starting volume, enabling quota,
setting limit, writing data, doing list have been done
which is essential to write a individual quota test
file, but, if the specific bug just needs to test
*few* particular cases, I have moved those tests
under tests/basic itself to speedup the regressions.

Basics of inode-quota and it's enforcing, renaming
with quota are basic tests and is hence moved under
tests/basic folder.

In other files, I have removed tests which are not
needed, such as 'pidof glusterd' or checking for
'gluster volume info' or if there are any test which
is already being tested under tests/basic and is being
written again.

        Backport of http://review.gluster.org/#/c/13216/

> Change-Id: Iefd6d9529246d59829cc5bf02687a1861d8462a8
> BUG: 1294826
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/13216
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Vijaikumar Mallikarjuna 
> Reviewed-by: Jeff Darcy 

Change-Id: Iefd6d9529246d59829cc5bf02687a1861d8462a8
BUG: 1314680
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/13606
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Vijaikumar Mallikarjuna

Tier: making detach start fail when brick on hot tier is down

2016-03-08T15:50:59+00:00

        backport of : http://review.gluster.org/#/c/13474/6

Currently detach tier start happens even when a hot brick is down
this might lead to data loss.

This patch prevents the detach tier start from being executed
successfully if a brick in hot tier is down

>Change-Id: I3b6047a44bd01b8a6887d41f799f64de6bf075ef
>BUG: 1309999
>Signed-off-by: hari 

Change-Id: Ica0ae72f8e30156090be43e428545d684bdea36b
BUG: 1314617
Signed-off-by: hari 
Reviewed-on: http://review.gluster.org/13602
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

afr: do not set arbiter as a readable subvol in inode context

2016-03-07T08:32:00+00:00

Problem:
If afr_lookup_done() or afr_read_subvol_select_by_policy() chooses the
arbiter brick to serve the stat() data, file size will be reported as
zero from the mount, despite other data bricks being available. This can
break programs like tar which use the stat info to decide how much to read.

Fix:
In the inode-context, mark arbiter as a non-readable subvol for both
data and metadata.

It it to be noted that by making this fix, we are *not* going to serve
metadata FOPS anymore from the arbiter brick despite the brick storing
the metadata. It makes sense to do this because the ever increasing
over-loaded FOPs (getxattr returning stat data etc.) and compound FOPS
in gluster will otherwise make it difficult to add checks in code to
handle corner cases.

 >Change-Id: Ic60b25d77fd05e0897481b7fcb3716d4f2101001
 >BUG: 1310171
 >Signed-off-by: Ravishankar N 
 >Reported-by: Mat Clayton 
 >Reviewed-on: http://review.gluster.org/13539
 >Reviewed-by: Anuradha Talur 
 >Reviewed-by: Krutika Dhananjay 
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 
 >Reviewed-by: Jeff Darcy 

BUG: 1313921
Change-Id: I07fc08d633ca2af48f7354454bc2ab75cedb850a
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/13609
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

Revert "afr: do not set arbiter as a readable subvol in inode context"

2016-03-05T10:47:10+00:00

This reverts commit ad0b1253b9d74797620c493184818685c024f17c.

Change-Id: Id43ba8e75d58325f897e15e3f64f9389236adb40
Reviewed-on: http://review.gluster.org/13608
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

afr: do not set arbiter as a readable subvol in inode context

2016-03-05T01:28:58+00:00

Backport-of: http://review.gluster.org/#/c/13539/

Problem:
If afr_lookup_done() or afr_read_subvol_select_by_policy() chooses the
arbiter brick to serve the stat() data, file size will be reported as
zero from the mount, despite other data bricks being available. This can
break programs like tar which use the stat info to decide how much to read.

Fix:
In the inode-context, mark arbiter as a non-readable subvol for both
data and metadata.

It it to be noted that by making this fix, we are *not* going to serve
metadata FOPS anymore from the arbiter brick despite the brick storing
the metadata. It makes sense to do this because the ever increasing
over-loaded FOPs (getxattr returning stat data etc.) and compound FOPS
in gluster will otherwise make it difficult to add checks in code to
handle corner cases.

Change-Id: Ic60b25d77fd05e0897481b7fcb3716d4f2101001
BUG: 1313921
Signed-off-by: Ravishankar N 
Reported-by: Mat Clayton 
Reviewed-on: http://review.gluster.org/13582
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

tests: Fix spurious failure of ec-read-policy.t

2016-03-02T16:21:51+00:00

>Change-Id: I5297e24dd10cbfbcd671fe630ae3e960b9daa8f8
>Reviewed-on: http://review.gluster.org/13575
>BUG: 1313775
>Signed-off-by: Xavier Hernandez 

Change-Id: Ib0ea04a9040400ea67c141592e2ba34e40272408
BUG: 1313776
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/13576
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

cluster/ec: Fix invalid config check for directories

2016-03-02T11:02:49+00:00

The trusted.ec.config xattr is not defined for directories. However
sometimes it could be requested because the inode type of a directory
can temporarily be IA_INVAL.

Requesting such xattr using the xattrop fop when it doesn't exist,
returns a config value full of 0's, which is invalid and caused some
fops to fail.

This patch filters out this case by ignoring config xattr == 0.

> Change-Id: Ied51c35b313ea8c3eeae27812f9bae61d3808e92
> Reviewed-on: http://review.gluster.org/13446
> BUG: 1293223
> Signed-off-by: Xavier Hernandez 

Change-Id: I42d06119d8f51c34ddb910380af7acd670f6244e
BUG: 1293224
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/13447
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Ashish Pandey 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

cli: output of rebalance to show run time in proper format

2016-03-01T04:54:20+00:00

Backport of http://review.gluster.org/#/c/10544/

Modified tests to parse the new rebalance time format.

> Change-Id: I775f13c8046dd2aeb9d4b86a737dcebb396778b4
> BUG: 1223625
> Signed-off-by: Sakshi Bansal 
> Reviewed-on: http://review.gluster.org/10544
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: N Balachandran 
> Reviewed-by: Raghavendra G 

BUG: 1311822
Change-Id: I3c8106f7a1309f154861ce1b3efa202fa6c47c57
Signed-off-by: Sakshi Bansal 
Reviewed-on: http://review.gluster.org/13514
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Tested-by: Raghavendra Talur 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

locks: Handle negative values for flock->l_len

2016-02-28T20:14:14+00:00

As per 'man 3 fcntl',
"If l_len is positive, the area affected shall start at
l_start and end at l_start+l_len−1. If l_len is negative,
the area affected shall start at l_start+l_len and end at
l_start−1. Locks may start and extend beyond the current
end of a file, but shall not extend before the beginning
of the file."

Currently we return EINVAL if l_len is found to be negative.
Fixed the same as mentioned in the man page.

This is backport of the below patch
    - http://review.gluster.org/11613

Change-Id: I493ce202c543185fc4ae7266d1aaf9d7e2a66991
BUG: 1312200
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11613
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Reviewed-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/13526
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

glusterd/rebalance: initialize defrag variable after glusterd restart

2016-02-25T03:49:27+00:00

During reblance restart after glusterd restarted, we are not
connecting to rebalance process from glusterd, because the
defrag variable in volinfo will be null.

Initializing the variable will connect the rpc

Back port of>
>Change-Id: Id820cad6a3634a9fc976427fbe1c45844d3d4b9b
>BUG: 1303028
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/13319
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Dan Lambright 
>CentOS-regression: Gluster Build System 

(cherry picked from commit a67331f3f79e827ffa4f7a547f6898e12407bbf9)

Change-Id: Ieec82a798da937002e09fb9325c93678a5eefca8
BUG: 1311041
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13494
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee