glusterfs.git/rpc, branch v3.6.9

rpc-transport: socket_poller fixes for proper working of mgmt encryption

2015-07-17T07:18:41+00:00

  Backport of 8c39f14 from master

socket_poller, the polling function used by ssl own_thread, had two
issues which lead to GlusterD crashes when using management encryption

Issue 1
-------
socket_poller calls functions which require THIS to be set. But, THIS
was being set conditionally. Because of this, functions could sometimes
be called without THIS being set. For example, rpc_transport_notify
could be called for an accepted client socket without THIS being set, as
THIS was only set it the transport wasn't yet connected. This would
cause the process to crash when THIS was accessed by the called
functions.

To fix this, THIS is being set at the start of socket_poller
unconditionally.

Issue 2
-------
DISCONNECT notify was being sent on the listener transport instead of
the client transport. The DISCONNECT event was converted to a
LISTENER_DEAD event in rpcsvc_handle_disconnect, as it could not find
the listener socket of the listener socket. GlusterD was notified of a
LISTENER_DEAD event instead of a DISCONNECT and failed to remove the
client transport from its xprt_list. The transport would subsequently
be freed, leaving the xprt_list with a corrupted/invalid entry. Later,
when GlusterD would iterate over the xprt_list to send notifications, it
would crash when the invalid entry was accessed.

To fix this, DISCONNECT notification in socket_poller is sent on the
client socket, as it is done in the epoll handler.

Change-Id: I0370b7c6d7eb13de10ebf08d91a4a39dc7d64c7a
BUG: 1243700
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/11690
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Raghavendra Bhat

socket: fix multithreading-related build problems on RHEL5

2015-05-27T11:39:34+00:00

Change-Id: I3e145137c3ef738c4459c8d3098d6094ccfb008a
BUG: 1225072
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/10921
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

socket: use OpenSSL multi-threading interfaces

2015-05-19T13:04:44+00:00

OpenSSL isn't thread-safe unless you register these locking and thread
ID functions.  Most often the crashes would occur around
X509_verify_cert, even though it's insane that the certificate parsing
functions wouldn't be thread-safe.  The bug for this was filed over
two years ago, but it didn't seem like a high priority because the bug
didn't bite anyone until it caused a spurious regression-test failure.
Ironically, that was on a test for a *different* spurious
regression-test failure, which I guess is just deserts for leaving
this on the to-do list so long.

This is a backport of 8830e90fa1b131057e4ee1742cb83d78102714c0
>   Change-Id: I2a6c0e9b361abf54efa10ffbbbe071404f82b0d9
>   BUG: 906763
>   Signed-off-by: Jeff Darcy 
>   Reviewed-on: http://review.gluster.org/10075
>   Tested-by: Gluster Build System 
>   Reviewed-by: Kaleb KEITHLEY 
>   Reviewed-by: Vijay Bellur 

Change-Id: I66de5f2830936ccc8d447fed6d1a83ebe7e93460
BUG: 1218167
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/10591
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

socket: fix segfaults when TLS management connections fail

2015-04-21T12:27:14+00:00

Backport of 0b9a6a6 from master.

BUG: 1212684
Change-Id: Iec5410b937af150621b757924836cec638b5eb55
Signed-off-by: Jeff Darcy 
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/10280
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

rdma:smoke failure in NetBSD if RDMA_OPTION_ID_REUSEADDR is not defined

2015-04-16T06:39:23+00:00

By the change http://review.gluster.org/#/c/10014/, we only set
reuseaddr option if the macro RDMA_OPTION_ID_REUSEADDR is defined in
rdmacma.h . The variable optval is only used in the section where we
use conditional compiling based on the macro. So if the macro is not
defined, then compiler will throw a warning for optval.

Change-Id: I162143c928e84b40c6fd6108d3aa5b045dd9de95
BUG: 1201484
Reviewed-on: http://review.gluster.org/10208
Reviewed-by: Raghavendra Talur 
Reviewed-by: Sachin Pandit 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

rdma: RDMA_OPTION_ID_REUSEADDR undeclared on Ubuntu Precise (LTS)

2015-03-27T11:37:15+00:00

Very old release of Ubuntu LTSwq

Change-Id: Ib6fb4493f1f34ba853bd74c8037da7663639f40e
BUG: 1201484
Signed-off-by: kkeithle 
Reviewed-on: http://review.gluster.org/10014
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Raghavendra Bhat

rdma:changing list iteration to safe mode

2015-03-27T11:35:31+00:00

        Bck port of : http://review.gluster.org/9872

Change-Id: I2299378f02a5577a8bf2874664ba79e92c3811b5
BUG: 1202212
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9872
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/9891
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Bhat

rdma:setting wrong remote memory.

2015-03-27T11:34:39+00:00

        Back port of : http://review.gluster.org/9794

when we send more than one work request in a single call,
the remote addr is always setting as the first address of
the vector.

Change-Id: I55aea7bd6542abe22916719a139f7c8f73334d26
BUG: 1202212
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9794
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/9890
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Bhat

rdma: pre-register iobuf_pool with rdma devices.

2015-03-27T11:34:08+00:00

        Back port pf : http://review.gluster.org/9506

registring buffers with rdma device is a time consuming
operation. So performing registration in code path will
decrease the performance.
Using a pre registered memory will give a bettor performance,
ie, register iobuf_pool during rdma initialization. For
dynamically created arena, we can register with all the
device.

Change-Id: Ic79183e2efd014c43faf5911fdb6d5cfbcee64ca
BUG: 1202212
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9506
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/9889
Reviewed-by: Raghavendra Bhat

rdma:read multiple wr from cq and ack them in one call

2015-03-27T11:33:47+00:00

        Back port of : http://review.gluster.org/9329

we are reading one work completion request at a time
from cq, though we can read multiple work completion
requests from cq. Also we can acknowledge them in
one call itself. Both will give a better performance
because of less mutual exclusion locks are being performed.

Change-Id: Ib5664cab25c87db7f575d482eee4dcd2b5005c04
BUG: 1202212
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9329
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/9888
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Bhat