glusterfs.git/rpc, branch v3.4.0beta3

socket: convert socket functions to file scope (static)

2013-06-08T21:53:07+00:00

The function names used in socket.c conflict with Samba's
socket functions (samba.git/source4/lib/socket/socket.h). Convert
our functions to file scope as they are anyways not called across
files.

Change-Id: If98ae557d3e2868f257c021b283ede6a5e92de02
BUG: 953694
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5168
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

rpc-transport/rdma: reap async events in a dedicated thread.

2013-05-27T18:01:15+00:00

* Also sets srq_limit of srq to 10, so that we'll receive an event
  when we are about to empty the receive buffer list.

BUG: 765051
Change-Id: I5436166ea21fc963ee15088fc2df743ec4b96ba7
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4378
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/5097

rpc-transport/rdma: use rdma-cm for connection establishment.

2013-05-27T18:00:59+00:00

Till now gluster used tcp/ip based communication channel with
gluster specific protocol to exchange infiniband addresses.

Change-Id: I9de4db398a0e2af51d3d2d68c2fe42168102b190
BUG: 765051
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/149
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/5096

rpc: change dict key for fqdn

2013-05-23T16:54:31+00:00

changed the key from "client.fqdn", which could be wrongly
construed as belonging to protocol/client, to "fqdn".

This is a backport of 8403f9a2d976c33e01fbd9e4a4b04e8f1e936806.

Change-Id: Ib5f4a875a00b99cd903a29da19bafeb70baaab4e
BUG: 950056
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4536
Reviewed-by: Niels de Vos 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4965
Reviewed-by: Jeff Darcy

rpcsvc: fix dangerous setting of pointer on free'd structure.

2013-05-21T06:08:12+00:00

Change-Id: I6b666115a8ce155563078d7fc476d41486bab54f
BUG: 884452
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4995
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System

glusterd: Refresh glusterd-syncop fixes from master

2013-05-17T03:44:44+00:00

Following commits were cherry-picked from master,
044f8ce syncop: Remove task from synclock's waitq before 'wake'
cb6aeed glusterd: Give up big lock before performing any RPC
46572fe Revert "glusterd: Fix spurious wakeups in glusterd syncops"
5021e04 synctask: implement barriers around yield, not the other way
4843937 glusterd: Syncop callbks should take big lock too

Change-Id: I5ae71ab98f9a336dc9bbf0e7b2ec50a6ed42b0f5
BUG: 948686
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4938
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5021
Reviewed-by: Vijay Bellur

Fix spurious brick disconnects

2013-05-01T03:12:52+00:00

Spurious disconnect were caused by a race condition inside
rpc_transport_ref()/rpc_transport_unref() that allowed the refcount
to drop to zero while the transport was still in use. The race
condition is made possible because of an uninitiaized mutex
produced when socket_server_event_handler() copies the transport

This is a backport of I34fe097a0ac21b0dbf58f5eed84880e3fd9814f2

BUG: 764655
Change-Id: Ib6a7c736f28ccc67d05be45629cddc18a642c11f
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/4908
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati

glusterd: Fixed spurious wakeups in glusterd syncops

2013-04-17T12:46:43+00:00

glusterd syncops perform a barrier_wake whenever rpc_clnt_submit returned -1.
This is based on the wrong assumption that the cbkfn wasn't called.
This would result in one more wakeup than there ought to be.

BUG: 948686
Change-Id: I839fd218a81255fe50c2047d67461d45360e894d
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4834
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

rpc-transport: fix glusterd crash when rdma.so missing

2013-04-12T18:31:38+00:00

Add checks before trying to delete vol_opt from list and free

Change-Id: I2858f58518394beb8f74fa477be81d7bdd38304f
BUG: 924215
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4704
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/4819
Reviewed-by: Jeff Darcy

rpc: before freeing the volume options object, delete it from the list

2013-04-12T17:07:23+00:00

* Suppose there is an xlator option which is considered by the xlator
  only if the source was built with debug mode enabled (the only example
  in the current code base is run-with-valgrind option for glusterd), then
  giving that option would make the process crash if the source was not
  built with debug mode enabled.

  Reason:
  In rpc, after getting the options symbol dynamically, it was stored in the
  newly allocated volume options structure and the structure's list head was
  added to the xlator's volume_options list. But while freeing the structure
  the list was not deleted. Thus when the list was traversed, already freed
  structure was accessed leading to segfault.

Change-Id: I3e9e51dd2099e34b206199eae7ba44d9d88a86ad
BUG: 922877
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4687
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-on: http://review.gluster.org/4818
Reviewed-by: Jeff Darcy