glusterfs.git/rpc, branch v3.3.2qa3

localtime and ctime are not MT-SAFE

2013-02-08T20:04:42+00:00

There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
   that another thread calling localtime (or ctime) will over-write
   the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
   not a problem on 64-bit or little-endian 32-bit. But even though
   we probably have zero users on big-ending 32-bit platforms, it's
   still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
   writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
   tracing, or dumping. I submit that if an error somehow occurs in
   the call to localtime or ctime, the log/trace/dump still should
   still occur.
5) Appliances should all have their clocks set to UTC, and all log
   entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()

Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
   e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
   not a function. You don't use i +(32), why use sizeof().
   (And yes, you do use parens with sizeof().)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
   Per-thread stack is limited. Time strings are never longer than ~20
   characters, so why waste 220+ bytes on the stack?

Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
   variations. It's not clear to me whether this ever matters, not to
   mention 3rd party log filtering tools may already rely on a
   particular format. Still it would be nice to have a single manifest
   constant and have every call to localtime/strftime consistently use
   the same format.

BUG: 832173

Change-Id: Iee9719db4576eacc6c75694d9107954d0912cba8
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3613
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

dual license

2013-02-07T21:39:01+00:00

rebase

BUG: 820551
Change-Id: Iec1073ee3ed2d9cab25c0882544a18e8ba23c9aa
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3857
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpc-transport/rdma: use 24008 as default listen port.

2013-02-06T01:58:34+00:00

BUG: 849122
Change-Id: Ie76b105096f038b98434952a4eb352984595cecd
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4384
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Fixed some general typing errors.

2012-09-27T18:22:34+00:00

Eg: changed recieved to received

Change-Id: I360fcb99c97c8a0222e373fee20ea2fccfb938db
BUG: 860543
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3999
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

rpc: Reduce frame-timeout for glusterd connections

2012-08-17T08:13:01+00:00

Reduce frame-timeout for glusterd connections from 30mins to 10 mins. 30mins is
too long when compared to cli timeout of 2mins. Changing to 10mins reduces the
disparity between cli and glusterd.

Also, fix glusterfs_submit_reply() so that a reply is sent even if serialize
failed.

BUG: 843003
Change-Id: Ie8d5ec16fbbb54318a5935a47065e66fd3338b87
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3812
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

acl: enable handling of FMODE_EXEC flag

2012-08-09T16:38:37+00:00

on linux systems, with open(), we can get below flag as per
'linux/fs.h'.

/* File is opened for execution with sys_execve / sys_uselib */
'#define FMODE_EXEC              ((fmode_t)0x20)'

Instead of adding '#include , its better to copy this
absolute number into other variable because then we have to deal
with declaring fmode_t etc etc..

With the fix, we can handle the file with '0711' permissions in
the same way as backend linux filesystems.

Change-Id: Ib1097fc0d2502af89c92d561eb4123cba15713f5
Signed-off-by: Amar Tumballi 
BUG: 843960
Reviewed-on: http://review.gluster.com/3746
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

rpc: Fixed ping timer algo.

2012-08-02T04:49:43+00:00

The purpose of the ping timer is to assert the absence of any evidence
the server is possibly alive.

The current implementation updates the 'last_sent' timer in the following
points in time,
- rpc_clnt_submit: when rpc messages are being queued at the transport
  layer. (wrong!, since we have no way to determine if server actually
  received the message)
- rpc_clnt_notify: when client receives pollout event on sending a message
  on the 'wire'. (correct, since it indicates ACK from server)

The fix removes the 'incorrect' update of 'last_sent'.

Change-Id: I56af7b15c3672673696977a7c50ee66eafa4ec55
BUG: 836448
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3624
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

cluster/dht: Remove dht dependency on glusterfsd-mgmt

2012-08-02T03:57:30+00:00

glusterfs_ctx->notify can be used by any xlator to talk to
glusterfsd-mgmt.
Note- This is for any rpc communication initiated by the xlator,
      and not from glusterd.

Change-Id: Ic0e4af106fe1e98d797ca621facda8839b87598a
BUG: 835757
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.com/3610
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur

rpc-transport/rdma: decode and handle RDMA_ERROR msgs.

2012-08-02T03:52:46+00:00

RDMA_ERROR msgs are resulted as part of failure to decode requests
or failure to send reply (for eg., reply being bigger than a msg
that can be sent inline, but client has not provided any write-chunks
to rdma-write into).

Change-Id: I0184cfb5ff8f49ed892767345e32e6c7b01c49e7
BUG: 822337
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.com/3475
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

Use inet as default listene

2012-07-13T21:09:14+00:00

This is backport of Change-Id: I172570aa58ea08c4c74cfd28f121d3d4e02a55e0

BUG: 764655
Change-Id: I60232b73c303d296e34871ed317925c9af0d322e
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3575
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati