glusterfs.git/rpc, branch v3.3.0qa32

core: adding extra data for fops

2012-03-22T23:40:27+00:00

with this change, the xlator APIs will have a dictionary as extra
argument, which is passed between all the layers. This can be
utilized for overloading in some of the operations.

Change-Id: I58a8186b3ef647650280e63f3e5e9b9de7827b40
Signed-off-by: Amar Tumballi 
BUG: 782265
Reviewed-on: http://review.gluster.com/2960
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpc-clnt: separate out connection_cleanup() from destroy()

2012-03-19T16:14:40+00:00

noticed that there are possibilities where one would like to do a
connection_cleanup() before destroying a RPC connection itself, also
current code is such that, rpc_clnt_connection_cleanup() does
rpc_clnt_ref() and unref(), creating a race window/double unref
possibilities in the code.

by separating out the functions, this race window/double fault can be
prevented.

Change-Id: I7ebd3392efa891232857b6db9108b0b19e40fc12
Signed-off-by: Amar Tumballi 
BUG: 802403
Reviewed-on: http://review.gluster.com/2979
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

rpc: cancel reconnect timer in rpc_clnt_disable

2012-03-18T08:40:33+00:00

When the graph is considered no longer needed, rpc_clnt_disable
is called, which disconnects the connection to server but the
reconnect timer is not cancelled in that function, so it is
reconnecting to the server before the grace-time-period.
The locks of the disabled graph are still there on the server
which are leading to hangs.

Change-Id: I8d37f1296370e37117005137a0a430e636da4d2e
BUG: 803209
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2967
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpc-lib: memleak fix in rpcsvc_volume_allowed

2012-03-18T06:30:00+00:00

Change-Id: Iaa6baa4a3e036b2b5c808ea5e79017fffeb80a24
BUG: 801754
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/2956
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Anand Avati

protocol/server: add and remove the transports from the list, inside the lock

2012-03-18T06:27:26+00:00

Till now for graph changes, glusterfs client used to remember the old graph
also. Hence the transport object on the server corresponding the old graph
never received disconnect. But now since the graph cleanup is happening,
transport on the server side gets disconnect for the cleaned up graph.

Server maintains, all the transports in a list. But addition of the new
transport to the list, or removal of the transport from the list is not
happening within the lock. Thus if a thread is accessing a transport
(in cases of statedump, where each transprt's information is dumped),
and the server gets a disconnect on that transport, then it leads to
segfault of the process.

To avoid it do the list (of transports) manipulation inside the lock.

Change-Id: I50e8389d5ec8f1c52b8d401ef8c8ddd262e82548
BUG: 803815
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/2958
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpc: log in DEBUG when nfs clients try to see if ACL requests are accepted by nfs server

2012-03-14T13:01:22+00:00

Change-Id: I897b48a02ce2150d268a1a8b45163e9e1aee6cff
BUG: 801338
Signed-off-by: krishna 
Reviewed-on: http://review.gluster.com/2901
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

rpc-lib/rpcsvc: nfs auth corrections

2012-03-14T10:10:57+00:00

in comparing ip addresses during authentication,
we need to take only the ip address of the client
instead of the transport endpoint (ip:port).

Change-Id: If48eca37edea1d69deb150720fbaea0ea2443a00
BUG: 771845
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/2929
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

cli, glusterd, nfs: "volume status|profile|top" for nfs servers

2012-03-14T09:27:42+00:00

Enables usage of volume monitoring operations "volume status", "volume top" and
"volume profile" for nfs servers. These operations can be performed on
nfs-servers  by passing "nfs" as an option in cli. The output is similar to the
normal brick outputs for these commands.

The new syntaxes for the changed commands are as below,
 #gluster volume profile  {start|info|stop} [nfs]
 #gluster volume top  {[open|read|write|opendir|readdir [nfs]]
               |[read-perf|write-perf [nfs|{bs  count }]]}
               [brick ] [list-cnt ]
 #gluster volume status [all |  [nfs|]]
          [detail|clients|mem|inode|fd|callpool]

Change-Id: Ia6eb50c60aecacf9b413d3ea993f4cdd90ec0e07
BUG: 795267
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/2820
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi

rpc-clnt: print xid of the saved frames getting unwind

2012-03-05T17:48:29+00:00

so that one can match the corresponding submit failed errors in
brick logs

Change-Id: I4422805a20c251aeffb51d63572c251176b2620c
Signed-off-by: Amar Tumballi 
BUG: 799337
Reviewed-on: http://review.gluster.com/2864
Tested-by: Gluster Build System 
Reviewed-by: M S Vishwanath Bhat 
Reviewed-by: Vijay Bellur

transport/socket: configuring tcp window-size

2012-02-29T10:10:44+00:00

Till now, send and recieve buffer window sizes for sockets
were set to a default glusterfs-specific value.
Linux's default window sizes have been found to be better
w.r.t performance, and hence, no more setting it to any
default value.

However, if one wishes, there's the new configuration option:
   network.tcp-window-size 
which takes a size value (int or human readable) and will set
the window size of sockets for both clients and servers.
Nfs clients will also be updated with the same.

Change-Id: I841479bbaea791b01086c42f58401ed297ff16ea
BUG: 795635
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/2821
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Jeff Darcy 
Reviewed-by: Vijay Bellur