glusterfs.git/rpc/rpc-transport, branch v3.8dev

socket: use OpenSSL multi-threading interfaces

2015-04-09T09:55:37+00:00

OpenSSL isn't thread-safe unless you register these locking and thread
ID functions.  Most often the crashes would occur around
X509_verify_cert, even though it's insane that the certificate parsing
functions wouldn't be thread-safe.  The bug for this was filed over
two years ago, but it didn't seem like a high priority because the bug
didn't bite anyone until it caused a spurious regression-test failure.
Ironically, that was on a test for a *different* spurious
regression-test failure, which I guess is just deserts[1] for leaving
this on the to-do list so long.

[1] Yes, it really is "deserts" in that phrase - not as in very dry
places, but from late Latin "deservire" meaning to serve well or
zealously.  Aren't commit messages educational?

Change-Id: I2a6c0e9b361abf54efa10ffbbbe071404f82b0d9
BUG: 906763
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/10075
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Vijay Bellur

socket: use TLS 1.2 instead of 1.0

2015-03-27T18:29:33+00:00

Change-Id: I96e9b37e4855f5e12b2dbecf1f0b0887b21ad5ad
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/9949
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

socket: use TCP_USER_TIMEOUT to detect client failures quicker

2015-03-17T12:10:17+00:00

Use the network.ping-timeout to set the TCP_USER_TIMEOUT socket option
(see 'man 7 tcp'). The option sets the transport.tcp-user-timeout option
that is handled in the rpc/socket layer on the protocol/server side.
This socket option makes detecting unclean disconnected clients more
reliable.

When the socket gets closed, any locks that the client held are been
released. This makes it possible to reduce the fail-over time for
applications that run on systems that became unreachable due to
a network partition or general system error client-side (kernel panic,
hang, ...).

It is not trivial to create a test-case for this at the moment. We need
a client that unclean disconnects and an other client that tries to take
over the lock from the disconnected client.

URL: http://supercolony.gluster.org/pipermail/gluster-devel/2014-May/040755.html
Change-Id: I5e5f540a49abfb5f398291f1818583a63a5f4bb4
BUG: 1129787
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8065
Tested-by: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: Santosh Pradhan 
Reviewed-by: Kaleb KEITHLEY

rdma:changing list iteration to safe mode

2015-03-15T16:07:04+00:00

Change-Id: I2299378f02a5577a8bf2874664ba79e92c3811b5
BUG: 1201621
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9872
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Vijay Bellur

rdma: Free resources related to iobuf in fini

2015-03-11T02:28:29+00:00

If rdma transport is destroyed because of any reason,
then rdma.so will be unloaded. But we are not setting
iobuf registeration function to null. After this, if
an iobuf request is came, then we will try to call a
function which is not loaded.

Change-Id: I3293f9974e16d8e865131785ee697ea02be8cdfc
BUG: 1187456
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9697
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Vijay Bellur

rdma:enhance logging when a connection error occur

2015-03-11T02:22:34+00:00

Change-Id: I6146307949a3d852d3af5f8b273004ad6b27451b
BUG: 1196584
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9756
Tested-by: Gluster Build System 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Vijay Bellur

rdma: return proper data type.

2015-03-10T04:36:28+00:00

Change-Id: I9bb0898af96cfcfaba0f0c976a7808bc6ea08e6a
Signed-off-by: Humble Devassy Chirammal 
Reviewed-on: http://review.gluster.org/9838
Reviewed-by: mohammed rafi  kc 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

rdma: 'list','wr' and 'new' memory has to be verified.

2015-03-09T10:23:55+00:00

Change-Id: I29a8825107b8f4cefe4f4c59296e98fe675ee943
BUG: 1199053
Signed-off-by: Humble Devassy Chirammal 
Reviewed-on: http://review.gluster.org/9811
Reviewed-by: mohammed rafi  kc 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

rdma:setting wrong remote memory.

2015-03-05T06:08:05+00:00

when we send more than one work request in a single call,
the remote addr is always setting as the first address of
the vector. 

Change-Id: I55aea7bd6542abe22916719a139f7c8f73334d26
BUG: 1197548
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9794
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

rdma: segfault trying to call ibv_dealloc_pd on a null pointer

2015-03-03T12:46:34+00:00

if ibv_alloc_pd failed

If creating an ib protection domain fails, during the cleanup
a segfault will occur because trav->pd is null.

Bug: 1197260
Change-Id: I21b867c204c4049496b1bf11ec47e4139610266a
Signed-off-by: Mark Lipscombe 
Reviewed-on: http://review.gluster.org/9774
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur