glusterfs.git/rpc/rpc-transport/socket/src/socket.c, branch v3.4.7beta4

socket: disallow CBC cipher modes

2014-10-29T17:31:40+00:00

This is related to CVE-2014-3566 a.k.a. POODLE.

	http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2014-3566

POODLE is specific to CBC cipher modes in SSLv3.  Because there is no
way to prevent SSLv3 fallback on a system with an unpatched version of
OpenSSL, users of such systems can only be protected by disallowing CBC
modes.  The default cipher-mode specification in our code has been
changed accordingly.

cherry picked from http://review.gluster.org/#/c/8962/
BZ 1155328

Change-Id: Id38a7eb3ab55058a0ee5dda9cb4c62b49b1ab9cb
BUG: 1155630
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8967
Reviewed-by: Jeff Darcy

socket: Fixed parsing RPC records containing multi fragments

2014-09-25T10:56:56+00:00

In __socket_proto_state_machine(), when parsing RPC records containing
multi fragments, just change the state of parsing process, had not
processed the memory to coalesce the multi fragments.

Cherry picked from commit fb6702b7f8ba19333b7ba4af543d908e3f5e1923:
> Change-Id: I5583e578603bd7290814a5d26885b31759c73115
> BUG: 1139598
> Signed-off-by: Gu Feng 
> Reviewed-on: http://review.gluster.org/8662
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: I5583e578603bd7290814a5d26885b31759c73115
BUG: 1146470
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8849
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

socket: convert socket functions to file scope (static)

2013-06-08T21:53:07+00:00

The function names used in socket.c conflict with Samba's
socket functions (samba.git/source4/lib/socket/socket.h). Convert
our functions to file scope as they are anyways not called across
files.

Change-Id: If98ae557d3e2868f257c021b283ede6a5e92de02
BUG: 953694
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5168
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Fix spurious brick disconnects

2013-05-01T03:12:52+00:00

Spurious disconnect were caused by a race condition inside
rpc_transport_ref()/rpc_transport_unref() that allowed the refcount
to drop to zero while the transport was still in use. The race
condition is made possible because of an uninitiaized mutex
produced when socket_server_event_handler() copies the transport

This is a backport of I34fe097a0ac21b0dbf58f5eed84880e3fd9814f2

BUG: 764655
Change-Id: Ib6a7c736f28ccc67d05be45629cddc18a642c11f
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/4908
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati

socket: Make non-ssl sockets perform non-blocking connect()

2013-04-12T07:20:46+00:00

Change-Id: Icb60cf7ad3ea7ca0eeb12fd19b95a6b340857bb2
BUG: 920916
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4685
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System

socket: restructure disconnect/poll-thread interactions

2013-02-03T20:09:54+00:00

Change-Id: I792c28f52068e4ed666069b740739662685160bc
BUG: 906401
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4456
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

socket: null out priv->ssl_ssl on disconnect

2013-01-29T18:01:01+00:00

This prevents problems when a socket transport is reused for a non-SSL
connection (e.g. glusterd portmapper) after having been used for an SSL
connection (e.g. a brick).  In that case, ssl_ssl will still be non-null from
the first connection, even though the structure it points to has actually been
freed.

I'm not sure why/how we would reuse a socket transport in this way (the case of
SSL after non-SSL has been common for a long time) but recent glusterd changes
seem to have had that effect.

Change-Id: I46f1ff3c409c122478bf720a7f02d92abcc32bed
BUG: 902684
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4449
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

"gcc -pedantic": made 'inline' functions as 'static inline' functions

2013-01-23T19:12:15+00:00

for passing the build with -pedantic flag

Change-Id: I80fd9528321e4c6ea5bec32bf5cdc54cc4e4f65e
BUG: 875913
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/4186
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

nlm: use virtual ip of server to connect to client

2013-01-18T11:50:33+00:00

In cases where the servers use virtual ip's, this commit
makes sure we use them and not the physical ip.

This change also refactors code around nlm4_establish_callback
by sending granted msg only after a connection establishment,
and removing the separate thread creation.

Change-Id: I087362c547a25aa52ef7fc6653845a3863466ee6
BUG: 888283
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4326
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

socket: Don't log readv failures if read-fail-log is false

2013-01-15T10:25:11+00:00

Change-Id: I6903d62cbc7107eb8498bcd81d07667b36890a02
BUG: 764888
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4377
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur