glusterfs.git/rpc/rpc-lib, branch v3.4.0beta4

rpc: Cleanup rpc object in TRANSPORT_CLEANUP event

2013-06-19T04:53:08+00:00

        Backport of http://review.gluster.org/5107 (upstream)

This is to ensure that unref of rpc_clnt object doesn't race with the
unref of the corresponding rpc_transport object.

rpc_transport has ref_count 2, in normal scheme of things. One held by
the socket layer and the other held by rpc layer. This inequality in
ref_count between rpc_clnt and rpc_transport could lead to concurrent
destruction of the objects and possibly lead to a crash.  To avoid this,
we defer the clean up of rpc_clnt obj to TRANSPORT_CLEANUP event. ie,
once rpc_transport's ref_count goes to zero.

Introduced rpc_clnt_disabled, to allow higher layers to differentiate
between the 'final'[1] disconnect, triggered from upper layers, and disconnect
seen as a consequence of transport disconnect. This differentiation
helps in cleaning up resources, at higher layers, in a race-free manner.

[1] - 'final' here means that the rpc and the associated connection, is not
to be used anymore. eg - glusterd_brick_disconnect on volume-stop.

Change-Id: I2ecf891a36e3b02cd9eacca964e659525d1bbc6e
BUG: 962619
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/5213
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Add a cmd for getting uuid of local node

2013-06-19T03:28:22+00:00

        Backport of http://review.gluster.org/5175 (upstream)
Usage: gluster system:: uuid get

This is needed since we generate uuid of a node in a lazy manner. ie, we
generate a uuid for the node only on the first volume or peer operation,
when the node needs an external identity.  With this command, we can
force[1] the uuid generation, without a volume or peer operation performed.

[1]: Querying for uuid (or uuid get), forces uuid to come into
existence.

Change-Id: I62c8b6754117756aa4d773dd48af4ddeb1a1d878
BUG: 971661
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/5204
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System

rpc: change dict key for fqdn

2013-05-23T16:54:31+00:00

changed the key from "client.fqdn", which could be wrongly
construed as belonging to protocol/client, to "fqdn".

This is a backport of 8403f9a2d976c33e01fbd9e4a4b04e8f1e936806.

Change-Id: Ib5f4a875a00b99cd903a29da19bafeb70baaab4e
BUG: 950056
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4536
Reviewed-by: Niels de Vos 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4965
Reviewed-by: Jeff Darcy

rpcsvc: fix dangerous setting of pointer on free'd structure.

2013-05-21T06:08:12+00:00

Change-Id: I6b666115a8ce155563078d7fc476d41486bab54f
BUG: 884452
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4995
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System

glusterd: Refresh glusterd-syncop fixes from master

2013-05-17T03:44:44+00:00

Following commits were cherry-picked from master,
044f8ce syncop: Remove task from synclock's waitq before 'wake'
cb6aeed glusterd: Give up big lock before performing any RPC
46572fe Revert "glusterd: Fix spurious wakeups in glusterd syncops"
5021e04 synctask: implement barriers around yield, not the other way
4843937 glusterd: Syncop callbks should take big lock too

Change-Id: I5ae71ab98f9a336dc9bbf0e7b2ec50a6ed42b0f5
BUG: 948686
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4938
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5021
Reviewed-by: Vijay Bellur

glusterd: Fixed spurious wakeups in glusterd syncops

2013-04-17T12:46:43+00:00

glusterd syncops perform a barrier_wake whenever rpc_clnt_submit returned -1.
This is based on the wrong assumption that the cbkfn wasn't called.
This would result in one more wakeup than there ought to be.

BUG: 948686
Change-Id: I839fd218a81255fe50c2047d67461d45360e894d
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/4834
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

rpc-transport: fix glusterd crash when rdma.so missing

2013-04-12T18:31:38+00:00

Add checks before trying to delete vol_opt from list and free

Change-Id: I2858f58518394beb8f74fa477be81d7bdd38304f
BUG: 924215
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4704
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/4819
Reviewed-by: Jeff Darcy

rpc: before freeing the volume options object, delete it from the list

2013-04-12T17:07:23+00:00

* Suppose there is an xlator option which is considered by the xlator
  only if the source was built with debug mode enabled (the only example
  in the current code base is run-with-valgrind option for glusterd), then
  giving that option would make the process crash if the source was not
  built with debug mode enabled.

  Reason:
  In rpc, after getting the options symbol dynamically, it was stored in the
  newly allocated volume options structure and the structure's list head was
  added to the xlator's volume_options list. But while freeing the structure
  the list was not deleted. Thus when the list was traversed, already freed
  structure was accessed leading to segfault.

Change-Id: I3e9e51dd2099e34b206199eae7ba44d9d88a86ad
BUG: 922877
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4687
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-on: http://review.gluster.org/4818
Reviewed-by: Jeff Darcy

rpc: bring in root-squashing behavior in rpc

2013-03-05T07:44:04+00:00

* requests coming in as root are converted to nfsnobody

* with open-behind some acl checks wont happen and nfsnobody
  can read the file "whose owner is root and other users do not
  have permission to read the file". This is becasue open-behind
  does not send the open to the brick and sends success to the
  application, thus the acl related tests on the file wont happen
  which would have prevented the file from being opened.

Change-Id: I12a3e6b2a12884d00bb81f2779074fed09b1b2e4
BUG: 887145
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4619
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

rpc: get hostnames of client to allow FQDN based authentication

2013-02-07T00:15:54+00:00

If FQDNs are used to authenticate clients, then from
this commit forth, the client ip(v4,6) is reverse looked up
using getnameinfo to get a hostname associated with it,
if any, thereby making FQDN-based rpc authentication possible.

Change-Id: I4c5241e7079a2560de79ca15f611e65c0b858f9b
BUG: 903553
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4439
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati