glusterfs.git/rpc/rpc-lib, branch v3.4.0alpha

rpcsvc: Fix memory corruption caused by rpcsvc_dump returning non-zero

2013-02-05T21:35:16+00:00

The convention followed is that any actor should return non-zero
value only if it has not attempted to send the reply back. If an
actor returns non-zero, rpcsvc_handle_rpc_call tries to send an
error reply. Since, rpcsvc_submit_generic frees the rpc_req, its wrong
to invoke it more than once on same rpc_req. When the transport is not
connected, rpcsvc_dump used to pass the non-zero value it got from
 transport to rpcsvc resulting in memory corruption. Hence this patch
makes rpcsvc_dump to return 0.

Change-Id: I1b6f28969ee546c44d193d3d33debccb65585b69
BUG: 903113
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4183
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Jeff Darcy

"gcc -pedantic": made 'inline' functions as 'static inline' functions

2013-01-23T19:12:15+00:00

for passing the build with -pedantic flag

Change-Id: I80fd9528321e4c6ea5bec32bf5cdc54cc4e4f65e
BUG: 875913
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.org/4186
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: fixes for gcc's '-pedantic' flag build

2013-01-22T06:17:36+00:00

* warnings on 'void *' arguments
* warnings on empty initializations
* warnings on empty array (array[0])

Change-Id: Iae440f54cbd59580eb69f3ecaed5a9926c0edf95
BUG: 875913
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4219
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc: Add an extra log message

2012-12-10T22:09:15+00:00

Adds an extra log message in rpcvsc_check_and_reply_error().
Also, makes a small change in the test-script.

Change-Id: I2b686e6fa86529cc4fbf0066df64057a9784b849
BUG: 884452
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4285
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpcsvc: do a 'iobuf_ref()' on buffer while synctaskizing actor

2012-12-10T05:59:41+00:00

Starting rpc actors using synctask causes rpcsvc to return before the actor
actually finishes its actions. This would cause the buffer to be unreffed by
socket and be possibly reused, before the actor used it, leading to failures
in the actor.
This patch makes rpcsvc take a ref on the buffer when synctaskizing the actor
and store it in the request structure, and then later unref it when the request
structure is destroyed. This makes sure that the buffer is not reused before the
actor has finished.

Change-Id: I8f81e1fef8f3719db220471d2d8ffb8916958956
BUG: 884452
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4277
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Revert "glusterd: add "volume label" command"

2012-12-05T00:27:48+00:00

This reverts commit dad16a51ba7e6b1c57529423c57257dbce97ee93

Test script causing "silent" failures during execution.

Change-Id: I26dbb8ed22256071cb415cc3aff572ef8372600e
Reviewed-on: http://review.gluster.org/4268
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: add "volume label" command

2012-12-04T22:42:30+00:00

This command is necessary when the local disk/filesystem containing a brick
is unexpectedly lost and then recreated.  Since 961bc80c, trying to start
the brick will fail because the trusted.glusterfs.volume-id xattr is
missing, and if we can't start it then we can't replace-brick or self-heal
so we're stuck in a permanently degraded state.  This command provides a
way to label the empty brick with the proper volume ID so that further
repair actions become possible.

Change-Id: I1c1e5273a018b7a6b8d0852daf111ddc3fddfdc2
BUG: 860297
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4259
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: remove ref/unref while unwinding frames

2012-11-30T08:01:53+00:00

Change-Id: Ib196ffdf8122a9510cc7c5953303a6e730091302
BUG: 853373
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.org/4062
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

BD Backend: CLI to create a full/linked clone of a image

2012-11-29T17:40:14+00:00

A new CLI command added to support cloning/snapshotting of a LV device

Syntax is:
$ gluster bd clone :/ 

$ gluster bd snapshot :/  

BUG: 805138
Change-Id: Idc2ac14525a3998329c742bf85a06326cac8cd54
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3719
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

BD Backend: CLI commands to create/delete image

2012-11-29T17:39:53+00:00

Cli commands  added to create/delete a LV device.

The following command creates lv in a given vg.
$ gluster bd create :/ 

The following command deletes lv in a given vg.
$ gluster bd delete :/

BUG: 805138
Change-Id: Ie4e100eca14e2ee32cf2bb4dd064b17230d673bf
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3718
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur