glusterfs.git/rpc/rpc-lib/src, branch v3.7.5

cluster/tier: add gluster v tier

2015-09-10T17:59:11+00:00

This is a backport of 11984.

> Currently the tier feature piggy backs off the rebalance command
> syntax to obtain status and this is clumsy. Introduce a new
> tier command that can do tier specific operations, starting
> with volume status to display counters.

> Old commands:
> gluster volume attach-tier  [replica count] {bricklist..}
> gluster volume detach-tier  {start|stop|commit}

> New commands:
> gluster volume tier  attach [replica count] {bricklist} |
>                           detach {start|stop|commit} |
>                           status

> Change-Id: Ic07b3c6260588162de7d34380f8cbd3d8a7f35d3
> BUG: 1255693
> Signed-off-by: Dan Lambright 
> Reviewed-on: http://review.gluster.org/11984
> Reviewed-by: Gaurav Kumar Garg 
> Tested-by: Gluster Build System 
Signed-off-by: Dan Lambright 

Change-Id: Id45bd0fa6b8606dd47863de83a694908da393229
BUG: 1261664
Signed-off-by: Dan Lambright 
Reviewed-on: http://review.gluster.org/12143
Tested-by: Gluster Build System 
Reviewed-by: Gaurav Kumar Garg

rpc-clnt: Check for transport object during rpc connection cleanup

2015-08-19T11:10:57+00:00

While doing glfs_fini(), all the xlators are first notified of
PARENT_DOWN. protocol-client xlator on receving that notification
does rpc_clnt_disable which disassociates rpc->conn with its
transport object and does socket shutdown. So any further references
to conn->trans should not happen during rpc connection cleanup which
is done mainly as part of epoll event handling of EPOLLERR/EPOLLHUP.

This is a backport of the below fix-
 http://review.gluster.org/#/c/11845/

BUG: 1254607
Change-Id: I619ec00fd061f77c9b04dfa6fd139620cb44189b
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11845
Reviewed-by: Raghavendra G 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/11953
Tested-by: NetBSD Build System

rpc: add owner xlator argument to rpc_clnt_new

2015-08-14T10:10:47+00:00

The @owner argument tells RPC layer the xlator that owns
the connection and to which xlator THIS needs be set during
network notifications like CONNECT and DISCONNECT.

Code paths that originate from the head of a (volume) graph and use
STACK_WIND ensure that the RPC local endpoint has the right xlator saved
in the frame of the call (callback pair). This guarantees that the
callback is executed in the right xlator context.

The client handshake process which includes fetching of brick ports from
glusterd, setting lk-version on the brick for the session, don't have
the correct xlator set in their frames. The problem lies with RPC
notifications. It doesn't have the provision to set THIS with the xlator
that is registered with the corresponding RPC programs. e.g,
RPC_CLNT_CONNECT event received by protocol/client doesn't have THIS set
to its xlator. This implies, call(-callbacks) originating from this
thread don't have the right xlator set too.

The fix would be to save the xlator registered with the RPC connection
during rpc_clnt_new. e.g, protocol/client's xlator would be saved with
the RPC connection that it 'owns'. RPC notifications such as CONNECT,
DISCONNECT, etc inherit THIS from the RPC connection's xlator.

Change-Id: I9dea2c35378c511d800ef58f7fa2ea5552f2c409
BUG: 1253212
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11436
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
(cherry picked from commit f7668938cd7745d024f3d2884e04cd744d0a69ab)
Reviewed-on: http://review.gluster.org/11908
Reviewed-by: Pranith Kumar Karampuri

rpc: check for unprivileged port should start at 1024

2015-08-14T04:05:21+00:00

The current check for unprivileged port starts beyond 1024
i.e. port > 1024
The actual check should start at 1024
i.e. port >= 1024

Change-Id: I78aff3025891e3e78ca6a9a670c89571752157df
BUG: 1248450
Reviewed-on: http://review.gluster.org/#/c/11788/
Signed-off-by: Milind Changire 
Reviewed-on: http://review.gluster.org/11804
Reviewed-by: Raghavendra Talur 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

client, rpc: make ping-timeout configurable for glusterfs clients

2015-08-13T05:05:57+00:00

Change-Id: Idd94adb0457aaffce7330f56f98cebafa2c4dae8
BUG: 1250810
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11818
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Tested-by: NetBSD Build System 
(cherry picked from commit 3403370ebeaf16567b79022c6ac48b2e0cd50db5)
Reviewed-on: http://review.gluster.org/11848

rdma : porting missing gf_log to gf_msg

2015-08-12T10:47:35+00:00

        Backport of http://review.gluster.org/#/c/11607/

Cherry picked from commit 6beb9ca292a0653d3d082af9d30f519a99569a14

> Change-Id: I036b43007fbcd0e528faab8d44e1a7fc820eaf1f
> BUG: 1242333
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11607
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: I036b43007fbcd0e528faab8d44e1a7fc820eaf1f
BUG: 1252272
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/11878
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Raghavendra G

rpc: fix binding brick issue while bind-insecure is enabled

2015-07-27T04:31:56+00:00

This patch is backport of http://review.gluster.org/#/c/11512/

> problem:

> When bind-insecure is turned on (which is the default now), it may happen
> that brick is not able to bind to port assigned by Glusterd for example
> 49192-49195...
>
> It seems to occur because the rpc_clnt connections are binding to ports in
> the same range. so brick fails to bind to a port which is already used by
> someone else
>
> solution:
>
> fix for now is to  make rpc_clnt to get port numbers from 65535 in a
> descending
> order, as a result port clash is minimized
>
> other fixes:
>
> previously rdma binds to port >= 1024 if it cannot find a free port < 1024,
> even when bind insecure was turned off(ref to commit '0e3fd04e'), this patch
> add's a check for bind-insecure in gf_rdma_client_bind function
>
> This patch also re-enable bind-insecure and allow insecure by default
> which was reverted (ref: commit cef1720) previously

> Change-Id: Ia1cfa93c5454e2ae0ff57813689b75de282ebd07
> BUG: 1238661
> Signed-off-by: Prasanna Kumar Kalever 

Change-Id: Iea55f9b2a57b5e24d3df2c5fafae12fe99e9dee0
BUG: 1246481
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/11758
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

Revert "rpc: By default set allow-insecure, bind-insecure to on"

2015-07-02T15:46:13+00:00

This reverts commit 243a5b429f225acb8e7132264fe0a0835ff013d5.

This patch introduced a regression where client no longer binds to 
privileged port. This is causing lots of regressions. Hence reverting 
this patch for now and will be resent after suitable modifications.

Change-Id: I302252fd3832b0a5a03b04e30cfa0def37597404
Reviewed-on: http://review.gluster.org/11508
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

rpc: By default set allow-insecure, bind-insecure to on

2015-07-01T06:59:51+00:00

        Backport of http://review.gluster.org/11039

since we now use SSL (Secure Sockets Layer) for the security issues, the patch
changes the default setting to allow connections/requests from non-privilaged
ports by setting allow-insecure and bind-insecure to 1

Also added bind functionality for insecure binding which can select from
available local ports dynamically

BUG: 1232660
Change-Id: I927e112223f33611452093e38cd846a0b9347e57
Signed-off-by: Pranith Kumar K 
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/11274
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

rdma: porting rdma to new message id logging format

2015-06-26T06:52:44+00:00

        Backport of http://review.gluster.org/#/c/9868/

Cherry picked from 4306245aef7cdcbfa6d7a59dccd031d4ada54105
> Change-Id: I71e940817ae0a9378e82332d5a8569114fc13482
> BUG: 1194640
> Signed-off-by: Humble Devassy Chirammal 
> Reviewed-on: http://review.gluster.org/9868
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 

Change-Id: I71e940817ae0a9378e82332d5a8569114fc13482
BUG: 1217722
Signed-off-by: Humble Devassy Chirammal 
Reviewed-on: http://review.gluster.org/10673
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G