glusterfs.git/libglusterfs, branch v3.3.2qa3

libglusterfs/statedump: move options file and statedumps from /tmp

2013-05-14T17:47:09+00:00

Change-Id: I6b107b9a668b0521b955dba8895cbbeaf9e7cb02
BUG: 764890
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/5005
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterfs: add gf_mkostemp api and use it instead of mkostemp of libc

2013-05-14T16:02:11+00:00

Change-Id: Ia3d2f37ae1f7a7d87a75c82bedb4963729d45b6c
BUG: 764890
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/5004
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

distribute: Fix fds being leaked during rebalance

2013-04-26T07:35:00+00:00

This patch is a backport of 2 patches from master branch which fixes the
leak of fds during a rebalance process.

The patches are,
* libglusterfs/syncop: do not hold ref on the fd in cbk
  (e979c0de9dde14fe18d0ad7298c6da9cc878bbab)
* cluster/distribute: Remove suprious fd_unref call
  (5d29e598665456b2b7250fdca14de7409098877a)

Change-Id: Icea1d0b32cb3670f7decc24261996bca3fe816dc
BUG: 928631
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4888
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

dict: Put "goto out" in dict_unserialize to avoid process crash

2013-04-12T07:21:09+00:00

Problem:
In the dictionary serialization function, if the
[(buf + vallen) > (orig_buf + size)], then memdup is getting failed.

Fix:
Put "goto out" whenever this condition is met.

Change-Id: Ia10ddc7e1cf551eed0e2c3d0f0364c6961e13025
BUG: 947824
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: http://review.gluster.org/4770
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

Fix spelling error

2013-03-13T03:06:42+00:00

"temporary" was misspelled
s/tempaory/temporary/

BUG: 818884

Change-Id: If033acd4d8d778bde7588d8b4b512d6508e36f22
Signed-off-by: Joe Julian 
Reviewed-on: http://review.gluster.org/4661
Reviewed-by: Jeff Darcy 
Tested-by: Anand Avati

libglusterfs: Fix memory leaks in fd_lk_insert_and_merge

2013-02-18T04:49:42+00:00

Change-Id: Id322717b79c5252172811fea259f2073f710a463
BUG: 834465
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4530
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

localtime and ctime are not MT-SAFE

2013-02-08T20:04:42+00:00

There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
   that another thread calling localtime (or ctime) will over-write
   the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
   not a problem on 64-bit or little-endian 32-bit. But even though
   we probably have zero users on big-ending 32-bit platforms, it's
   still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
   writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
   tracing, or dumping. I submit that if an error somehow occurs in
   the call to localtime or ctime, the log/trace/dump still should
   still occur.
5) Appliances should all have their clocks set to UTC, and all log
   entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()

Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
   e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
   not a function. You don't use i +(32), why use sizeof().
   (And yes, you do use parens with sizeof().)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
   Per-thread stack is limited. Time strings are never longer than ~20
   characters, so why waste 220+ bytes on the stack?

Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
   variations. It's not clear to me whether this ever matters, not to
   mention 3rd party log filtering tools may already rely on a
   particular format. Still it would be nice to have a single manifest
   constant and have every call to localtime/strftime consistently use
   the same format.

BUG: 832173

Change-Id: Iee9719db4576eacc6c75694d9107954d0912cba8
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3613
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

mount/fuse: add mount-option "enable-ino32" for the native client

2013-02-07T21:38:20+00:00

By default the GlusterFS-native client uses 64-bit inodes. Some 32-bit
applications can not handle these correctly. Introduce a client-side
mount option "enable-ino32" which causes the FUSE-client to squash the
64-bit inodes into a 32-bit value.

Change-Id: I7544010a27b7eb2d3b9fadb84ed934e4e7dff21e
BUG: 850352
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/3886
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Add missing contrib/libgen files to distribution

2012-09-09T18:20:44+00:00

This is a backport of I3f49eb4a1a186cb2d178539ada6a05c8c1aa8265

BUG: 764655
Change-Id: I32264acec0f122d045f369a254df17b488962b9f
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/3884
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati

core: check for pre-allocated blocks in backend fs, fix it.

2012-08-17T06:58:13+00:00

There is a possibility that the backend FS (like XFS) can
allocate blocks beyond EOF for better performance reasons, which
results in 'st_blocks' with higher values than what is consumed by
the file descriptor. This would break few logic inside GlusterFS,
like quota behavior etc, thus we need the exact number of blocks
which are consumed by the file to the higher layers inside GlusterFS.

Currently, this logic won't work for sparse files (ie, file with holes)

Change-Id: Ied216733a8862e84f7da8386ae0a144f3f5cd5f2
BUG: 839589
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.com/3671
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur