glusterfs.git/libglusterfs/src/logging.c, branch v3.8.10

libglusterfs: coverity fix

2016-04-14T12:55:50+00:00

fix missing varargs cleanup

CID 1124856: string overflow

CID 1124656: NULL return

CID 1124374: constant expression

Change-Id: Iead530c599bdfef05a40c68b892215f4e4f02247
BUG: 789278
Signed-off-by: Sakshi Bansal 
Reviewed-on: http://review.gluster.org/9630
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

libglusterfs: open cmd_history log file with O_APPEND and O_WRONLY

2016-03-29T19:10:47+00:00

Commit 8fdfa0c introduced a fix to ensure cmd_history file is log rotated
properly. However with this fix fdopen() is called with mode "a" on a fd which
was not opened with O_WRONLY & O_APPEND resulting into a fdopen() failure.

Fix is to open cmd_history.log file with O_CREATE|O_WRONLY|O_APPEND mode

Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
BUG: 1286959
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13829
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

gfapi: Fix the crashes caused by global_xlator and THIS

2016-03-23T05:47:31+00:00

Issue: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10922

The right fix for this is elaborate and intrusive, until it is in place,
this patch provides a temperory fix. This fix is necessary, as without this
libgfapi applications like qemu, samba, NFS ganesha are prone to crashes.
This patch will be reverted completely, once the actual fix gets accepted.

Change-Id: Ic975ab0bb03ba415cdf9bddba1534ba4d2d2820c
BUG: 1319374
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/13784
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Jeff Darcy 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

libglusterfs: close & open cmd_history.log on log rotate

2016-02-04T21:51:53+00:00

Post log rotate, cmd_history.log is not refreshed (closed & opened back)
due to which new commands still land up in the log rotated file.

Fix is to close and open cmd_history.log file upon log rotation

Change-Id: Ie6990c9d55b0afa544bc5c84de3db49ff4b1299b
BUG: 1286959
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/12832
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System

core: use syscall wrappers instead of direct syscalls - libglusterfs

2015-11-16T14:18:10+00:00

various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.

If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.

Change-Id: Ieeca2d36adbc884e4cfa0026dba40df70310d40b
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/12275
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

logging : GF_LOG_NONE logs always

2015-09-01T12:58:40+00:00

Shouldn't GF_LOG_NONE mean "Never log this"? If so, it's not being
tested for and is, instead, treated as a higher priority than
CRITICAL thus is always logged.

Change-Id: Icad1e02a720a05ff21bd54ebf19c0032e6d5ce03
BUG: 1246794
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11797
Reviewed-by: Raghavendra Talur 
Tested-by: NetBSD Build System

logging: Stop using global xlator for log_buf allocations

2015-08-08T10:51:16+00:00

This reverts commit 765849ee00f6661c9059122ff2346b03b224745f.

With http://review.gluster.org/#/c/10417/, struct mem_accnt
is no longer embedded in a xlator_t object, but instead is
allocated separately. Hence this workaround provided to avoid
crashes in logging infrastructure is no longer needed

BUG: 1243806
Change-Id: I1bc006172ebe5e417a5923f8be2f37a6277c5e5d
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11811
Tested-by: NetBSD Build System 
Reviewed-by: N Balachandran 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

Revert "Revert "core: avoid crashes in gf_msg dup-detection code""

2015-07-28T17:38:54+00:00

This reverts commit ca67ac071c56a3bd6f2b2ba3a958f0305db50a3d.

Change-Id: Iba688b524c78b84aaa0992afa5ee8e549603d990
Reviewed-on: http://review.gluster.org/11777
Reviewed-by: Jeff Darcy 
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

Revert "core: avoid crashes in gf_msg dup-detection code"

2015-07-27T17:09:51+00:00

This reverts commit 765849ee00f6661c9059122ff2346b03b224745f.

With http://review.gluster.org/#/c/10417/, struct mem_accnt
is no longer embedded in a xlator_t object, but instead is
allocated separately. Hence this workaround provided to avoid
crashes in logging infrastructure is no longer needed.

Change-Id: I460b62780f570cd9873bad17d9327eefc17a1355
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11746
Tested-by: Gluster Build System 
Reviewed-by: Poornima G 
Reviewed-by: Kaleb KEITHLEY

logging: Fixed incorrect buffer size

2015-07-12T06:08:54+00:00

An incorrect buffer size passed in to_gf_msg_backtrace
prevented the callers from being logged.

Change-Id: I86104d6b3f611455308d5b3420dfb6d456070a23
BUG: 1238952
Signed-off-by: Nithya Balachandran 
Reviewed-on: http://review.gluster.org/11521
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Pranith Kumar Karampuri