glusterfs.git/libglusterfs/src/logging.c, branch v3.7.12rc1

libglusterfs: open cmd_history log file with O_APPEND and O_WRONLY

2016-03-31T07:53:44+00:00

Commit 8fdfa0c introduced a fix to ensure cmd_history file is log rotated
properly. However with this fix fdopen() is called with mode "a" on a fd which
was not opened with O_WRONLY & O_APPEND resulting into a fdopen() failure.

Fix is to open cmd_history.log file with O_CREATE|O_WRONLY|O_APPEND mode

Backport of commit 207289621f6c5b75bdb80aa14ddaf72efd5eb9b1:
> Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
> BUG: 1286959
> Signed-off-by: Atin Mukherjee 
> Reviewed-on: http://review.gluster.org/13829
> Smoke: Gluster Build System 
> Reviewed-by: Niels de Vos 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
BUG: 1304963
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13847
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System

gfapi: Fix the crashes caused by global_xlator and THIS

2016-03-30T14:22:40+00:00

Issue: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10922

The right fix for this is elaborate and intrusive, until it is in place,
this patch provides a temperory fix. This fix is necessary, as without this
libgfapi applications like qemu, samba, NFS ganesha are prone to crashes.
This patch will be reverted completely, once the actual fix gets accepted.

Credits: Rajesh Joseph, Raghavendra Talur, Anoop CS

Back-port of: http://review.gluster.org/#/c/13784/
Change-Id: I8a8a0572bea0eec94ece6aa0d7afcf2f459b4a43
BUG: 1319989
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/13803
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Niels de Vos

libglusterfs: close & open cmd_history.log on log rotate

2016-02-19T10:02:01+00:00

This patch is backport of: http://review.gluster.org/#/c/12832/

Post log rotate, cmd_history.log is not refreshed (closed & opened back)
due to which new commands still land up in the log rotated file.

Fix is to close and open cmd_history.log file upon log rotation

>> Change-Id: Ie6990c9d55b0afa544bc5c84de3db49ff4b1299b
>> BUG: 1286959
>> Signed-off-by: Gaurav Kumar Garg 
>> Reviewed-on: http://review.gluster.org/12832
>> Smoke: Gluster Build System 
>> CentOS-regression: Gluster Build System 
>> Reviewed-by: Niels de Vos 
>> NetBSD-regression: NetBSD Build System 
(cherry picked from commit 8fdfa0c17cf492f39e675f7502596754f6e5aeb4)

Change-Id: Ie6990c9d55b0afa544bc5c84de3db49ff4b1299b
BUG: 1304963
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/13361
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

logging : GF_LOG_NONE logs always

2015-10-28T10:08:20+00:00

Shouldn't GF_LOG_NONE mean "Never log this"? If so, it's not being
tested for and is, instead, treated as a higher priority than
CRITICAL thus is always logged.

	Backport of http://review.gluster.org/11797
Cherry picked from 7b390983768e833a8df15b994038155c53d71bdd

>Change-Id: Icad1e02a720a05ff21bd54ebf19c0032e6d5ce03
>BUG: 1246794
>Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/11797
>Reviewed-by: Raghavendra Talur 
>Tested-by: NetBSD Build System 

Change-Id: Icad1e02a720a05ff21bd54ebf19c0032e6d5ce03
BUG: 1259167
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/12087
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Talur 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

logging: Stop using global xlator for log_buf allocations

2015-08-18T17:07:20+00:00

This reverts commit 765849ee00f6661c9059122ff2346b03b224745f.

With http://review.gluster.org/#/c/10417/, struct mem_accnt
is no longer embedded in a xlator_t object, but instead is
allocated separately. Hence this workaround provided to avoid
crashes in logging infrastructure is no longer needed

This is a backport of the below fix -
http://review.gluster.org/11811

BUG: 1254436
Change-Id: I4bbf7649bdc29424ff1bb878f79e99328efa0b3e
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11811
Reviewed-by: N Balachandran 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/11946
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Tested-by: NetBSD Build System

logging: Fixed incorrect buffer size

2015-07-27T10:26:37+00:00

An incorrect buffer size passed in to_gf_msg_backtrace
prevented the callers from being logged.

Change-Id: If1ddc5cd9317b55d9884f26cfddd0b0f86e7a7b2
BUG: 1241841
Signed-off-by: Nithya Balachandran 
Reviewed-on: http://review.gluster.org/11615
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Kaushal M

defaults,globals,iobuf,latency,logging,options,xlator/libglusterfs : porting to a new logging framework

2015-07-13T13:10:58+00:00

        Backport of http://review.gluster.org/10826

Cherry picked from ef374774b8727b2f76915a1f88b26c83c77dde43
>Change-Id: If6a55186cddc3d1c4d22e3d56b45358b84feeb49
>BUG: 1194640
>Signed-off-by: Mohamed Ashiq 
>Reviewed-on: http://review.gluster.org/10826
>Tested-by: NetBSD Build System 
>Reviewed-by: Pranith Kumar Karampuri 

Change-Id: If6a55186cddc3d1c4d22e3d56b45358b84feeb49
BUG: 1217722
Signed-off-by: Mohamed Ashiq 
Reviewed-on: http://review.gluster.org/11405
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Niels de Vos

libglusterfs: avoid crash due to ctx being NULL

2015-06-19T11:07:24+00:00

>Reviewed-on: http://review.gluster.org/10155
>Tested-by: Gluster Build System 
>Reviewed-by: Niels de Vos 
>Reviewed-by: Vijay Bellur 
>(cherry picked from commit b855aa062927ea4845f56d2d1a1a2a8af3dc4192)

BUG : 1233559
Change-Id: Ib667ed42f0b598baddb829b448d6efc3d8e044f1
Signed-off-by: Humble Devassy Chirammal 
Reviewed-on: http://review.gluster.org/10969
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

core: avoid crashes in gf_msg dup-detection code

2015-04-22T13:18:09+00:00

Use global_xlator for allocations so that we don't try to free objects
belonging to an already-deleted translator (which will crash).

Change-Id: Ie72a546e7770cf5cb8a8370e22448c8d09e3ab37
BUG: 1214220
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/10319
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Reviewed-by: Krutika Dhananjay 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/10330
Tested-by: NetBSD Build System

libglusterfs: avoid possibility of crash when ctx is null

2015-04-08T18:13:36+00:00

ctx is passed to gf_log_inject_timer_event() and pass through to
 __gf_log_inject_timer_event() where the struct members are getting
dereferenced, and can cause crash if the passed ctx is null. This patch
avoids the issue.

Change-Id: I153dbb5d3744898429139e3d40bb4f0e9093632a
BUG: 1208118
Signed-off-by: Humble Devassy Chirammal 
Reviewed-on: http://review.gluster.org/10102
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos