glusterfs.git/libglusterfs/src/iobuf.c, branch release-8

libglusterfs-options: structure logging

2020-02-09T02:53:40+00:00

convert all gf_msg() to gf_smsg()

Change-Id: I8f1ff462b9c8012ed676c51450930a65ac403bf3
Updates: #657
Signed-off-by: yatipadia

iobuf.c, h: minor fixes

2019-11-07T08:30:24+00:00

- Align structures
- gf_iobuf_get_pagesize() will now also return the index, reducing the need
for an additional very similar call.
- Removal of an inefficient loop I've inadvertently added previously.
It was harmless, but just inefficient.
- New pool initialization does not need to be done under lock - no
one can touch that pool yet, so no need to protect it.

Change-Id: I61c50f2f14fa79edc131e515e9615a9928ee2dca
updates: bz#1193929
Signed-off-by: Yaniv Kaul

Revert "iobuf: Get rid of pre allocated iobuf_pool and use per thread mem pool"

2019-01-08T11:16:03+00:00

This reverts commit b87c397091bac6a4a6dec4e45a7671fad4a11770.

There seems to be some performance regression with the patch and hence recommended to have it reverted.

Updates: #325
Change-Id: Id85d6203173a44fad6cf51d39b3e96f37afcec09

iobuf: Get rid of pre allocated iobuf_pool and use per thread mem pool

2018-12-18T09:35:24+00:00

The current implementation of iobuf_pool has two problems:
- prealloc of 12.5MB memory, this limits the scale factor of the gluster
  processes due to RAM requirements
- lock contention, as the current implementation has one global
  iobuf_pool lock. Credits for debugging and addressing the same goes to
  Krutika Dhananjay . Issue: #410

Hence changing the iobuf implementation to use per thread mem pool.
This may theoritically appear to cause perf dip as there is no preallocation.
But per thread mem pool will not have significant perf impact as the last
allocated memory is kept alive for subsequent allocs, for some time.
The worst case would be if iobufs requested are of random sizes each time.
The best case is, if we get iobuf request of the same size. From the perf
tests, this patch did not seem to cause any perf decrease.

Note that, with this patch, the rdma performance is going to degrade
drastically. In one of the previous patchsets we had fixes to not
degrade rdma perf, but rdma is not supported and also not tested [1].
Hence the decision was to not have code in rdma that is not tested
and not supported.

[1] https://lists.gluster.org/pipermail/gluster-users.old/2018-July/034400.html

Updates: #325
Change-Id: Ic2ef3bd498f9250dea25f25ba0c01fde19584b27
Signed-off-by: Poornima G

libglusterfs: Move devel headers under glusterfs directory

2018-12-05T21:47:04+00:00

libglusterfs devel package headers are referenced in code using
include semantics for a program, this while it works can be better
especially when dealing with out of tree xlator builds or in
general out of tree devel package usage.

Towards this, the following changes are done,
- moved all devel headers under a glusterfs directory
- Included these headers using system header notation <> in all
code outside of libglusterfs
- Included these headers using own program notation "" within
libglusterfs

This change although big, is just moving around the headers and
making it correct when including these headers from other sources.

This helps us correctly include libglusterfs includes without
namespace conflicts.

Change-Id: Id2a98854e671a7ee5d73be44da5ba1a74252423b
Updates: bz#1193929
Signed-off-by: ShyamsundarR

libglusterfs/src/iobuf.c: small refactor to re-use code.

2018-12-05T03:59:29+00:00

No functional changes (I hope).
Compile-tested only!

updates: bz#1193929
Signed-off-by: Yaniv Kaul 

Change-Id: Ifbec21c18a6dbe27c5271db156bff4d30ca85dbf

libglusterfs/src/iobuf.c: don't forget to unlock a mutex

2018-11-06T16:33:36+00:00

commit ed83a4ee7b73e6b04694d1ac11ed25d2983ac943 changed locking
order and forgot to unlock in a negative path (when index was -1).
Coverity caught it (thanks!) as  CID 1396581:  Program hangs  (LOCK)

Note: I'm unlocking before logging the failure. I think it's the right
order - logging can take a while (especially if your disk is slow).

Compile-tested only!

updates: bz#1193929
Signed-off-by: Yaniv Kaul 

Change-Id: I82ac241edf1d511bf6807cf9c46c538ab9f4acc4

libglusterfs/src/iobuf.c: where possible, pass the index parameter

2018-11-06T04:18:50+00:00

Don't 'calculate' again where it can be passed.
If possible, do not perform under lock.

Also remove some NULL checks, assuming they were done by the callers.
Left a remark for each such change.

Compile-tested only!

updates: bz#1193929
Signed-off-by: Yaniv Kaul 

Change-Id: Ia5c2851506da3388cb2d4445334c58881e2c4416

libglusterfs/src/iobuf.c: take the pool lock once in new pool

2018-11-06T04:18:50+00:00

When creating a new pool, take the pool lock once and create
all arenas, instead of taking and releasing for each arena.

Compile-tested only!

updates: bz#1193929
Signed-off-by: Yaniv Kaul 

Change-Id: I7daa39de960e47e66a32ecab724cf3a61ccdc01b

libglusterfs/src/iobuf.c: remove some if statements

2018-11-06T04:18:50+00:00

Small code refactoring to remove some if statements
in several functions. No functional changes expected.

Compile-tested only!

updates: bz#1193929
Signed-off-by: Yaniv Kaul 

Change-Id: If9f8d5d53c9688fb994b6d690aea66f65fa01c55