glusterfs.git/libglusterfs/src/dict.c, branch v3.0.5rc1 More robust dictionary (un)serialization (fixes bug #397). 2009-12-21T05:38:33+00:00 Hraban Luyat hraban@0brg.net 2009-12-19T15:47:25+00:00 2a51ab19e6370325a5ebac9ed63f8606738919ec Hello, This patch fixes bug 397: dictionary (de)serialization used pointer casting which forced word-alignment on (at least) armv5tel, causing corruption while writing and reading buffers into memory. It also adds some debugging (more information in case of errors). I tried to send this a few times already but I think it got bounced from the list. Greetings, Hraban Luyat Signed-off-by: Hraban Luyat <hraban@0brg.net> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 397 (dictionary serialization / deserialization fails on armv5tel) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=397 
Hello,

This patch fixes bug 397: dictionary (de)serialization used pointer
casting which forced word-alignment on (at least) armv5tel, causing
corruption while writing and reading buffers into memory. It also adds
some debugging (more information in case of errors).

I tried to send this a few times already but I think it got bounced from
the list.

Greetings,

Hraban Luyat

Signed-off-by: Hraban Luyat <hraban@0brg.net>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>

BUG: 397 (dictionary serialization / deserialization fails on armv5tel)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=397
Changed occurrences of Z Research to Gluster. 2009-10-07T10:54:49+00:00 Vijay Bellur vijay@gluster.com 2009-10-05T23:59:13+00:00 0b1197defa255ee533e568c9534bc6a5b5aadc29 Signed-off-by: Anand V. Avati <avati@dev.gluster.com> 
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
fix build warnings in 'libglusterfs/' 2009-07-20T21:28:53+00:00 Amar Tumballi amar@gluster.com 2009-07-17T22:41:44+00:00 632cce5e720acaa28ab680a6850f2aa8289d4628 return value of 'asprintf' was not checked, and the flow was continuing without returning error, which could cause potential segfaults in code (mostly possible during ENOMEM case). Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 130 (build warnings) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130 
return value of 'asprintf' was not checked, and the flow was
continuing without returning error, which could cause potential
segfaults in code (mostly possible during ENOMEM case).

Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 130 (build warnings)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=130
Include glusterfs.h in dict.c 2009-06-11T14:51:26+00:00 Vikas Gorur vikas@gluster.com 2009-06-09T05:08:59+00:00 f7ca417394aeb5a8c2144e3b2ae6493ef172b32d Signed-off-by: Anand V. Avati <avati@dev.gluster.com> 
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
dict.c: make dict_serialized_length and dict_serialize to hold locks. 2009-05-16T11:10:26+00:00 Raghavendra G raghavendra@zresearch.com 2009-05-15T10:55:50+00:00 254f770af6ae6ff207fc567b6576a31469c84f67 Signed-off-by: Anand V. Avati <avati@amp.gluster.com> 
Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
dict.c: Add dict_allocate_and_serialize 2009-05-16T11:10:18+00:00 Raghavendra G raghavendra@zresearch.com 2009-05-15T10:55:20+00:00 9669c70c901474dc21ef08e49478b5f5dead8f64 - this procedure atomically allocates a buffer and serializes dict into it. - this procedure helps avoid memory corruptions due to race conditions where in new members are added into dict between allocating a buffer for serializing and actually serializing buffer into it. Signed-off-by: Anand V. Avati <avati@amp.gluster.com> 
- this procedure atomically allocates a buffer and serializes dict into it.
  - this procedure helps avoid memory corruptions due to race conditions where
    in new members are added into dict between allocating a buffer for
    serializing and actually serializing buffer into it.

Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Changed the gf_log warning for return of null via CALLOC from 'old' to 'newdata' 2009-03-26T10:58:28+00:00 Bharat Shetty Barkur bharat.shetty@gmail.com 2009-03-22T17:57:37+00:00 3df266c278ab74c6bf1980bd17a545595bd04344 Fixed the warning message to be more clearer for return of the null by CALLOC, by changing old to newdata. Signed-off-by: Anand V. Avati <avati@amp.gluster.com> 
Fixed the warning message to be more clearer for return of the null by CALLOC, by changing old to newdata.

Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
updated copyright header to extend copyright upto 2009 2009-02-26T16:48:46+00:00 Basavanagowda Kanur gowda@gluster.com 2009-02-26T15:44:23+00:00 3d8bc3cbafa84a46e43e46f69d3e7d617d746012 updated copyright header to include 2009. Signed-off-by: Anand V. Avati <avati@amp.gluster.com> 
updated copyright header to include 2009.

Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
new functions dict_{get,set}_double for float/double value 2009-02-21T15:37:31+00:00 Harshavardhana harsha@zresearch.com 2009-02-19T18:26:17+00:00 9679f8db65de29a40f622c12c2cc538d70b052b2 fixed warning Signed-off-by: Anand V. Avati <avati@amp.gluster.com> 
fixed warning

Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
Added all files 2009-02-18T12:06:07+00:00 Vikas Gorur vikas@zresearch.com 2009-02-18T12:06:07+00:00 77adf4cd648dce41f89469dd185deec6b6b53a0b