glusterfs.git/glusterfsd/src/glusterfsd-mgmt.c, branch v3.6.3

rdma: client connection establishment takes more time

2015-01-06T09:43:45+00:00

        Backport of http://review.gluster.org/8934

For rdma type only volume client connection establishment
with server takes more than three seconds. Because for
tcp,rdma type volume, will have 2 ports one for tcp and
one for rdma, tcp port is stored with brickname and rdma
port is stored as "brickname.rdma" during pamap_sighin.
During the handshake when trying to get the brick port
for rdma clients, since we are not aware of server
transport type, we will append '.rdma' with brick name.
So for tcp,rdma volume there will be an entry with
'.rdma', but it will fail for rdma type only volume.
So we will try again, this time without appending '.rdma'
using a flag variable need_different_port, and it will succeed,
but the reconnection happens only after 3 seconds.
In this patch for rdma only type volume
we will append '.rdma' during the pmap_signin. So during the
handshake we will get the correct port for first try itself.
Since we don't need to retry , we can remove the
need_different_port flag variable.

Change-Id: I82a8a27f0e65a2e287f321e5e8292d86c6baf5b4
BUG: 1166515
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/8934
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/9177
Reviewed-by: Raghavendra Bhat

rdma:rdma fuse mount hangs for tcp,rdma volumes if brick is down.

2015-01-06T09:39:15+00:00

        Backport of http://review.gluster.org/8762

When we try to mount a tcp,rdma volume as rdma
transport using FUSE protocol, then mount will
hang if the brick is down. When we kill a process,
signal will be received in glusterfsd process and
it will call pmap_signout with port listening on tcp only.
In case of the tcp,rdma there will be two ports,
and port which is listening for rdma will not
called for sign out.
So the mount process will try to connect to a port
which is not open and it will keep trying to connect.
This patch will call pmap_signout for rdma port also,
So when mount tries to get the brick port,it will fail.

Change-Id: I73f90d7340afa3b0b1278924206f1488e4094a62
BUG: 1166515
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/8762
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/9176
Reviewed-by: Raghavendra Bhat

rpcsvc: Validate RPC procedure number before fetch

2014-05-17T18:56:01+00:00

While accessing the procedures of given RPC program in,
rpcsvc_get_program_vector_sizer(), It was not checking boundary
conditions which would cause buffer overflow and subsequently SEGV.

Make sure rpcsvc_actor_t arrays have numactors number of actors.

FIX:
Validate the RPC procedure number before fetching the actor.

Special Thanks to: Murray Ketchion, Grant Byers

Change-Id: I8b5abd406d47fab8fca65b3beb73cdfe8cd85b72
BUG: 1096020
Signed-off-by: Santosh Kumar Pradhan 
Reviewed-on: http://review.gluster.org/7726
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Anand Avati

glusterd/snashot: Perform missed snap creates

2014-05-06T07:25:11+00:00

When a brick is started, and the glusterfsd process requests
for volfile, the brick_name is sent in the req dict. In
glusterd, after fetching the spec the brick_name is looked
up in the missed_snap_list, and any missing snap creates on
the same brick are performed. After this, the glusterd
responds back with the specfile.

Also collate brick data from the node's hosting the bricks
during restore. In case the data is absent, the local node's
data is used. This is needed to ensure that, during a restore
we collect the information created when a missed snap create
is performed.

Change-Id: I47cefdeba96f2702be810965734cf0fac61d3d2d
BUG: 1061685
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7551
Reviewed-by: Santosh Pradhan 
Reviewed-by: Rajesh Joseph 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

features/changelog: Barrier in changelog during snapshot.

2014-05-01T15:45:15+00:00

        Changelog barriers unlink, rename, rmdir fops on barrier 'on'
        notification from glusterfsd mgmt layer and unbarriers the
        same on barrier 'off' notification during snapshot.

        Please see the following link for more details.
        http://www.gluster.org/community/documentation/index.php/Changelog_Design_changes_for_snapshot

Signed-off-by: Kotresh H R 

Change-Id: Iea9c62fafc86242f9404e03679b1941aa9c88c9a
Signed-off-by: Kotresh H R 
Reviewed-on: http://review.gluster.org/7415
Reviewed-by: Venky Shankar 
Reviewed-by: Varun Shastry 
Tested-by: Gluster Build System

glusterd: Add a barrier brick-op

2014-04-29T16:37:08+00:00

This patch introduces a new 'barrier' brick-op which will be used to
activate/deactivate the barriering on the bricks. This includes
barriering in the barrier xlator and in the changelog xlator. All the
required code has been including a bricks select function, a payload
builder and a brick-op handler.

Change-Id: I91d9d77f691c2e89823f7dc4e84900ec40dc4dd2
BUG: 1060002
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/6943
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

gluster: GlusterFS Volume Snapshot Feature

2014-04-11T23:29:17+00:00

This is the initial patch for the Snapshot feature. Current patch
includes following features:
* Snapshot create
* Snapshot delete
* Snapshot restore
* Snapshot list
* Snapshot info
* Snapshot status
* Snapshot config

Change-Id: I2f46920c0d61c515f6a60e0f8b46fff886d9f6a9
BUG: 1061685
Signed-off-by: shishir gowda 
Signed-off-by: Sachin Pandit 
Signed-off-by: Vijaikumar M 
Signed-off-by: Raghavendra Bhat 
Signed-off-by: Rajesh Joseph 
Signed-off-by: Joseph Fernandes 
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7128
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterfsd: Check for NULL before dereference.

2014-02-14T15:06:28+00:00

BUG: 789278
CID: 1124805

Change-Id: I5926a4e59790f142d65f034726c9c369c2ad7808
Signed-off-by: Jose A. Rivera 
Reviewed-on: http://review.gluster.org/6909
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

core:Fixing NULL dereference issue.

2014-01-22T14:10:55+00:00

1.Checking of frame before calling STACK_DESTROY (frame->root)
Signed-off-by: surabhi 

Change-Id: I21d27a8b4e556c00cd123afe8512e010a1a1f80d
BUG: 789278
Signed-off-by: surabhi 
Reviewed-on: http://review.gluster.org/6749
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

core: Coverity issue "Use of uninitialized scalar variable"

2014-01-18T16:47:17+00:00

Issue:
1. In "unlink (export_path)" "export_path" might contain an arbitrary value left from earlier
 computations.
2. In "(msg[0] != '\0')"  msg might contain an arbitrary value

Change-Id: Icca8f557fd6b5e046dff1d5a84a72061975868d0
BUG: 789278
Signed-off-by: Lalatendu Mohanty 
Reviewed-on: http://review.gluster.org/6701
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur