glusterfs.git/geo-replication, branch v3.11.2

geo-rep: Fix entry failure because parent dir doesn't exist

2017-07-10T13:59:06+00:00

In a distributed volume on master, it can so happen that
the RMDIR followed by MKDIR is recorded in changelog on
a particular subvolume with same gfid and pargfid/bname
but not on all subvolumes as below.

E 61c67a2e-07f2-45a9-95cf-d8f16a5e9c36 RMDIR \
9cc51be8-91c3-4ef4-8ae3-17596fcfed40%2Ffedora2
E 61c67a2e-07f2-45a9-95cf-d8f16a5e9c36 MKDIR 16877 0 0 \
9cc51be8-91c3-4ef4-8ae3-17596fcfed40%2Ffedora2

While processing this changelog, geo-rep thinks RMDIR is
successful and does recursive rmdir on slave. But in the
master the directory still exists. This could lead to
data discrepancy between master and slave.

Cause:
RMDIR-MKDIR pair gets recorded so in changelog when the
directory removal is successful on cached subvolume and
failed in one of hashed subvol for some reason
(may be down). In this case, the directory is re-created
on cached subvol which gets recorded as MKDIR again in
changelog.

Solution:
So while processing RMDIR geo-replication should stat on
master with gfid and should not delete it if it's present.

> Change-Id: If5da1d6462eb4d9ebe2e88b3a70cc454411a133e
> BUG: 1467718
> Signed-off-by: Kotresh HR 
> Reviewed-on: https://review.gluster.org/17695
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Aravinda VK 
(cherry picked from commit b25bf64f3a3520a96ad557daa4903c0ceba96d72)

Change-Id: If5da1d6462eb4d9ebe2e88b3a70cc454411a133e
BUG: 1468200
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17715
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

geo-rep: Fix meta data sync on symlink

2017-06-06T12:58:43+00:00

chmod doesn't support 'no dereference' option.
It always deference the symlink. But 'chown'
does support metadata changes on symlink itself,
which was not taken care while syncing. This
patch fixes the same.

> Change-Id: Ic9985f4e39d15b5a9deb379841bcfb2c263d3e6c
> BUG: 1455559
> Signed-off-by: Kotresh HR 
> Reviewed-on: https://review.gluster.org/17389
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Aravinda VK 
> Smoke: Gluster Build System 
> Reviewed-by: Amar Tumballi 
> CentOS-regression: Gluster Build System 
(cherry picked from commit 324e81d6fea324d512431a2604086326b8848e9b)


Change-Id: Ic9985f4e39d15b5a9deb379841bcfb2c263d3e6c
BUG: 1458664
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17463
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

geo-rep: Fix mount cleanup

2017-04-27T05:58:51+00:00

On corner cases, mount cleanup might cause
worker crash. Fixing the same.

Change-Id: I38c0af51d10673765cdb37bc5b17bb37efd043b8
BUG: 1433506
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17015
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK

geo-rep: Remove unlink fop during rmdir

2017-04-17T05:15:20+00:00

Even though it is known to be 'RMDIR', os.unlink
was being tried and os.rmdir is issued upon receiving
EISDIR. It's unnecessary unlink call for 'RMDIR'.
Fixed the same.

Change-Id: I8dbb680ee2c7f0c32b7799b1ed5351b3621cb42a
BUG: 1441106
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17041
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK

geo-rep: Fix EBUSY traceback

2017-04-10T06:24:37+00:00

EBUSY was added to retry list of errno_wrap
without importing. Fixing the same.

Change-Id: Ide81a9ccc9b948a96265b6890da078b722b45d51
BUG: 1434018
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17011
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Aravinda VK

geo-rep: Improve worker log messages

2017-04-07T06:09:34+00:00

Monitor process expects worker to establish SSH Tunnel to slave node
and mount master volume locally with in 60 secs and acknowledge monitor
process by closing feedback fd. If something goes wrong and worker
does not close feedback fd with in 60 secs, monitor kills the worker.
But there was no clue in log message about the actual issue. This patch
adds log and indicates whether the worker is hung during SSH
or master mount.

Change-Id: Id08a12fa6f3bba1d4fe8036728dbc290e6c14c8c
BUG: 1261689
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/16997
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK

geo-rep: Retry on EBUSY

2017-04-07T06:08:31+00:00

Do not crash on EBUSY error. Add EBUSY
retry errno list. Crash only if the error
persists even after max retries.

Change-Id: Ia067ccc6547731f28f2a315d400705e616cbf662
BUG: 1434018
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/16924
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Aravinda VK 
CentOS-regression: Gluster Build System

geo-rep: Optionally allow access to mounts

2017-03-20T03:33:36+00:00

In order to improve debuggability, it is important
to have access to geo-rep master and slave mounts.
With the default behaviour, geo-rep lazy unmounts
the mounts after changing the current working
directory into the mount point. It also cleans
up the mount points. So only geo-rep worker has
the access and it becomes impossible to take the
client profile info and do any other client statck
analysis. Hence the following new config is being
introduced to allow access to mounts.

gluster vol geo-rep  :: \
config access_mount true

The default value of 'access_mount' is false.

Change-Id: I53dce4ea86a6ffc979c82f9330e8954327180ca3
BUG: 1433506
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/16912
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

build/packaging: Debian and Ubuntu don't have /usr/libexec

2017-03-13T14:18:07+00:00

GLUSTERFS_LIBEXECDIR is effectively hard-coded to /usr/libexec/glusterfs
in configure(.ac)

Debian-based distributions don't have a /usr/libexec/ directory

This issues is partially mitigated by the use of $libexecdir in
some of the Makefile.am files, but even so the incorrectly defined
GLUSTERFS_LIBEXECDIR results in various things such as gsyncd,
glusterfind, eventsd, etc., trying to invoke other scripts and
programs from a location that doesn't exist.

And once we correctly define GLUSTERFS_LIBEXECDIR, then we might as
well use it appropriatedly.

Change-Id: If5219cadc51ae316f7ba2e2831d739235c77902d
BUG: 1430841
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/16880
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Joe Julian 
Reviewed-by: Shyamsundar Ranganathan

geo-rep: Fix xsync crawl

2017-02-16T07:50:31+00:00

If stime is set to (0, 0) on master brick root, it
is expected to do complete sync ignoring the stime
set on sub directories. But while initializing the
stime variable for comparison, it was initailized
to (-1, 0) instead of (0, 0). Fixed the same.

The stime is set to (0, 0) with the 'reset-sync-time' option
while deleting session.

'gluster vol geo-rep master fedora1::slave delete reset-sync-time'

The scenario happens when geo-rep session is deleted as above and
for some reason the session is re-established with same slave volume
after deleting data on slave volume.

Change-Id: Ie5bc8f008dead637a09495adeef5577e2b33bc90
BUG: 1422760
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/16629
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Aravinda VK