glusterfs.git/geo-replication/src, branch v3.8rc1

geo-rep: Fix invalid disk size in gverify.sh

2016-03-01T07:57:20+00:00

Problem:
        Due to the wrong interpretation of disk size, gverify.sh script
exits in between with error "integer expression expected".
This error can be observed, only if gverify.sh is run standalone.

Solution:
        Fix the interpretation of disk size.

Also, verify that master and slave's gluster version are same.

Change-Id: Id095dfffd07a93a535a380f617ad215230979870
BUG: 1305839
Signed-off-by: Saravanakumar Arumugam 
Reviewed-on: http://review.gluster.org/13407
Smoke: Gluster Build System 
Reviewed-by: Aravinda VK 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kotresh HR 
CentOS-regression: Gluster Build System

geo-rep: Fix gsyncd prefix in gsec_create

2016-02-04T11:16:26+00:00

gsec_create script is generated after running ./configure

libexec dir was formed using $prefix/libexec, but in Debian based
distributions libexec dir is not present, instead they use lib
directory to store these scripts.

With this patch, full libexec path is fetched during ./configure.

BUG: 1162905
Change-Id: I9f47a38e6ab0027c7df6716136fbe0635e95a593
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/13298
Smoke: Gluster Build System 
Tested-by: Raghavendra Talur 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

glusterd/geo-rep: Adding ssh-port option for geo-rep create

2015-11-18T19:33:37+00:00

Geo-replication uses default ssh port 22 for setup.
i.e., to distribute ssh keys to slaves. In container
environments, custom port number might be used.
Hence to support custom port number for ssh, option
is provided in geo-rep create command to take the
same.

Change-Id: I0fb61959b1c085342b8e4c21ac4e076fba5462f1
BUG: 1276028
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12504
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Aravinda VK 
Reviewed-by: Venky Shankar

geo-rep: Make restrictive ssh keys optional

2015-11-09T13:26:39+00:00

In containerized environment where networking
configuration is "net=host", both host and
containers use the same IP. The validations
gsyncd shell and rsync to be the siblings
fails. Hence, for now, creating restrictive
ssh keys is made optional as follows.

If the argument 'container' is passed, it
will create non restrictive ssh keys else
restrictive ssh keys.

e.g.,
gluster system:: execute gsec_create container
     Creates non restrictive ssh keys.
gluster system:: execute gsec_create
     Creates restrictive ssh keys.

Change-Id: Ibed362f64b9b4c9931207f863a2da944c6bd1d66
BUG: 1276028
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12459
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Aravinda VK

core: use syscall wrappers instead of direct syscalls - miscellaneous

2015-10-28T20:38:42+00:00

various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.

If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.

Change-Id: I1f47820534c890a00b452fa61f7438eb2b3f667c
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/12276
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

geo-rep: Fix portability issues with NetBSD

2015-09-07T09:52:46+00:00

Fixes portability issues in gverify.sh and
libcxattr.py with NetBSD.

Change-Id: Idfaa6cf3815136e6a2343aab98d979b6ab451bbd
BUG: 1257847
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12088
Reviewed-by: Emmanuel Dreyfus 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Venky Shankar

geo-rep: Fix gsyncd failing to start on slave

2015-08-06T05:40:22+00:00

This is a regression introduced by 2ca6441.
The memory is freed while the caller expects
it be not. The patch fixes the same.

Change-Id: I76d95eef15b3f7af365b392f2426c8b0388254fc
BUG: 1222898
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11751
Reviewed-by: Saravanakumar Arumugam 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Venky Shankar

geo-replication: fix memory leak in gsyncd

2015-07-14T13:12:06+00:00

1. leak in str2argv() function:

char *strdup(const char *s);
The strdup() function returns a pointer to a new string which is a
duplicate of the  string  s. Memory for the new string is obtained
with malloc(3), and can be freed with free(3).

so when using strdup, user has to take care of freeing the memory
allocated by strdup library function.

2. leak in main() function:

str2argv() function calls calloc and allocates memory pointed to argv,
after return from str2argv() memory pointed to argv has to be cleaned
in main().

This patch is to fix 2 memory leaks mentioned above.

Change-Id: I6bf26101e0460a7324ac7bdb69905839688d4987
BUG: 1222898
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/10831
Tested-by: NetBSD Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Kotresh HR 
Reviewed-by: Venky Shankar

geo-rep: Fix add user in mountbroker user management

2015-06-26T12:42:08+00:00

The CLI 'gluster system:: execute mountbroker user  '
to set volumes associated with a user replaces existing user and associated
volumes upon setting with existing user. This patch fixes it by appending
the volumes if the user already exists.

It also introduces following CLI to remove volume for a corresponding user.

'gluster system:: execute mountbroker volumedel  '
: username
: comman separated list of volumes to delete

If it is the last volume to be deleted associated with the user,
it will delete the user as well as it doesn't make sense to keep
only user without volumes associated.

Change-Id: I49f4b9279954d9f5d34aca2dd8a69c6f4b87fd19
BUG: 1226223
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11385
Reviewed-by: darshan n 
Tested-by: NetBSD Build System 
Reviewed-by: Aravinda VK

geo-rep: Fix glusterd working directory

2015-06-25T06:54:30+00:00

Mountbroker setup in geo-replication requires
the script 'set_geo_rep_pem_keys.sh to be
run manually out of gluster context. Hence
the ${GLUSTERD_WORKDIR} is never set. So
getting glusterd working dir using 'gluster
system:: getwd'.

Change-Id: Ic2fe85e685016b383e38af0ea43c3f0628c16a32
BUG: 1235292
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11381
Tested-by: NetBSD Build System 
Reviewed-by: Aravinda VK