glusterfs.git/geo-replication/src, branch release-3.8-fb

build/packaging: Debian and Ubuntu don't have /usr/libexec

2017-03-21T19:04:27+00:00

GLUSTERFS_LIBEXECDIR is effectively hard-coded to /usr/libexec/glusterfs
in configure(.ac)

Debian-based distributions don't have a /usr/libexec/ directory

This issues is partially mitigated by the use of $libexecdir in
some of the Makefile.am files, but even so the incorrectly defined
GLUSTERFS_LIBEXECDIR results in various things such as gsyncd,
glusterfind, eventsd, etc., trying to invoke other scripts and
programs from a location that doesn't exist.

And once we correctly define GLUSTERFS_LIBEXECDIR, then we might as
well use it appropriatedly.

master change https://review.gluster.org/16880
master BZ: 1430841
release-3.10 change https://review.gluster.org/16881
release-3.10 BZ: 1430845

Change-Id: If5219cadc51ae316f7ba2e2831d739235c77902d
BUG: 1430845
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/16882
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Milind Changire

geo-rep: address potential leak of memory

2016-09-07T14:04:56+00:00

fix memory leak reported by clang analyzer:
gsyncd.c:411:17: warning: Potential leak of 
                 memory pointed to by 'argv'
                 in main()



>BUG: 1332419
>Signed-off-by: Prasanna Kumar Kalever 
>Reviewed-on: http://review.gluster.org/14151
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Smoke: Gluster Build System 
>Reviewed-by: Kotresh HR 

Change-Id: I179fb1c095cf4d331b5910df6388dc724cb4ac96
BUG: 1332424
Signed-off-by: Prasanna Kumar Kalever 
Change-Id: Id60c851c5462868630349dd4707fd94f1b83e488
Reviewed-on: http://review.gluster.org/15377
Tested-by: Atin Mukherjee 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
Reviewed-by: Prasanna Kumar Kalever 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System

core: assorted typos and spelling mistakes reported by Debian lintian

2016-05-18T13:55:02+00:00

Also missing bang (!) in #!/bin/bash in shell scripts.

Backport of
> http://review.gluster.org/#/c/14398/
> BUG: 1336793
> Change-Id: I567a4be8f0f31f6285550f243fe802895f6bc43b

Change-Id: I003554daede9937a41010e085c74e77957c5c608
BUG: 1336794
Reported-by: Patrick Matthäi 
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/14400
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System

geo-rep: Fix invalid disk size in gverify.sh

2016-03-01T07:57:20+00:00

Problem:
        Due to the wrong interpretation of disk size, gverify.sh script
exits in between with error "integer expression expected".
This error can be observed, only if gverify.sh is run standalone.

Solution:
        Fix the interpretation of disk size.

Also, verify that master and slave's gluster version are same.

Change-Id: Id095dfffd07a93a535a380f617ad215230979870
BUG: 1305839
Signed-off-by: Saravanakumar Arumugam 
Reviewed-on: http://review.gluster.org/13407
Smoke: Gluster Build System 
Reviewed-by: Aravinda VK 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kotresh HR 
CentOS-regression: Gluster Build System

geo-rep: Fix gsyncd prefix in gsec_create

2016-02-04T11:16:26+00:00

gsec_create script is generated after running ./configure

libexec dir was formed using $prefix/libexec, but in Debian based
distributions libexec dir is not present, instead they use lib
directory to store these scripts.

With this patch, full libexec path is fetched during ./configure.

BUG: 1162905
Change-Id: I9f47a38e6ab0027c7df6716136fbe0635e95a593
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/13298
Smoke: Gluster Build System 
Tested-by: Raghavendra Talur 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

glusterd/geo-rep: Adding ssh-port option for geo-rep create

2015-11-18T19:33:37+00:00

Geo-replication uses default ssh port 22 for setup.
i.e., to distribute ssh keys to slaves. In container
environments, custom port number might be used.
Hence to support custom port number for ssh, option
is provided in geo-rep create command to take the
same.

Change-Id: I0fb61959b1c085342b8e4c21ac4e076fba5462f1
BUG: 1276028
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12504
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Aravinda VK 
Reviewed-by: Venky Shankar

geo-rep: Make restrictive ssh keys optional

2015-11-09T13:26:39+00:00

In containerized environment where networking
configuration is "net=host", both host and
containers use the same IP. The validations
gsyncd shell and rsync to be the siblings
fails. Hence, for now, creating restrictive
ssh keys is made optional as follows.

If the argument 'container' is passed, it
will create non restrictive ssh keys else
restrictive ssh keys.

e.g.,
gluster system:: execute gsec_create container
     Creates non restrictive ssh keys.
gluster system:: execute gsec_create
     Creates restrictive ssh keys.

Change-Id: Ibed362f64b9b4c9931207f863a2da944c6bd1d66
BUG: 1276028
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12459
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Aravinda VK

core: use syscall wrappers instead of direct syscalls - miscellaneous

2015-10-28T20:38:42+00:00

various xlators and other components are invoking system calls
directly instead of using the libglusterfs/syscall.[ch] wrappers.

If not using the system call wrappers there should be a comment
in the source explaining why the wrapper isn't used.

Change-Id: I1f47820534c890a00b452fa61f7438eb2b3f667c
BUG: 1267967
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/12276
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

geo-rep: Fix portability issues with NetBSD

2015-09-07T09:52:46+00:00

Fixes portability issues in gverify.sh and
libcxattr.py with NetBSD.

Change-Id: Idfaa6cf3815136e6a2343aab98d979b6ab451bbd
BUG: 1257847
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12088
Reviewed-by: Emmanuel Dreyfus 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Venky Shankar

geo-rep: Fix gsyncd failing to start on slave

2015-08-06T05:40:22+00:00

This is a regression introduced by 2ca6441.
The memory is freed while the caller expects
it be not. The patch fixes the same.

Change-Id: I76d95eef15b3f7af365b392f2426c8b0388254fc
BUG: 1222898
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11751
Reviewed-by: Saravanakumar Arumugam 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Milind Changire 
Reviewed-by: Venky Shankar