glusterfs.git/extras, branch v3.7.7

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

scripts: prevent running 'showmount' from the start/post hook script

2016-01-14T11:34:40+00:00

The 31ganesha-start.sh hook script tries to run 'showmount' to see if
the volume that is getting started should get exported by NFS-Ganesha.
It was reported that this caused the 'gluster volume start ...' command
to hang in case rpcbind is not running.

Instead of running 'showmount', we can use DBus to contact NFS-Ganesha
directly, and request the available exports. This will immediately fail
in case NFS-Ganesha is not running.

Cherry picked from commit 2b2294d2a4ef221fccb6eb9f74e9b7dc233b9f1d:
> BUG: 1294446
> Change-Id: I3aba1f86fead67116ca5adb1864a8be626c334fa
> Reported-by: Jeff Darcy 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/13098
> Tested-by: Raghavendra Talur 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Kaleb KEITHLEY 

BUG: 1297862
Change-Id: I3aba1f86fead67116ca5adb1864a8be626c334fa
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/13230
Tested-by: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

extras: fix deprecation warining in checkpatch.pl

2016-01-10T10:58:42+00:00

Left braces in patterns need to be escaped.
Otherwise, for perl >= 5.16, we get a warning:
"Unescaped left brace in regex is deprecated, passed through in regex;"
This patch fixes the relevant braces.

Hence perl -c ./examples/checkpatch.pl is clean again.

> Change-Id: I938c9c262239f53de57d30a2cff7030f22e63dc1
> BUG: 1198849
> Signed-off-by: Michael Adam 
> Reviewed-on: http://review.gluster.org/12828
> Reviewed-by: Anoop C S 
> Reviewed-by: Niels de Vos 
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 

(cherry picked from commit 2e9376a2f1b992d3649dd1d5a8e844b4c031ef3c)

Change-Id: I2a38e8e2d0652af519bf139ec046edc42c5e5356
BUG: 1290534
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/12942
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Niels de Vos

hook-scripts: fix S30Samba scripts on systemd systems

2015-12-19T05:04:53+00:00

/etc/init.d/smb does not exist on systemd systems.
Using "service smb " is the portable way.
It calls init scripts on sysv systems, and redirects
to systemctl on systemd systems.

> Change-Id: I7146c9998a51d8b170d3321f3477e92704ae7615
> BUG: 1290604
> Signed-off-by: Michael Adam 
> Reviewed-on: http://review.gluster.org/12945
> Tested-by: Gluster Build System 
> Reviewed-by: Anoop C S 
> Tested-by: NetBSD Build System 
> Reviewed-by: Niels de Vos 

(cherry picked from commit ce3ff7e328483dffdae6ae2914924bc2380db67e)

Change-Id: Ied6b5fe330f8d29df10a9aea1809be5c5f0c8a5e
BUG: 1292755
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/13000
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph

hook-scripts: don't let ctdb script change samba config

2015-12-18T09:17:12+00:00

There are several reasons why the behaviour in
the hook scripts was bad:

1. A samba installation is clustered or non-clustered.
   That does not change because of the availability
   of the CTDB lock-volume. If the lock-volume is not
   available (and hence CTDB is not available or not
   healthy), then Samba won't be operational. But turning
   it into a non-clustered Samba-installation can in
   the worst case lead to data corruption if clients
   manage to access the same files (on share volumes).
   Hence 'clustering = yes/no' in Samba's config should
   not be touched.

   In particular, Samba should not be stopped/started by
   the hook script. If needed, then ctdb will take care
   of it.

2. Changing the idmap configuration is potentially
   dangerous as well. In particular the used tdb2
   backend is legacy nowadays and should not be used
   any more in new installs. (I stems from the times
   when ctdb could not host persistent databases.)
   Changing the idmap can result in loss of access
   to files or in giving access to files where it is
   not intended.

3. The pattern used for detecting need for change is
   fragile. It may or may not play well possible
   manual changes to smb.conf.

This change removes the parts that change the smb.conf
file and start or stop Samba from the S29CTDB* hook scripts.

> Change-Id: I72f7aabafa8f089da4531fca2572a72c22825bcc
> BUG: 1290151
> Signed-off-by: Michael Adam 
> Reviewed-on: http://review.gluster.org/12930
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra Talur 

(cherry picked from commit 27c16d6da82876a689dfba53b8d45c3a3a657954)

Change-Id: Ie1f787cebb5f6da1a658f7dead879fa854901ef5
BUG: 1292254
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/12986
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur

glusterd: disable ping timer b/w glusterd and make epoll thread count to 1

2015-12-03T19:22:29+00:00

This patch is backport of: http://review.gluster.org/#/c/12874/

Currently glusterd is crashing when enable/disable heal and i/o is in
progress on the fuse mount.

This is because of by default multi thread epoll in glusterd is 2.
Workaround is to make epoll thread to 1 and set ping-timeout to 0

  >> Change-Id: Ifbe9b43a361c5409b707539f0ee831c610a5c36b 
  >> BUG: 1288059 
  >> Signed-off-by: Gaurav Kumar Garg 

Change-Id: Ifbe9b43a361c5409b707539f0ee831c610a5c36b
BUG: 1288060
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/12875
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Vijay Bellur

glusterd/geo-rep: Adding ssh-port option for geo-rep create

2015-11-23T19:22:28+00:00

Geo-replication uses default ssh port 22 for setup.
i.e., to distribute ssh keys to slaves. In container
environments, custom port number might be used.
Hence to support custom port number for ssh, option
is provided in geo-rep create command to take the
same.

Change-Id: I0fb61959b1c085342b8e4c21ac4e076fba5462f1
BUG: 1283060
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12504
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Aravinda VK 
Reviewed-by: Venky Shankar 
 (cherry picked from commit 5bb3c521431cc27b2826acd889bffb2f90ae7f73)
Reviewed-on: http://review.gluster.org/12652
Reviewed-by: Vijay Bellur

glusterd.service: Ensure rpcbind is started before glusterd

2015-11-20T04:20:24+00:00

Having the rpcbind.service under the `After` option only ensures that
glusterd.service is started after rpcbind.service if both are
enabled/started at the same time. It doesn't ensure that starting
glusterd.service will start rpcbind.service.

The systemd.unit(5) man page suggests to use both the `Requires` and
`After` options to ensure that rpcbind is started before glusterd,
whenever glusterd is started.

Cherry picked from commit 23440a73bc348bbc3bb43ec397f0639ee45865fc:
> BUG: 1282915
> Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
> Signed-off-by: Kaushal M 
> Reviewed-on: http://review.gluster.org/12605
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Anand Nekkunti 
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 

Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
BUG: 1283142
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12640
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

extras/hooks: Fix parsing of args in S30samba-set.sh

2015-11-15T11:15:26+00:00

bug: 1243041
Change-Id: I75756f44757a144b0ed229fcc0e29a273fc75886
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/11669
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

extras: Exit with SUCCESS if no processes to stop

2015-11-12T07:27:47+00:00

This script might be executed even when there are no
valid processes running to be stopped. In this scenario,
the script should return with SUCCESS

Change-Id: Ia293214a4b5052bc4bef9769f197f7b05c55ffe9
BUG: 1279776
Signed-off-by: Shubhendu Tripathi 
Reviewed-on: http://review.gluster.org/11739
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12564
Tested-by: Ramesh N 
Reviewed-by: Aravinda VK