glusterfs.git/extras, branch release-3.5

glusterd.service: Ensure rpcbind is started before glusterd

2015-12-12T10:01:53+00:00

Having the rpcbind.service under the `After` option only ensures that
glusterd.service is started after rpcbind.service if both are
enabled/started at the same time. It doesn't ensure that starting
glusterd.service will start rpcbind.service.

The systemd.unit(5) man page suggests to use both the `Requires` and
`After` options to ensure that rpcbind is started before glusterd,
whenever glusterd is started.

Cherry picked from commit 23440a73bc348bbc3bb43ec397f0639ee45865fc:
> BUG: 1282915
> Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
> Signed-off-by: Kaushal M 
> Reviewed-on: http://review.gluster.org/12605
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Anand Nekkunti 
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 

Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
BUG: 1283542
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12659
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System

core: fix Ubuntu code audit (cppcheck) results

2014-11-26T08:30:12+00:00

See http://review.gluster.org/#/c/7583/ BZ 1086460

AFAICT these are false positives:

[geo-replication/src/gsyncd.c:99]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:395]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1200]: (error) Possible null pointer dereference: fde

Program exits, resource leak not an issue
[extras/geo-rep/gsync-sync-gfid.c:105]: (error) Resource leak: fp

Test program:
[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.

Not built:
[xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv

The remainder are fixed with this change-set:

[heal/src/glfs-heal.c:357]: (error) Possible null pointer dereference: remote_subvol
[libglusterfs/src/xlator.c:648]: (error) Uninitialized variable: gfid
[libglusterfs/src/xlator.c:649]: (error) Uninitialized variable: gfid
[xlators/cluster/afr/src/afr-inode-write.c:469]: (error) Possible null pointer dereference: frame
[xlators/cluster/afr/src/afr-self-heal-common.c:1704]: (error) Possible null pointer dereference: local
[xlators/cluster/dht/src/dht-rebalance.c:1643]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4963]: (error) Possible null pointer dereference: local
[xlators/features/changelog/src/changelog.c:1464]: (error) Possible null pointer dereference: priv
[xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1656]: (error) Possible null pointer dereference: command
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:914]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:998]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:248]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-store.c:1332]: (error) Possible null pointer dereference: handle
[xlators/mgmt/glusterd/src/glusterd-utils.c:4706]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:5613]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:6342]: (error) Possible null pointer dereference: path_tokens
[xlators/mgmt/glusterd/src/glusterd-utils.c:6343]: (error) Possible null pointer dereference: path_tokens
[xlators/mount/fuse/src/fuse-bridge.c:4591]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:3004]: (error) Possible null pointer dereference: state
[xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it).
[xlators/performance/quick-read/src/quick-read.c:585]: (error) Possible null pointer dereference: iobuf

Rerunning cppcheck afterwards:

As before, test program:
[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.

As before, believed to be false positive:
[geo-replication/src/gsyncd.c:99]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:395]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1200]: (error) Possible null pointer dereference: fde

As before, not built:
[xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv

False positive after fix:
[heal/src/glfs-heal.c:356]: (error) Possible null pointer dereference: remote_subvol
[xlators/cluster/stripe/src/stripe.c:4963]: (error) Possible null pointer dereference: local

Change-Id: Ib3029d3223f5a13e2ac386a527d64d5ffe3ecb90
BUG: 1092037
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/7605
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

logrotate: gluster logrotate config should not be global

2014-10-30T09:19:14+00:00

Issue : Previously glusterfs logrotate config file pollutes
global config. So moved the directives inside the curly braces,
 so they don't pollute the global config state.

Change-Id: I8836893dfcdf457d9c5d766612d687bfce64e2ae
BUG: 1126801
"Signed-off-by: Lalatendu Mohanty "
"Reviewed-on: http://review.gluster.org/8994"
"Reviewed-by: Niels de Vos "
"Tested-by: Gluster Build System "
(cherry picked from commit a5d73daabf6df95bc73b186d92f3e2d1239a6f8a)
Signed-off-by: Lalatendu Mohanty 
Reviewed-on: http://review.gluster.org/9001
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

rpms: Add quota upgrade scripts to rpms

2014-04-10T15:15:50+00:00

Also replace /tmp/quota-config-backup with /var/tmp/glusterfs/quota-config-backup
in doc and upgrade scripts.

Change-Id: I289662300d32f75e2fc6e789037c3224054a38a5
BUG: 969461
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/7401
Reviewed-by: Humble Devassy Chirammal 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijay Bellur

geo-rep: fix pattern matching in upgrade scripts.

2014-04-04T17:07:13+00:00

Change-Id: I9ceed333a5416f06537e6ea14055c0971ead9362
BUG: 847839
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/7327
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/quota: Add upgrade scripts to distribution tarball.

2014-03-22T12:26:36+00:00

Adds scripts to migrate quota limits from v3.4.0 to v3.5.0 to
distribution tarball.

Change-Id: Ia424cb8174fae886bedc5596752200c2f721064b
BUG: 969461
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/7312
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

build: Add missing rpmbuild/BUILD dir for CentOS 5.x

2014-03-19T16:43:02+00:00

The rpmbuild/BUILD directory isn't created automatically
by the build system on CentOS 5.x. This 1-line patch
adds its creation to the build process.

Backport of http://review.gluster.org/#/c/7175/

BUG: 1071504
Change-Id: I2cd6cab3a84aa8e163ee75b69f7609c74a163e78
Signed-off-by: Justin Clift 
Reviewed-on: http://review.gluster.org/7298
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

Use libglusterfs wrapper to make setxattr portable

2014-02-18T14:46:23+00:00

BUG: 764655
Change-Id: I332922521bef5684f18d5f7b226cb36d5303ae47
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/6982
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/7008
Reviewed-by: Pranith Kumar Karampuri

spec: geo-rep: Include hooks and upgrade scripts

2014-02-11T02:29:27+00:00

Added hook script S56glusterd-geo-rep-create-post.sh to
%{_sharedstatedir}/glusterd/hooks/1/gsync-create/post/ and upgrade
scripts added to %{_datadir}/glusterfs/scripts/

BUG: 1036539
Change-Id: I53f6984671feecbc2890fed59d8fc7f4545c50a3
Reviewed-on: http://review.gluster.org/6926
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/6927
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/quota: Make grep search more accurately

2014-01-29T06:41:39+00:00

The hook script was searching the info file for "features.quota" to know the
quota status (enable/disabled). When features.quota-deem-statfs the grep is not
accurate. Fixed this issue.

Change-Id: I4104a93c1c1e0ac9fd7ef7bfef993425ab50e651
BUG: 969461
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/6380
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/6839