glusterfs.git/extras/hook-scripts, branch v3.7.7

scripts: prevent running 'showmount' from the start/post hook script

2016-01-14T11:34:40+00:00

The 31ganesha-start.sh hook script tries to run 'showmount' to see if
the volume that is getting started should get exported by NFS-Ganesha.
It was reported that this caused the 'gluster volume start ...' command
to hang in case rpcbind is not running.

Instead of running 'showmount', we can use DBus to contact NFS-Ganesha
directly, and request the available exports. This will immediately fail
in case NFS-Ganesha is not running.

Cherry picked from commit 2b2294d2a4ef221fccb6eb9f74e9b7dc233b9f1d:
> BUG: 1294446
> Change-Id: I3aba1f86fead67116ca5adb1864a8be626c334fa
> Reported-by: Jeff Darcy 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/13098
> Tested-by: Raghavendra Talur 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Kaleb KEITHLEY 

BUG: 1297862
Change-Id: I3aba1f86fead67116ca5adb1864a8be626c334fa
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/13230
Tested-by: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

hook-scripts: fix S30Samba scripts on systemd systems

2015-12-19T05:04:53+00:00

/etc/init.d/smb does not exist on systemd systems.
Using "service smb " is the portable way.
It calls init scripts on sysv systems, and redirects
to systemctl on systemd systems.

> Change-Id: I7146c9998a51d8b170d3321f3477e92704ae7615
> BUG: 1290604
> Signed-off-by: Michael Adam 
> Reviewed-on: http://review.gluster.org/12945
> Tested-by: Gluster Build System 
> Reviewed-by: Anoop C S 
> Tested-by: NetBSD Build System 
> Reviewed-by: Niels de Vos 

(cherry picked from commit ce3ff7e328483dffdae6ae2914924bc2380db67e)

Change-Id: Ied6b5fe330f8d29df10a9aea1809be5c5f0c8a5e
BUG: 1292755
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/13000
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph

hook-scripts: don't let ctdb script change samba config

2015-12-18T09:17:12+00:00

There are several reasons why the behaviour in
the hook scripts was bad:

1. A samba installation is clustered or non-clustered.
   That does not change because of the availability
   of the CTDB lock-volume. If the lock-volume is not
   available (and hence CTDB is not available or not
   healthy), then Samba won't be operational. But turning
   it into a non-clustered Samba-installation can in
   the worst case lead to data corruption if clients
   manage to access the same files (on share volumes).
   Hence 'clustering = yes/no' in Samba's config should
   not be touched.

   In particular, Samba should not be stopped/started by
   the hook script. If needed, then ctdb will take care
   of it.

2. Changing the idmap configuration is potentially
   dangerous as well. In particular the used tdb2
   backend is legacy nowadays and should not be used
   any more in new installs. (I stems from the times
   when ctdb could not host persistent databases.)
   Changing the idmap can result in loss of access
   to files or in giving access to files where it is
   not intended.

3. The pattern used for detecting need for change is
   fragile. It may or may not play well possible
   manual changes to smb.conf.

This change removes the parts that change the smb.conf
file and start or stop Samba from the S29CTDB* hook scripts.

> Change-Id: I72f7aabafa8f089da4531fca2572a72c22825bcc
> BUG: 1290151
> Signed-off-by: Michael Adam 
> Reviewed-on: http://review.gluster.org/12930
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra Talur 

(cherry picked from commit 27c16d6da82876a689dfba53b8d45c3a3a657954)

Change-Id: Ie1f787cebb5f6da1a658f7dead879fa854901ef5
BUG: 1292254
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/12986
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur

glusterd/geo-rep: Adding ssh-port option for geo-rep create

2015-11-23T19:22:28+00:00

Geo-replication uses default ssh port 22 for setup.
i.e., to distribute ssh keys to slaves. In container
environments, custom port number might be used.
Hence to support custom port number for ssh, option
is provided in geo-rep create command to take the
same.

Change-Id: I0fb61959b1c085342b8e4c21ac4e076fba5462f1
BUG: 1283060
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/12504
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Aravinda VK 
Reviewed-by: Venky Shankar 
 (cherry picked from commit 5bb3c521431cc27b2826acd889bffb2f90ae7f73)
Reviewed-on: http://review.gluster.org/12652
Reviewed-by: Vijay Bellur

extras/hooks: Fix parsing of args in S30samba-set.sh

2015-11-15T11:15:26+00:00

bug: 1243041
Change-Id: I75756f44757a144b0ed229fcc0e29a273fc75886
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/11669
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

extras/hookscripts : introducing additional check in S31ganesha-start.sh

2015-09-24T08:53:41+00:00

New export file with default configuration will be created for a volume
when it is started again. This patch will create new export file only
when it is not present. This change is required for scenarios such as
snapshot restore , node reboot etc.

Change-Id: I34123911f176dcb29d5c016aa097af3a3b2c727b
BUG: 1261444
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/12219
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos

rpm: include required directory for glusterfind

2015-08-25T15:50:55+00:00

The directory was marked as %ghost, which causes the following
installation failure:

  Error unpacking rpm package glusterfs-server-3.8dev-0.446.git45e13fe.el7.centos.x86_64
  error: unpacking of archive failed on file /var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py;5581f20e: cpio: open

Also, *all* Python files should be part of the RPM package. This
includes generated .pyc and .pyo files.

BUG: 1256307
Change-Id: Iee74905b101912c4a845257742c470c3fe42ce2a
Signed-off-by: Niels de Vos 
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/11298
Reviewed-on: http://review.gluster.org/12000
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

glusterd/shared_storage: Use /var/lib/glusterd/ss_brick as shared storage's brick

2015-07-07T05:55:48+00:00

     Backport of http://review.gluster.org/#/c/11533/

The brick path we use to create shared storage is
/var/run/gluster/ss_brick.

The problem with using this brick path is /var/run/gluster
is a tmpfs and all the brick/shared storage data will be wiped
off when the node restarts. Hence using /var/lib/glusterd/ss_brick
as the brick path for shared storage volume as this brick and
the shared storage volume is internally created by us (albeit on
user's request), and contains only internal state data and no user data.

Change-Id: I808d1aa3e204a5d2022086d23bdbfdd44a2cfb1c
BUG: 1230399
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/11534
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph

NFS-Ganesha : Unexport fails after S31ganesha-start script is run

2015-07-02T14:51:11+00:00

The dbus-send script extracts the export ID from the export config
file. It expects the export ID to be written in a particular format.
The post-phase hook-script created the export file in a different
format, and the dbus-send never gets the correct export ID because
of this. Fixing the issue by replacing the write_conf function in the
S31ganesha-start hook-script. Also, NFS-Ganesha service stops when
dbus signal is sent more than once on the same export. Consecutive
start/stop operations creates problems. Fixing all the issues at once.

Change-Id: I1306c68e2bc9abd91be1b7f1558c93060cc9c98d
BUG: 1238752
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/11511

NFS-Ganesha : Exporting volume fails

2015-06-30T10:01:52+00:00

Due to a recent fix, the dbus-send.sh looked
for a .export_added file even before it was
created. This resulted in the ganesha.enable
option failing consistently. Fixing it.

This is a backport of the fix in master,
http://review.gluster.org/#/c/11456/

Change-Id: I9658ff8eced405eed7a26fab334f7172171133e8
BUG: 1236933
Signed-off-by: Meghana 
Reviewed-on: http://review.gluster.org/11458
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Niels de Vos