glusterfs.git/extras/hook-scripts/set, branch v3.13.0beta

extras/hooks: Fix getopt usage

2017-10-30T15:49:02+00:00

`getopt` does not have an optional argument as '-name'. It should
be either '-n' or '--name'(see man getopt(1)). This wrong usage
resulted in setting the script name as 'ame' instead of $PROGNAME
in most of the hook-scripts.

Additionally the following line from DESCRIPTION given for `getopt`
shell command expects short options for almost every kind of usage
mentioned in SYNOPSIS:

. . .
If  no  '-o'  or '--options' option is found in the first part, the
first parameter of the second part is used as the short options string.
. . .

Refer http://man7.org/linux/man-pages/man1/getopt.1.html for more
clarity on its usage.

Change-Id: I95baf5fa8c99025e66b2d83656dd838d4f6048ce
BUG: 1503983
Signed-off-by: Anoop C S

extras/hooks: Fix errors reported via shellcheck utility

2017-10-18T14:27:41+00:00

Change-Id: I217c6b2a39955f1709bb3452b00d33c2dcb60faa
BUG: 1500649
Signed-off-by: Anoop C S

scripts: invalid test(1) in extras/S32gluster_enable_shared_storage.sh

2017-08-01T17:41:25+00:00

test(1) man pages says -eq is for INTEGER compares, and = is for
string compares.

Also note the comment that -a and -o are ambiguous and to use
 test && test or test || test instead.

This bug has existed since 2015! (yikes)

Found while testing localtime logging and running glusterd in the
foreground.

Change-Id: Ia544f7295e247b981504d085ebc4c533ab60ba84
BUG: 1476785
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/17925
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
CentOS-regression: Gluster Build System

build: use 'make install' to install the hook scripts

2015-12-26T17:31:24+00:00

The installation should be the same on all distributions, and doing
manual installation of files in the .spec is very ugly. This change adds
the rules so that 'make install' places the hook scripts in the right
location.

Also, the hook script(s) for NFS-Ganesha should be part of the
glusterfs-ganesha sub-package and got moved there.

BUG: 1174765
Change-Id: Iba25a7a5112c7d40db4c10ff4a5ac7a5fb4f7c4e
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/13072
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

hook-scripts: fix S30Samba scripts on systemd systems

2015-12-17T12:11:36+00:00

/etc/init.d/smb does not exist on systemd systems.
Using "service smb " is the portable way.
It calls init scripts on sysv systems, and redirects
to systemctl on systemd systems.

Change-Id: I7146c9998a51d8b170d3321f3477e92704ae7615
BUG: 1290604
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/12945
Tested-by: Gluster Build System 
Reviewed-by: Anoop C S 
Tested-by: NetBSD Build System 
Reviewed-by: Niels de Vos

extras/hooks: Fix parsing of args in S30samba-set.sh

2015-11-16T13:41:15+00:00

Change-Id: I75756f44757a144b0ed229fcc0e29a273fc75886
BUG: 1242892
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/11668
Tested-by: NetBSD Build System 
Reviewed-by: Niels de Vos

extra: "enable-shared-storage" key should create shared-storage

2015-07-13T10:25:38+00:00

Currently while creating shared storage it accept only
"cluster.enable-shared-storage" key. It should also
accept "enable-shared-storage" key.

Change-Id: I4c68782f4b7927ec8cd725e411b0b9db17d9c48d
BUG: 1238224
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/11491
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Avra Sengupta

glusterd/shared_storage: Use /var/lib/glusterd/ss_brick as shared storage's brick

2015-07-07T05:52:44+00:00

The brick path we use to create shared storage is
/var/run/gluster/ss_brick.

The problem with using this brick path is /var/run/gluster
is a tmpfs and all the brick/shared storage data will be wiped
off when the node restarts. Hence using /var/lib/glusterd/ss_brick
as the brick path for shared storage volume as this brick and
the shared storage volume is internally created by us (albeit on
user's request), and contains only internal state data and no user data.

Change-Id: I808d1aa3e204a5d2022086d23bdbfdd44a2cfb1c
BUG: 1218573
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/11533
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Niels de Vos 
Reviewed-by: Rajesh Joseph

gluster/shared_storage: Add/Remove shared storage from /etc/fstab during enable/disable

2015-06-22T08:56:59+00:00

While creating/deleting shared storage volume, add/remove the shared storage
entry from /etc/fstab, so as to ensure availability of the shared storage,
even after a node reboot

Change-Id: Ib9edc8fd02c74a677062ca53ffd10be997b056c6
BUG: 1231876
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/11272
Reviewed-by: Atin Mukherjee 
Tested-by: NetBSD Build System 
Reviewed-by: Rajesh Joseph

NFS-Ganesha: Automatically export vol that was exported before vol restart

2015-06-16T12:50:14+00:00

Consider a volume that is exported via NFS-Ganesha. Stopping this
volume will automatically unexport the volume. Starting this volume
should automatically export it. Although the logic was already there,
there was a bug in it. Fixing the same by introducing a hook script.

Also with the new CLI options, the hook script S31ganesha-set.sh
is no longer required. Hence, removing the same.
Adding a comment to tell the user that one of the CLI
commands will take a few minutes to complete.

Change-Id: Ibff769ca04fef0c2a129c83fe31fc9c869350e8d
BUG: 1231738
Signed-off-by: Meghana Madhusudhan 
Reviewed-on: http://review.gluster.org/11247
Reviewed-by: soumya k 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY