glusterfs.git/extras/ganesha, branch v3.7.9

nfs-ganesha: pcs cluster setup needs '--name' option

2016-03-04T02:11:14+00:00

Even on fedora machines (on f22, f23), pcs cluster setup CLI
expects '--name' to be provided. This patch addresses the same.

Change-Id: Id33c8bbdc33955dd54729b10c720f4fa646f7e8c
BUG: 1314204
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/13590
Smoke: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
NetBSD-regression: NetBSD Build System

ganesha: Read export_id on each node while performing refresh-config

2016-02-28T20:14:35+00:00

As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1309238#c1,
there could be cases which shall result in having different ExportIDs
for the same volume on each node forming the ganesha cluster.

Hence during refresh-config, it is necessary to read the ExportID on
each of those nodes and re-export that volume with the same ID.

Change-Id: I44058352fe977ccc649d378da3b68bbfb992fcd7
BUG: 1309238
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/13459
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

common-ha: reliable grace using pacemaker notify actions

2016-02-26T11:00:38+00:00

Using *-dead_ip-1 resources to track on which nodes the ganesha.nfsd
had died was found to be unreliable.

Running `pcs status` in the ganesha_grace monitor action was seen to
time out during failover; the HA devs opined that it was, generally,
not a good idea to run `pcs status` in a monitor action in any event.
They suggested using the notify feature, where the resources on all
the nodes are notified when a clone resource agent dies.

This change adds a notify action to the ganesha_grace RA. The ganesha_mon
RA monitors its ganesha.nfsd daemon. While the daemon is running, it
creates two attributes: ganesha-active and grace-active. When the daemon
stops for any reason, the attributes are deleted. Deleting the
ganesha-active attribute triggers the failover of the virtual IP (the
IPaddr RA) to another node where ganesha.nfsd is still running. The
ganesha_grace RA monitors the grace-active attribute. When the
grace-active attibute is deleted, the ganesha_grace RA stops, and will
not restart. This triggers pacemaker to trigger the notify action in
the ganesha_grace RAs on the other nodes in the cluster; which send a
DBUS message to their ganesha.nfsd.

(N.B. grace-active is a bit of a misnomer. while the grace-active
attribute exists, everything is normal and healthy. Deleting the
attribute triggers putting the surviving ganesha.nfsds into GRACE.)

To ensure that the remaining/surviving ganesha.nfsds are put into
NFS-GRACE before the IPaddr (virtual IP) fails over there is a short
delay (sleep) between deleting the grace-active attribute and the
ganesha-active attribute. To summarize:
  1. on node 2 ganesha_mon:monitor notices that ganesha.nfsd has died
  2. on node 2 ganesha_mon:monitor deletes its grace-active attribute
  3. on node 2 ganesha_grace:monitor notices that grace-active is gone
     and returns OCF_ERR_GENERIC, a.k.a. new error. When pacemaker
     tries to (re)start ganesha_grace, its start action will return
     OCF_NOT_RUNNING, a.k.a. known error, don't attempt further
     restarts.
  4. on nodes 1, 3, etc., ganesha_grace:notify receives a post-stop
     notification indicating that node 2 is gone, and sends a DBUS
     message to its ganesha.nfsd putting it into NFS-GRACE.
  5. on node 2 ganesha_mon:monitor waits a short period, then deletes
     its ganesha-active attribute. This triggers the IPaddr (virt IP)
     failover according to constraint location rules.

ganesha_nfsd modified to run for the duration, start action is invoked
to setup the /var/lib/nfs symlink, stop action is invoked to restore it.
ganesha-ha.sh modified accordingly to create it as a clone resource.

Change-Id: Iad60b0c5222bbd55ef95c8b8f955e791caa3ffd0
BUG: 1290865
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12964
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

common-ha: Corrected refresh-config output parsing

2015-11-06T12:35:01+00:00

>>>> Sample program with the earlier changes -
output=$(dbus-send --print-reply --system \
--dest=org.ganesha.nfsd /org/ganesha/nfsd/ExportMgr \
org.ganesha.nfsd.exportmgr.RemoveExport uint16:5 2>&1\
  | grep -v "^method return")
ret=$?
echo "${output}"
echo $ret
sleep 1
output=$(dbus-send --system --dest=org.ganesha.nfsd \
/org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.AddExport \
string:/usr/etc/ganesha/exports/export.vol3.conf \
string:"EXPORT(Path=/vol3)" 2>&1  | grep -v "^method return")
ret=$?
echo "${output}"
echo $ret

Output:

1

1

Even if the command was successfully executed, 'grep -v' has
filtered out the output.

>>>> Sample program with the current changes -

output=$(dbus-send --print-reply --system --dest=org.ganesha.nfsd \
/org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.RemoveExport\
 uint16:5 2>&1)
ret=$?
echo "${output}"
echo $ret
sleep 1
output=$(dbus-send --print-reply --system --dest=org.ganesha.nfsd \
/org/ganesha/nfsd/ExportMgr org.ganesha.nfsd.exportmgr.AddExport \
string:/usr/etc/ganesha/exports/export.vol3.conf \
string:"EXPORT(Path=/vol3)" 2>&1)
ret=$?
echo "${output}"
echo $ret

Output:
method return sender=:1.155 -> dest=:1.174 reply_serial=2
0
method return sender=:1.155 -> dest=:1.175 reply_serial=2
   string "1 exports added"
0

Change-Id: If9a38e825b2c1a87101de303f9494a0769a9e897
BUG: 1254494
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/12439
Tested-by: NetBSD Build System 
Reviewed-by: jiffin tony Thottan 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

common-ha: distribution neutral location of config files

2015-09-29T18:18:59+00:00

work on systems with config files in directories other than
/etc/sysconfig.

BUG: 1251821
Change-Id: Ie8e0a330810430cbc92499181ab60d79ea43c8f1
Signed-off-by: Joe Julian 
Reviewed-on: http://review.gluster.org/12132
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: Kaleb KEITHLEY

common-ha: refresh-config output includes dbus "method return" msg

2015-09-24T23:36:01+00:00

filter out extraneous text from dbus-send

Change-Id: If8467f8e756584027d36559960fd691dcaf98993
BUG: 1262881
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/12174
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: soumya k

CommonHA: Fix the path of 'systemctl' cmd

2015-09-03T08:47:30+00:00

'systemctl' command path should be '/usr/bin/sytemctl'.
Fixed the typo in the HA-script.

Change-Id: Ied9fb85e25646ef00b303e361966e9d1354fe440
BUG: 1259225
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/12089
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

CommonHA: Avoid scp of the config state to the same host

2015-09-03T00:31:35+00:00

During add-node, have seen an issue where in scp doesn't work
if the source and destination host are same. Fixed the same.

Change-Id: I33fc18ff39e54ced277f94afef7a11a22c9ccce0
BUG: 1259225
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/12091
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

common-ha : refresh-config should print sensible output

2015-08-25T03:47:09+00:00

ganesha-ha.sh --refresh-config printed the dbus-send output
messages as is on the console. Improving the output
of the operation by redirecting the messages to /var/log/messages
and by checking the exit code of the command executed.

The behaviour is also changed a litlle by exiting
when refresh-config fails on any of the nodes.
We don't want to continue changing config files
on other nodes when refresh-config has already failed
on one of the nodes.

Change-Id: Ic2e4e26bc09b1ba23cc6b62a1590c6083a0bde80
BUG: 1254494
Signed-off-by: Meghana M 
Reviewed-on: http://review.gluster.org/11949
Reviewed-by: soumya k 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: NetBSD Build System

common-ha: concise output for HA status

2015-08-24T05:55:55+00:00

filter out unnecessary detail from the HA status

Change-Id: I407fbec1c61aa35afa7a433187a122975bf3e04d
BUG: 1250628
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/11942
Tested-by: NetBSD Build System 
Reviewed-by: soumya k 
Tested-by: Gluster Build System 
Reviewed-by: Meghana M