glusterfs.git/contrib, branch v3.4.0qa3

fuse: handle mountflags properly

2012-11-19T08:49:36+00:00

The internal mount API had no access to the generic
mountflags used by mount(2).

Thus the "ro" mount option that needs to be passed down to mount(2) as
as a mountflag was incorrectly mangled into the fuse-specific mount
parameter string (cf. http://review.gluster.com/655).

This commit fixes the internal API and the "ro" issue. It also adds a
check for the "rw" and "ro" mount options in tests/basic/mount.t.

Thanks to Csaba Henk (csaba@) for suggestions and proposing an updated
patch.

Change-Id: I7f7bf49ae44d148f5c16f10736a0e412fb8f5e67
BUG: 853895
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/4163
Reviewed-by: Csaba Henk 
Tested-by: Gluster Build System

glusterfs: add gf_mkostemp api and use it instead of mkostemp of libc

2012-10-18T06:37:03+00:00

Change-Id: Icc12b99e2233d22037e2c4bb2b6966e45668b7dd
BUG: 764890
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4091
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

build: split CPPFLAGS from CFLAGS

2012-10-03T19:26:45+00:00

Automake provides a separate variable for preprocessor flags
(*_CPPFLAGS). They are already uses in a few places, so make it
consistent and use it everywhere. Note that cflags obtained from
pkg-config often are cppflags, which is why LIBXML2_CFLAGS moves with
into AM_CPPFLAGS, for example.

Change-Id: I15feed1d18b2ca497371271c4b5876d5ec6289dd
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4029
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

build: consolidate common compilation flags into one variable

2012-10-01T23:44:50+00:00

Some -D flags are present in all files, so collect them.
This adds -D${GF_HOST_OS} to some compiler command lines,
but this should not be a problem.

Change-Id: I1aeb346143d4984c9cc4f2750c465ce09af1e6ca
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4013
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Detect python > 2.5, make sure MKDIR_P is substituted

2012-09-09T18:19:18+00:00

gluster build machine generate configure scripts unable to detect python > 2.5
This change include a more recent python.m4 so that newer python can be
correctly detected.

Build.gluster.com also produces a configure that fails to subsitute
MKDIR_P, leading to bugs at make install. Works this around by
introducing mkdirp.m4 from aclocal-1.11, with the autoconf version test
removed because build.gluster.com also has an outdated autoconf. And
we need a bit from a recent autoconf

NB: this patchset changes nothing since the last one, I just fix title
in gerrit.

BUG: 764655
Change-Id: I3ffac50cc7a10cb9e56dd490dbc2b550bba3fabd
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/3888
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Add missing contrib/libgen files to distribution

2012-08-30T22:24:13+00:00

BUG: 764655
Signed-off-by: Emmanuel Dreyfus 
Change-Id: I3f49eb4a1a186cb2d178539ada6a05c8c1aa8265
Reviewed-on: http://review.gluster.org/3882
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati

remove useless if-before-free (and free-like) functions

2012-07-13T21:03:42+00:00

See comments in http://bugzilla.redhat.com/839925 for
the code to perform this change.

Signed-off-by: Jim Meyering 
BUG: 839925
Change-Id: I10e4ecff16c3749fe17c2831c516737e08a3205a
Reviewed-on: http://review.gluster.com/3661
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

read_conf: don't let a corrupt config file cause invalid line[-1] reference

2012-07-12T02:14:52+00:00

Change-Id: Ifbc698768d9418a54c1501efa335edd4048cfd41
BUG: 789278
Signed-off-by: Jim Meyering 
Reviewed-on: http://review.gluster.com/3603
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

get_mnt_opts: don't let empty option string cause (*mpt_optsp)[-1] reference

2012-07-02T22:58:33+00:00

This looks like a "can't happen" case (depending on what add_option does),
so you may prefer to add an assertion instead.

Change-Id: Ibfdd34fca045e5213de836cca252bd96408b2136
BUG: 789278
Signed-off-by: Jim Meyering 
Reviewed-on: http://review.gluster.com/3604
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Switch to GNU basename_r() and dirname_r()

2012-05-25T04:51:12+00:00

BSD basename() and dirname() return static storage, hence they are not
thread safe, while GNU flavors are. glusterfs assumes the GNU behavior.
As a fix, we added a BSD-derived, thread-safe version of basename_r()
and dirname_r() in contrib/libgen. BSD systems can use it instead of
their built in versions.

Unfortunately, there are more reliance on GNU behavior in glusterfs.
There are place where free() is called on static storage returned by
basename(), place where a second call to dirname() overwrite the
string obtained once, and so forth.

Each of these problems can be fixed, but it is likely to be a pandora
box. We need to accept that glusterfs heavily rely on GNU behavior,
and switch contrib/libgen's basename_r() and dirname_r() to the GNU
version. This change does just that.

BUG: 764655
Change-Id: Id874b9c7aacd9aa3a7a4bd6a92a9633f5b2d6ac0
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3430
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati