glusterfs.git/configure.ac, branch v3.5.4beta1

configure: argp-standalone is always built, even when not needed

2015-02-26T21:17:12+00:00

This patch still configures argp, i.e. creates Makefile in
/contrib/argp-standalone, for the `make dist`, but there's no reason
to compile it when it's not going to be linked into anything.

Backport of commit 09d2dcac3a238cfe6bde1a7aed06facfa16caf20:
> Change-Id: Id0fcb717b5821d8a4c176e6274339f46b3a4a249
> BUG: 1086773
> Signed-off-by: Kaleb S. KEITHLEY 
> Reviewed-on: http://review.gluster.org/7440
> Tested-by: Gluster Build System 
> Reviewed-by: Harshavardhana 
> Reviewed-by: Niels de Vos 
> Reviewed-by: Anand Avati 

Change-Id: Id0fcb717b5821d8a4c176e6274339f46b3a4a249
BUG: 1191006
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9761
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

api: versioned symbols in libgfapi.so for compatibility

2015-02-09T12:16:53+00:00

Use versioned symbols to keep libgfapi at libgfapi.so.0.0.0

Some nits uncovered:

+ there are a couple functions declared that do not have an
  associated definition, e.g. glfs_truncate(), glfs_caller_specific_init()

+ there are five private/internal functions used by heal/src/glfsheal
  and the gfapi master xlator (glfs-master.c): glfs_loc_touchup(),
  glfs_active_subvol(), and glfs_subvol_done(), glfs_init_done(),
  glfs_resolve_at(); which are not declared in glfs.h;

+ for this initial pass at versioned symbols, we use the earliest version
  of all public symbols, i.e. those for which there are declarations in
  glfs.h or glfs-handles.h.
  Further investigation as we do backports to 3.6, 3.4, and 3.4
  will be required to determine if older implementations need to
  be preserved (forward ported) and their associated alias(es) and
  symbol version(s) defined.

FWIW, we should consider linking all of our libraries with a map, it'll
result in a cleaner ABI. Perhaps something for an intern to do or a
Google Summer of Code project.

Change-Id: I513b9aad9c5fd7d8b34ff33acac35f37b6baaab6
BUG: 1160711
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/9056
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

pkg-config: make the version in gluster-api.pc backwards compatible

2015-02-09T12:15:54+00:00

Once we released gluster-api.pc with version=4. Since then we undid the
library versioning and replaced it with symbol-versioning. The current
libgfapi.so has version 0, but the symbols have the version from the
main package at the time they were added.

Because other packages (like samba) use the pkg-config version, we can
not drop it, or decrease the version easily. The simplest solution is to
keep the version=4 and add sub-digits for the actual package/symbol
versions. In future, the version in gluster-api.pc will be like 4.3.x.y.

Cherry picked from commit 6ba258d2b7d4520af95ff638e02598e4aa247ec4:
> Change-Id: If359c8de5b847a7e818199a7246636113837da2d
> BUG: 1166232
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/9154
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: Lalatendu Mohanty 
> Tested-by: Gluster Build System 

BUG: 1160711
Change-Id: I785335972b357954fe4ede9c599b305c4a56eba7
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9199
Tested-by: Gluster Build System

NetBSD build fixes for release-3.5

2014-06-08T09:18:13+00:00

1) Make sure __THROW is definedThis is a backport of I6e7cb1eb59b84988e155e9a8b696e842b7ff8f7f

2) include  before  so that XDR is defined
This was fixed in master within I20193d3f8904388e47344e523b3787dbeab044acbut weonly pull up

3) NetBSD's gettext is in libintl, hence search it at configure time
This is a backport of I651a74fe49c3f087fe135dab3453fd5b18b4268a

4) include  to have WEXITSTATUS defined
This problem does not exist in master as WEXITSTATUS is not used

5) Do not define popcountl() on NetBSD as it is in 
This is a backport of I4428a88b1e0d7c5f6740022861ffe230dbbd84bd

BUG: 764655
Change-Id: Ieea5a2a627e2b7930525d6c525f1602073574a97
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/7925
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

logging: remove unused message-id scripts

2014-05-24T15:26:08+00:00

The current unused implementation for message-ids in the logs depends on
automatically generated files. The generated files are not included in
the distributed tarball. This causes issues when distributions build
packages, they need to re-run ./autogen.sh to create the needed files.

I thought of including the generated files in the distribution tarball.
However, the contents of these files are not actively used, so it seems
to make more sense to drop it all together. These functions were the
only users of libintl and gettext too, so dropped the requirement
checking from configure.ac.

A replacement for the message-id logging framework is in progress. Any
changes that this patch makes, can be reverted in the submission of
patches for the new framework.

Cherry picked from commit cec37c9b66b8711b213f114875d215f56b8120aa:
> Reference: http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6212
> Change-Id: Iea82dd3910944a5c6be3ee393806eccabd575e11
> BUG: 1038391
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/7714
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 

Change-Id: Iea82dd3910944a5c6be3ee393806eccabd575e11
BUG: 1089054
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/7851
Tested-by: Gluster Build System

heal: glfs-heal implementation

2014-04-28T16:39:39+00:00

Change-Id: I634f24d90cd856ceab3cc0c6e9a91003f443403e
BUG: 1039544
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6511
Tested-by: Gluster Build System 
Reviewed-by: Ravishankar N 
Reviewed-by: Vijay Bellur

features/glupy: Rename Glupy python module to avoid namespace conflict

2014-03-24T17:31:55+00:00

* Rename gluster.py to glupy.py to avoid namespace conflict (#1018619)
* Move the main Glupy files into glusterfs-extra-xlators rpm
* Move the Glupy Translator examples into glusterfs-devel rpm

Backport of: http://review.gluster.org/#/c/6979/

Change-Id: Ie9b71b56502f8e98c527ade381c918446bc7f022
BUG: 1018619
Signed-off-by: Justin Clift 
Reviewed-on: http://review.gluster.org/7316
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Jeff Darcy

Use linkat() instead of link() for portability sake

2014-01-03T06:00:37+00:00

This is a backport of Iccd27ac076b7a74e40dcbaa1c4762fd3ad59da5f

POSIX does not says wether link(2) on symlink should link on
symlink itself or on target. Linux use symlink, most other
systems use target. Using linkat(2) allows the behavior to be
specified, so that the behavior is portable.

Also fix configure test for NetBSD linkata(2), which ceased to work.

BUG: 764655
Change-Id: I7cf9e62ea19c7eb356935c11b480cf637c83126b
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/6594
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterfsd: fix small memory leaks in glusterfsd-mgmt.c

2013-11-30T18:16:29+00:00

E.g. In glusterfs_volfile_fetch(), req.xdata.xdata_val is allocated
in dict_allocate_and_serialize() but not freed after mgmt_submit_request().

A survey of dict_allocate_and_serialize/_submit_request in
glusterfsd-mgmt.c shows no consistent pattern of freeing the xdata_val
and also the dict, which is a little disturbing. (Yes, clearly not
every place this occurs needs to be freed the same way.)

Change-Id: Id3f81346c0c863fa06c7b780a634e9b4ed68e453
BUG: 1036102
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/6384
Reviewed-by: Santosh Pradhan 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

features/quota: Add the quota config xattr to newly added brick

2013-11-26T19:57:11+00:00

Issue:
Quota directory limit configuration is stored in the xattrs. When a new brick
is added these 'limit-set' xattrs have to be created to the directory in the
new brick. This is done by the dht directory healing when the directory is
created in the new brick. Since 'root' directory is already created DHT doesn't
heal the limit-set xattr root.

Solution:
When the add-brick command is issued run the below hook script to heal the
'limit-set' xattr. The hook script does the following only if limit is
configured on root.
    1. Create an auxiliary mount.
    2. getxattr 'limit-set' on the root
    3. setxattr the same value on the root
But this script needs the volume to be started to make the auxiliary mount.

To handle the case when the add-brick is issued when the volume was stopped,
symlink is created by the 'master' script to the corresponding location and
these two are by default disabled.

So, a 'master' script is added in the add-brick/pre. When add-brick command is
issued, it enables one of the scripts mentioned above based on the condition,
    if volume is started - enable add-brick/post script
    else                 - enable start/post script
After the actual script completes its job, it disables itself.

Note:
The enabling and disabling of the script is based on the glusterd's logic, that
it only runs the scripts which starts its name with 'S'. So,
    Enable     - symlink the file to 'S'*
    Disable    - unlink the symlink.

Change-Id: I2d3947a4d686c54417ec95f530af3bdd3444f4e2
BUG: 969461
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/6104
Reviewed-by: Brian Foster 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati