glusterfs.git/cli, branch v3.4.0qa5

cli: fail vol set when value = empty string/string with all whitespaces

2012-12-10T22:18:34+00:00

PROBLEMS:

a. 'volume set' operation accepts empty strings and strings containing
   all whitespaces for value. The result - subsequent attempts to start
   glusterd fail.

b. 'volume set group' operation, when passed an empty string or string
   containing all spaces as value, fopens the wrong file.

FIX:

Made volume set parser in cli check for and invalidate value if its length
is 0 after all the whitespaces have been stripped off.

Change-Id: I6792ee1fe9452d8e25e1fd1eeb1b9981be3389f1
BUG: 859927
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4246
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: cmd history echoes the last command string word twice with --mode=script

2012-12-08T01:11:12+00:00

PROBLEM:

When a gluster command is executed with --mode=script option
enabled, the last word in the command string is echoed twice
in command history.

  Example:
  [2012-12-03 05:29:16.083176]  : volume start dis dis : SUCCESS

FIX:

Terminate argv with NULL when the words are shifted after omitting
"--mode=script" from it.

Change-Id: I3a2623efe02e58c97c34554988938a9299425492
BUG: 823081
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4255
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: add print-logdir option

2012-12-08T01:10:56+00:00

Change-Id: I92fe55d72aa597cbac57a51d2e15b35d2bcfef0e
BUG: 823081
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4275
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Revert "glusterd: add "volume label" command"

2012-12-05T00:27:48+00:00

This reverts commit dad16a51ba7e6b1c57529423c57257dbce97ee93

Test script causing "silent" failures during execution.

Change-Id: I26dbb8ed22256071cb415cc3aff572ef8372600e
Reviewed-on: http://review.gluster.org/4268
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Revert "glusterd, cli: Task id's for async tasks"

2012-12-04T23:59:52+00:00

This reverts commit ed15521d4e5af2b52b78fd33711e7562f5273bc6

Strangely, the test scripts are "silently" passing for failures too. Reverting patch for now.

Change-Id: I802ec1634c7863dc373cc7dc4a47bd4baa72764e
Reviewed-on: http://review.gluster.org/4267
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd, cli: Task id's for async tasks

2012-12-04T22:44:36+00:00

This patch introduces task-id's for async tasks like rebalance, remove-brick and
replace-brick. An id is generated for each task when it is started and displayed
to the user in cli output. The status of running tasks is also included in the
output of "volume status" along with its id, so that a user can easily track the
progress of an async task.

Also,
 * added tests for this feature into the regression test suite.
 * added a python script for creating files, 'create-files.py', courtesy
   Vijaykumar Koppad (vkoppad@redhat.com) into the test suite.

Change-Id: Ib0c0d12e0d6c8f72ace48d303d7ff3102157e876
BUG: 857330
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3942
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: add "volume label" command

2012-12-04T22:42:30+00:00

This command is necessary when the local disk/filesystem containing a brick
is unexpectedly lost and then recreated.  Since 961bc80c, trying to start
the brick will fail because the trusted.glusterfs.volume-id xattr is
missing, and if we can't start it then we can't replace-brick or self-heal
so we're stuck in a permanently degraded state.  This command provides a
way to label the empty brick with the proper volume ID so that further
repair actions become possible.

Change-Id: I1c1e5273a018b7a6b8d0852daf111ddc3fddfdc2
BUG: 860297
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4259
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: fix incorrect xml output of brick tag.

2012-12-04T04:42:09+00:00

Incorrect output:

  
  


Expected output:



Change-Id: I40c30feda4e6f3f1ec5da4122f8965b61c511ae6
BUG: 880993
Signed-off-by: JulesWang 
Reviewed-on: http://review.gluster.org/4262
Reviewed-by: Kaushal M 
Tested-by: Gluster Build System 
Tested-by: Kaushal M

cli: Fix build when libxml2 is absent

2012-12-03T09:01:12+00:00

Also added a note to the top of cli-xml-output.c, explaining the style of coding
to followed when adding code to it.

Change-Id: I7f90a9c075adb49a9e071771d136b6f01ea68d11
BUG: 882780
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4256
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

BD Backend: CLI to create a full/linked clone of a image

2012-11-29T17:40:14+00:00

A new CLI command added to support cloning/snapshotting of a LV device

Syntax is:
$ gluster bd clone :/ 

$ gluster bd snapshot :/  

BUG: 805138
Change-Id: Idc2ac14525a3998329c742bf85a06326cac8cd54
Signed-off-by: M. Mohan Kumar 
Reviewed-on: http://review.gluster.org/3719
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur