glusterfs.git/cli/src, branch v3.7.3

cli: Create missing logbuf_pool

2015-07-24T11:19:30+00:00

        Backport of http://review.gluster.org/#/c/11691/

Since logbuf_pool was not created via glusterfs_ctx_defaults_init(),
the following error was present in cli logs repeateadly for each
and every execution of a gluster command.

E [mem-pool.c:417:mem_get0] (-->/usr/local/lib/libglusterfs.so.0(+0x7e262)
[0x7fdbc0b1f262] -->/usr/local/lib/libglusterfs.so.0(_gf_msg+0x804)
[0x7fdbc0ac7844] -->/usr/local/lib/libglusterfs.so.0(mem_get0+0x78)
[0x7fdbc0af5b48] ) 0-mem-pool: invalid argument [Invalid argument]

This change creates ctx->logbuf_pool via glusterfs_ctx_defaults_init()
in cli.c so that the above error is no longer logged in cli logs.

Change-Id: I3fcd9cfefa06ddd52e1989b039ff5637372c3235
BUG: 1244103
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/11705
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

quota/marker: fix spurious failure afr-quota-xattr-mdata-heal.t

2015-07-13T06:53:27+00:00

This is a backport of http://review.gluster.org/#/c/11583

During quota-update process if inode info is present in size-xattr and
missing in contri-xattrs, then in function '_mq_get_metadata', we set
contri-size as zero (on error -2, which means usage info present, but
inode info missing).
With this we are calculating wrong delta and updating the same.

With this patch we are ignoring errors if inode info in xattrs are
missing

> Change-Id: I7940a0e299b8bb425b5b43746b1f13f775c7fb92
> BUG: 1241153
> Signed-off-by: vmallika 

Change-Id: Ie85fa84b5362ae179cc43402bd6a3a6d96a04b81
BUG: 1241831
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11614
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Krishnan Parthasarathi

common-ha : Fixing add node operation

2015-06-22T09:37:11+00:00

Resource create for the added node referenced a variable
new_node that was never passed. This led to a wrong schema
type in the cib file and hence the added node always ended
up in failed state. And also, resources were wrongly
created twice and led to more errors. I have fixed the variable
name and deleted the repetitive invocation of the recreate-resource
function.

The new node has to be added to the existing ganesha-ha config
file for correct behaviour during subsequent add-node operations.
This edited file has to be copied to all the other cluster nodes.
I have added a fix for this as well.

This is a backport of the fix that is merged on master,
http://review.gluster.org/#/c/11316/5

Change-Id: I21e3fcffe8274986be53766e12a2c049eaa2da09
BUG: 1234216
Signed-off-by: Meghana M 
Reviewed-on: http://review.gluster.org/11337
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: soumya k 
Reviewed-by: Kaleb KEITHLEY

glusterd: Fix snapshot of a volume with geo-rep

2015-06-19T06:37:31+00:00

Problem:
    Snapshot fails for a volume configured with geo-rep
    if geo-rep is created with root user with the following
    syntax.
    gluster vol geo-rep  root@::

    It works fine if created with following syntax.
    gluster vol geo-rep  ::

Cause:
    Geo-rep maintains persistent dictionary of slave associated
    with master volume. The dictionary saves the slave info
    along with 'root@' as sent from cli.
    Snapshot while constructing the working dir path to copy
    configuration files, constructs using this dictionary.
    But the actual working dir is created with out considering
    'root@'. Hence the issue.

Fix:
    Fix is done at two layers.
    1. Parse and negelect 'root@' in cli itself.
    2. For existing geo-rep sessions and upgrade scenarios,
       parse and neglect 'root@' in snapshot code as well.

BUG: 1233056
Change-Id: Ic666e43a1c4ac2f3f0fb957caa77770e1eee4129
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11233
Reviewed-on: http://review.gluster.org/11310
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi

NFS-Ganesha: Automatically export vol that was exported before vol restart

2015-06-18T17:24:42+00:00

Consider a volume that is exported via NFS-Ganesha. Stopping this
volume will automatically unexport the volume. Starting this volume
should automatically export it. Although the logic was already there,
there was a bug in it. Fixing the same by introducing a hook script.

Also with the new CLI options, the hook script S31ganesha-set.sh
is no longer required. Hence, removing the same.
Adding a comment to tell the user that one of the CLI
commands will take a few minutes to complete.

This is a backport of the patch merged on master,
http://review.gluster.org/#/c/11247/

Change-Id: I1c16a978b9e2093a4298ea3024d031fd1a5bb577
BUG: 1232335
Signed-off-by: Meghana Madhusudhan 
Reviewed-on: http://review.gluster.org/11259
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: soumya k 
Reviewed-by: Niels de Vos

features/bitrot: tuanble object signing waiting time value for bitrot

2015-06-17T16:38:59+00:00

 Currently bitrot using 120 second waiting time for object to be signed
 after all fop's released. This signing waiting time value should be tunable.

 Command for changing the signing waiting time will be
 #gluster volume bitrot  signing-time 

Change-Id: I89f3121564c1bbd0825f60aae6147413a2fbd798
BUG: 1231832
Signed-off-by: Gaurav Kumar Garg 
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11105
(cherry picked from commit 554fa0c1315d0b4b78ba35a2d332d7ac0fd07d48)
Reviewed-on: http://review.gluster.org/11235
Tested-by: Gluster Build System

glusterd/tier: glusterd crashed with detach-tier commit force

2015-06-17T05:10:55+00:00

glusterd crashed when doing "detach-tier commit force" on a
non-tiered volume.

>Change-Id: I884771893bb80bec46ae8642c2cfd7e54ab116a6
>BUG: 1228112
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/11081
>Tested-by: Gluster Build System 
>Tested-by: NetBSD Build System 
>Reviewed-by: Joseph Fernandes
>Reviewed-by: Dan Lambright 
>Reviewed-by: Krishnan Parthasarathi 

(cherry picked from commit fefc8730e2a87db41d5f79c9853a14cab86715e5)

Change-Id: Ia536da3ec4c632d7d1cc1575dd2b7b098a2c7aec
BUG: 1230563
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/11174
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Joseph Fernandes
Tested-by: Joseph Fernandes

glusterd/shared_storage: Provide a volume set option to create and mount the shared storage

2015-06-05T09:20:26+00:00

     Backport of http://review.gluster.org/#/c/10793/

Introducing a global volume set option(cluster.enable-shared-storage)
which helps create and set-up the shared storage meta volume.

gluster volume set all cluster.enable-shared-storage enable

On enabling this option, the system analyzes the number of peers
in the cluster, which are currently connected, and chooses three
such peers(including the node the command is issued from). From these
peers a volume(gluster_shared_storage) is created. Depending on the
number of peers available the volume is either a replica 3
volume(if there are 3 connected peers),  or a replica 2 volume(if there
are 2 connected peers). "/var/run/gluster/ss_brick" serves as the
brick path on each node for the shared storage volume. We also mount
the shared storage at "/var/run/gluster/shared_storage" on all the nodes
in the cluster as part of enabling this option. If there is only one node
in the cluster,  or only one node is up then the command will fail

Once the volume is created, and mounted the maintainance of the
volume like adding-bricks, removing bricks etc., is expected to
be the onus of the user.

On disabling the option, we provide the user a warning, and on
affirmation from the user we stop the shared storage volume, and unmount
it from all the nodes in the cluster.

gluster volume set all cluster.enable-shared-storage disable

Change-Id: Idd92d67b93f444244f99ede9f634ef18d2945dbc
BUG: 1228181
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/11086
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Krishnan Parthasarathi

cli: Fix incorrect parse logic for volume heal commands

2015-06-04T08:26:53+00:00

heal-op was being incorrectly set to
GF_SHD_OP_SBRAIN_HEAL_FROM_BIGGER_FILE.

Change-Id: I4d4461c7737feae30102e82f7788083017485669
BUG: 1218570
Reviewed-on: http://review.gluster.org/10771
Signed-off-by: Anuradha 
Reviewed-on: http://review.gluster.org/11043
Reviewed-by: Ravishankar N 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Pranith Kumar Karampuri

tiering: Correct errors in cli and glusterd

2015-06-01T04:31:53+00:00

        Back port of http://review.gluster.org/10768

Problem 1:

volume info shows Cold Bricks instead of Tier type
  eg:
Volume Name: patchy2
Type: Tier
Volume ID: 28c25b8d-b8a1-45dc-b4b7-cbd0b344f58f
Status: Started
Number of Bricks: 3
Transport-type: tcp
Hot Tier :
Hot Tier Type : Distribute
Number of Bricks: 1
Brick1: 10.70.1.35:/home/brick43
Cold Bricks:
Cold Tier Type : Distribute
Number of Bricks: 2
Brick2: 10.70.1.35:/home/brick19
Brick3: 10.70.1.35:/home/brick16
Options Reconfigured:

Problem 2: Detach-tier sending enums of Rebalance

   detach-tier has it's own Enum to send with detach-tier command,
using that enums will make more appropriate.

Problem 3:

Wrongly sets hot_brick count during the dictionary copying for response

>Change-Id: Icc054a999a679456881bc70511470d32ff8a86e4
>BUG: 1211264
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/10768
>Reviewed-by: Atin Mukherjee 
>Reviewed-by: Kaushal M 
>Tested-by: Gluster Build System 
>Tested-by: NetBSD Build System

Change-Id: I889d3b83a1f197b79eb71e594a1ad1f2037ed402
BUG: 1226024
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/10978
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Joseph Fernandes
Reviewed-by: Kaushal M