glusterfs.git/cli/src, branch v3.3.2qa3

libglusterfs/statedump: move options file and statedumps from /tmp

2013-05-14T17:47:09+00:00

Change-Id: I6b107b9a668b0521b955dba8895cbbeaf9e7cb02
BUG: 764890
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/5005
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

localtime and ctime are not MT-SAFE

2013-02-08T20:04:42+00:00

There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
   that another thread calling localtime (or ctime) will over-write
   the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
   not a problem on 64-bit or little-endian 32-bit. But even though
   we probably have zero users on big-ending 32-bit platforms, it's
   still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
   writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
   tracing, or dumping. I submit that if an error somehow occurs in
   the call to localtime or ctime, the log/trace/dump still should
   still occur.
5) Appliances should all have their clocks set to UTC, and all log
   entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()

Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
   e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
   not a function. You don't use i +(32), why use sizeof().
   (And yes, you do use parens with sizeof().)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
   Per-thread stack is limited. Time strings are never longer than ~20
   characters, so why waste 220+ bytes on the stack?

Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
   variations. It's not clear to me whether this ever matters, not to
   mention 3rd party log filtering tools may already rely on a
   particular format. Still it would be nice to have a single manifest
   constant and have every call to localtime/strftime consistently use
   the same format.

BUG: 832173

Change-Id: Iee9719db4576eacc6c75694d9107954d0912cba8
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3613
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

cli: Fix double free in cli_add_key_group

2012-09-14T08:30:30+00:00

Change-Id: I3c2f030ac7c53913612a3fbac5e582c47b005621
BUG: 851237
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3944
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: Added special key "group" for bulk volume set.

2012-09-12T19:26:15+00:00

gluster volume set VOLNAME group group_name

- where group_name is a file under /var/lib/glusterd/groups containing one
  key, value pair per line as below,
  key1=value1
  key2=value2
  [...]
- the command sets key1 to value1 and so on.

Change-Id: Ic4c8dedb98d013b29a74e57f8ee7c1d3573137d2
BUG: 851237
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3896
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: Proper xml output for "gluster peer status"

2012-08-30T10:37:40+00:00

Change-Id: I90952ba2ea606552cf4ad67dd296a440f90592d6
BUG: 847760
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3870
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cli/: Displaying the size in human readable format

2012-08-21T03:41:29+00:00

rebalance status displaying the size in bytes. Converted to
human readable

Change-Id: Id73b6e792c39b85480ddf1dc9c0c22fcaca29530
BUG: 825193
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3810
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

calls to dict_allocate_and_serialize() are not 64-bit clean

2012-08-03T10:54:50+00:00

All calls to dict_allocate_and_serialize() pass the address of a 32-bit
type, but must cast it to the 64-bit pointer type (size_t *).

This happens to work on LE machines, but even if it's apparently benign,
it's still a bug. On BE machines it is not benign.

GF_PROTOCOL_DICT_SERIALIZE() hacks around it by creating a size_t temp
var, but that's, well, a hack, IMO when you consider that all the callers
are actually passing &; the param should just be a u_int * and
eliminate the buggy casts and the temp var in the macro.

Nobody apparently uses the Fedora/EPEL PPC RPMs, but they might. People
are trying to build gluster.org bits on SPARC and tripping over this.

Change-Id: I92ea139f9e3e91ddbbb32a51b96fa582a9515626
Signed-off-by: Kaleb S. KEITHLEY 
BUG: 838928
Reviewed-on: http://review.gluster.com/3643
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cli: Change cli output for heal commands

2012-08-02T06:28:32+00:00

BUG: 826406
Change-Id: Ic32c89b92314ee201ec67afc4617e412d4b4c21d
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3636
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Use inet as default listene

2012-07-13T21:09:14+00:00

This is backport of Change-Id: I172570aa58ea08c4c74cfd28f121d3d4e02a55e0

BUG: 764655
Change-Id: I60232b73c303d296e34871ed317925c9af0d322e
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3575
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

NetBSD build fixes.

2012-07-05T18:28:31+00:00

This is a backport of Change-Id: Ib8183d4b585465d05a7adf3a4ceae93ae1bded15

BUG: 764655
Change-Id: I552b87b72c234b3a11af6ffd4a03975879602363
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3574
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati