glusterfs.git/api, branch v3.7.7

Upcall: Read gfid from iatt in case of invalid inode

2015-12-03T22:52:37+00:00

When any file/dir is looked upon for the first time, inode
created shall be invalid till it gets linked to the inode table.
In such cases, read the gfid from the iatt structure returned
as part of such fops for UPCALL processing.

This is backport of the below patch
 - http://review.gluster.org/12773

Change-Id: Ie5eb2f3be18c34cf7ef172e126c9db5ef7a8512b
BUG: 1287079
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/12773
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12839
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

libgfapi: To support set_volfile-server-transport type "unix"

2015-12-02T09:19:54+00:00

This patch helps libgfapi to get the volfile using Unix domain socket.
run the attachment file in the bug to test.
The patch checks if the glfs_set_volfile_server transport is of type "unix",
If It is then uses rpc_transport_unix_options_build to get the volfile.

Signed-off-by: Mohamed Ashiq 
Signed-off-by: Humble Devassy Chirammal 

>Change-Id: Ifd5d1e7c0d8cc9a906c3c3355b8977141e892a2f
>BUG: 1279739
>Signed-off-by: Mohamed Ashiq 
>Signed-off-by: Humble Devassy Chirammal 
>Reviewed-on: http://review.gluster.org/12563
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Niels de Vos 
>Reviewed-by: Poornima G 
>Reviewed-by: Raghavendra Talur 
>Reviewed-by: Shyamsundar Ranganathan 

Change-Id: I0b3f2023e6698366d8c20d6574f5de7b8a641f30
BUG: 1283038
Reviewed-on: http://review.gluster.org/12645
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

gfapi: xattr key length check to avoid brick crash

2015-11-09T12:07:54+00:00

Added check to test if xattr key length > max allowed for OS
distribution and return:
EINVAL if xattr name pointer is NULL or 0 length
ENAMETOOLONG if xattr name length > max allowed for distribution

Function exit path for invalid input is via label "out:" for
mandatory __GLFS_EXIT_FS.

Typically the VFS does this in the kernel for us.  But since we are
bypassing the VFS by providing the libgfapi to talk directly to the
brick process, we need to add such checks.

Change-Id: I610a8440871200ae4640351902b752777a3ec0c2
BUG: 1272926
Signed-off-by: Milind Changire 
Reviewed-on: http://review.gluster.org/12207
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System 
(cherry picked from commit 47d8d2fc9c88c95dfcae2c5c06e6eb3b1ce03a92)
Reviewed-on: http://review.gluster.org/12387
Reviewed-by: Kaleb KEITHLEY

libgfapi : port missing gf_log's to gf_msg

2015-09-01T05:30:50+00:00

        Backport of http://review.gluster.org/#/c/11891/

Cherry-picked from commit 1e0644031c7ac0fa28f0912e951a9238f7bbe8ab
> Change-Id: I0c5320c09b4a5ff1e9df61a86ac7bd47c1bb1bbb
> BUG: 1252807
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11891
> Tested-by: NetBSD Build System 
> Reviewed-by: Raghavendra Talur 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Humble Devassy Chirammal 
> Reviewed-by: Raghavendra G 

Change-Id: I0c5320c09b4a5ff1e9df61a86ac7bd47c1bb1bbb
BUG: 1258406
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/12063
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G

libgfapi: Gracefully exit when glfd is invalid

2015-08-26T16:17:19+00:00

This is a backport of: http://review.gluster.org/10759

When glfs_* methods operating on glfd are invoked after calling
glfs_close(), the program segfaults inside __GLFS_ENTRY_VALIDATE_FD
trying to deference glfd->fd->inode which is invalid.

Also, returning EBADF seemed more specific than EINVAL.

BUG: 1240920
Change-Id: I13a92dca52da9a300252b69e026581b3a9e931fd
Signed-off-by: Prashanth Pai 
Reviewed-on-master: http://review.gluster.org/10759
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-on: http://review.gluster.org/11571
Reviewed-by: Niels de Vos 
Reviewed-by: Humble Devassy Chirammal 
Reviewed-by: bipin kunal 
Tested-by: NetBSD Build System

libgfapi: adding 'follow' flag to glfs_h_lookupat()

2015-08-25T12:31:35+00:00

This patch is backport of http://review.gluster.org/#/c/11883/

Previously glfs_h_lookupat won't follow the symlink, this patch
introduces new flag `follow` which will resolve the same. Applications
linking against the new library will need to use the new glfs_h_lookupat
API call.

In order to stay compatible with existing binaries that use the previous
glfs_h_lookupat() function, the old symbol needs to stay available.

Verification that there are two versions of glfs_h_lookupat:

  $ objdump -T /usr/lib64/libgfapi.so.0 | grep -w glfs_h_lookupat
  0000000000015070 g    DF .text  000000000000021e  GFAPI_3.7.4 glfs_h_lookupat
  0000000000015290 g    DF .text  0000000000000008 (GFAPI_3.4.2) glfs_h_lookupat

Testing with a binary (based on anonymous_fd_read_write.c from ./tests/)
that was linked against the old library:

  $ objdump -T ./lookupat | grep -w glfs_h_lookupat
  0000000000000000      DF *UND*  0000000000000000  GFAPI_3.4.2 glfs_h_lookupat

Enable debugging for 'ld.so' so that we can check that the GFAPI_3.4.2
version of the symbol gets loaded:

  $ export LD_DEBUG_OUTPUT=lookupat.ld.log LD_DEBUG=all
  $ ./lookupat
  $ grep -w glfs_h_lookupat lookupat.ld.log.2543
  2543:     symbol=glfs_h_lookupat;  lookup in file=./lookupat [0]
  2543:     symbol=glfs_h_lookupat;  lookup in file=/lib64/libgfapi.so.0 [0]
  2543:     binding file ./lookupat [0] to /lib64/libgfapi.so.0 [0]: normal symbol `glfs_h_lookupat' [GFAPI_3.4.2]

This change has been successfully cherry-picked as 1ead86a8bcbfe4045729466e4b98f765f3c13c8d
in master

Upstream reference
>Change-Id: I8bf9b1c19a0585f681bc1a7f84aad1ccd0f75f6a
>BUG: 1252410
>Signed-off-by: Jiffin Tony Thottan 
>Signed-off-by: Niels de Vos 
>Reviewed-on: http://review.gluster.org/11883
>Reviewed-by: soumya k 
>Reviewed-by: Kaleb KEITHLEY 
>Tested-by: NetBSD Build System 
Signed-off-by: Jiffin Tony Thottan 

Change-Id: Idbbf0cd6802f86c53b16377d90d08ff6d99e7b08
BUG: 1256616
Reviewed-on: http://review.gluster.org/12009
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

libgfapi: non-default symbol version macros are incorrect

2015-08-20T05:01:21+00:00

default symbol versions are in form glfs_h_lookupat@@GFAPI_2.7.4,
versus old, non-default versions are in the form glfs_h_lookup@GFAPI_2.4.2

I.e. "@@" versus "@"

Backport of:
* Change-Id: I88a6b129558c0b3a6064de7620b3b20425e80bc9
* BUG: 1254863
* http://review.gluster.org/#/c/11955/

Change-Id: I0d53140e03dc2f501ce11d5b2d67373360f2b8b2
BUG: 1254865
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/11956
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

rpc: add owner xlator argument to rpc_clnt_new

2015-08-14T10:10:47+00:00

The @owner argument tells RPC layer the xlator that owns
the connection and to which xlator THIS needs be set during
network notifications like CONNECT and DISCONNECT.

Code paths that originate from the head of a (volume) graph and use
STACK_WIND ensure that the RPC local endpoint has the right xlator saved
in the frame of the call (callback pair). This guarantees that the
callback is executed in the right xlator context.

The client handshake process which includes fetching of brick ports from
glusterd, setting lk-version on the brick for the session, don't have
the correct xlator set in their frames. The problem lies with RPC
notifications. It doesn't have the provision to set THIS with the xlator
that is registered with the corresponding RPC programs. e.g,
RPC_CLNT_CONNECT event received by protocol/client doesn't have THIS set
to its xlator. This implies, call(-callbacks) originating from this
thread don't have the right xlator set too.

The fix would be to save the xlator registered with the RPC connection
during rpc_clnt_new. e.g, protocol/client's xlator would be saved with
the RPC connection that it 'owns'. RPC notifications such as CONNECT,
DISCONNECT, etc inherit THIS from the RPC connection's xlator.

Change-Id: I9dea2c35378c511d800ef58f7fa2ea5552f2c409
BUG: 1253212
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11436
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G 
(cherry picked from commit f7668938cd7745d024f3d2884e04cd744d0a69ab)
Reviewed-on: http://review.gluster.org/11908
Reviewed-by: Pranith Kumar Karampuri

syncop: Include iatt to 'syncop_link' args

2015-07-15T15:08:30+00:00

Include iatt to 'syncop_link' args to fetch proper attributes of
the newly linked inode.

This is backport of the below fix -
http://review.gluster.org/11611

Change-Id: If6b92961bd7a89add3791ed3a9b494087348b492
BUG: 1243408
Reviewed-on: http://review.gluster.org/11611
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Kaleb KEITHLEY 
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11677
Tested-by: Gluster Build System

gfapi: Update loc->inode accordingly in 'glfs_loc_link'

2015-07-10T10:06:48+00:00

In case if the inode already exits in the cache, inode_link
returns the pointer to the exiting one instead of using loc->inode.
This will result in issues if that invalid inodei(loc->inode) is referenced
further. Fixed the same.

This is backport of the below fix -
http://review.gluster.org/#/c/11572/

BUG: 1241666
Change-Id: I1a89932397f7d2b70d619eeaf862c0a5d7f6b91c
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/11572
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-on: http://review.gluster.org/11606
Tested-by: Gluster Build System